try new pre-commit

Author: skudasov

.githooks/detect-ethereum-keys

@@ -1,23 +1,2 @@
 #!/bin/bash
-
-# Find all 'go.mod' files, get their directories, and run 'go mod tidy'
-find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
-    directory=$(dirname "$file")
-    cd "$directory" || exit 1
-
-    # Run linter and capture exit status
-    set +e
-    golangci-lint run -v
-    linting_result=$?
-    set -e
-
-    # Check linting result
-    if [[ $linting_result -ne 0 ]]; then
-        echo -e "Executing linters in $directory... \e[31mNOK!\e[0m\n"
-        echo -e "Run \`cd $directory && golangci-lint run --fix -v\` and fix the issues\n"
-        exit 1
-    else
-        echo -e "Executing linters in $directory... \e[32mOK!\e[0m\n"
-    fi
-    cd - || exit 1
-done
+devbox run lint

.githooks/detect-rpc-urls

@@ -10,6 +10,7 @@ find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
     go mod tidy
     cd - || exit 1
 done
+
 # pre-commit stashes changes before running the hooks so we can use git to check for changes here
 # Run git diff and capture output
 output=$(git diff --stat)

.githooks/go-lint

@@ -2,11 +2,12 @@
 
 set -e
 
-# Find all 'go.mod' files, get their directories, and run an empty 'go test' in them to compile the tests.
-find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
+# Find all 'go.mod' files, excluding the 'seth' directory, get their directories, and run an empty 'go test' in them to compile the tests.
+# Seth is excluded because it can't be tested like this, env vars are required and setup
+find "./" -path "./seth" -prune -o -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
     dir=$(dirname "$file")
     echo "Executing cd \"$dir\" && go test -run=^# ./..."
     cd "$dir"
     go test -run=^# ./...
     cd -
-done
+done

.githooks/go-mod-local-replace

@@ -4,69 +4,22 @@ repos:
   - repo: local
     hooks:
       - id: go-lint
-        name: Check go lint
+        name: Check Go Lint
         entry: ./.githooks/go-lint
         language: script
         pass_filenames: false
-      - id: go-mod-local-replace
-        name: Check for local replaces in go.mod
-        entry: ./.githooks/go-mod-local-replace
-        language: script
-        files: 'go\.mod$'
-      - id: detect-etherum-keys
-        name: Detect ethereum keys
-        entry: ./.githooks/detect-ethereum-keys
-        language: script
-      - id: detect-rpc-urls
-        name: Check for RPC URLs
-        entry: ./.githooks/detect-rpc-urls
-        language: script
-      - id: detect-typos
-        name: Check for typos
-        entry: ./.githooks/typos
-        language: script
       - id: go-mod-tidy
-        name: Check go mod tidy
+        name: Check Go Mod Tidy
         entry: ./.githooks/go-mod-tidy
         language: script
         pass_filenames: false
-        stages: [pre-push]
       - id: go-test-build
-        name: Check go test build
-        entry: ./.githooks/go-test-build
+        name: Build Go Tests
+        entry: ./.githooks/go-mod-tidy
         language: script
         pass_filenames: false
-        stages: [pre-push]
-      - id: run-unit-tests
-        name: Run unit tests
-        entry: ./.githooks/run-unit-tests
+      - id: typos
+        name: Typos
+        entry: ./.githooks/typos
         language: script
         pass_filenames: false
-        stages: [pre-push]
-  - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: 2c9f875913ee60ca25ce70243dc24d5b6415598c # v4.6.0
-    hooks:
-      - id: detect-private-key
-      - id: detect-aws-credentials
-        args: [--allow-missing-credentials]
-      - id: check-added-large-files
-      - id: check-json
-      - id: check-toml
-      - id: end-of-file-fixer
-      - id: check-case-conflict
-      - id: check-shebang-scripts-are-executable
-      - id: check-merge-conflict
-      - id: trailing-whitespace
-  - repo: https://github.com/gruntwork-io/pre-commit
-    rev: e9250bd69bb312d55364213ff5ff037a09be55d9 # v0.1.12
-    hooks:
-      # TODO: change to using the same lint a in CI
-      # - name: Check Helm charts
-      #   id: helmlint
-      - name: Check shell scripts
-        id: shellcheck
-  - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: bc48c541add1551be726f23c4294c773442341cb # v2.3.2
-    hooks:
-      - name: Prettier
-        id: prettier

.githooks/go-mod-tidy

@@ -2,15 +2,16 @@ package chaos
 
 import (
 	"context"
-	f "github.com/smartcontractkit/chainlink-testing-framework/framework"
-	gf "github.com/smartcontractkit/chainlink-testing-framework/framework/grafana"
-	"github.com/smartcontractkit/chainlink-testing-framework/framework/rpc"
-	"github.com/smartcontractkit/chainlink-testing-framework/havoc"
 	"math/big"
 	"os"
 	"testing"
 	"time"
 
+	f "github.com/smartcontractkit/chainlink-testing-framework/framework"
+	gf "github.com/smartcontractkit/chainlink-testing-framework/framework/grafana"
+	"github.com/smartcontractkit/chainlink-testing-framework/framework/rpc"
+	"github.com/smartcontractkit/chainlink-testing-framework/havoc"
+
 	"github.com/stretchr/testify/require"
 )