Fix lint in seth

Author: lukaszcl

seth/block_stats.go

@@ -73,7 +73,6 @@ func (cs *BlockStats) Stats(startBlock *big.Int, endBlock *big.Int) error {
 	blockMu := &sync.Mutex{}
 	eg := &errgroup.Group{}
 	for bn := startBlock.Int64(); bn < endBlock.Int64(); bn++ {
-		bn := bn
 		eg.Go(func() error {
 			cs.Limiter.Take()
 			block, err := cs.Client.Client.BlockByNumber(context.Background(), big.NewInt(bn))

seth/client.go

@@ -370,7 +370,6 @@ func NewClientRaw(
 		eg, egCtx := errgroup.WithContext(ctx)
 		// root key is element 0 in ephemeral
 		for _, addr := range c.Addresses[1:] {
-			addr := addr
 			eg.Go(func() error {
 				return c.TransferETHFromKey(egCtx, 0, addr.Hex(), bd.AddrFunding, gasPrice)
 			})

seth/client_api_test.go

@@ -230,7 +230,6 @@ func TestAPIKeys(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			wg := &sync.WaitGroup{}
 			for i := 1; i < 61; i++ {
-				i := i
 				wg.Add(1)
 				go func() {
 					defer wg.Done()

seth/contract_store.go

@@ -50,8 +50,7 @@ func (c *ContractStore) GetAllABIs() []*abi.ABI {
 
 	var allABIs []*abi.ABI
 	for _, a := range c.ABIs {
-		alias := a
-		allABIs = append(allABIs, &alias)
+		allABIs = append(allABIs, &a)
 	}
 
 	return allABIs

seth/test_utils/client.go

@@ -52,7 +52,6 @@ func NewClientWithAddresses(t *testing.T, addressCount int, funding *big.Int) *s
 	eg, egCtx := errgroup.WithContext(ctx)
 	// root key is element 0 in ephemeral
 	for _, addr := range addresses {
-		addr := addr
 		eg.Go(func() error {
 			return c.TransferETHFromKey(egCtx, 0, addr, funding, gasPrice)
 		})

seth/tracing.go

@@ -549,12 +549,11 @@ func (t *Tracer) checkForMissingCalls(trace Trace) []*DecodedCall {
 
 		for _, missingSig := range missingSignatures {
 			byteSignature := common.Hex2Bytes(strings.TrimPrefix(missingSig, "0x"))
-			humanName := missingSig
 
 			abiResult, err := t.ABIFinder.FindABIByMethod(UNKNOWN, byteSignature)
 			if err != nil {
 				L.Info().
-					Str("Signature", humanName).
+					Str("Signature", missingSig).
 					Msg("Method not found in any ABI instance. Unable to provide any more tracing information")
 
 				missedCalls = append(missedCalls, unknownCall)
@@ -569,7 +568,7 @@ func (t *Tracer) checkForMissingCalls(trace Trace) []*DecodedCall {
 
 			missedCalls = append(missedCalls, &DecodedCall{
 				CommonData: CommonData{
-					Signature: humanName,
+					Signature: missingSig,
 					Method:    abiResult.Method.Name,
 					Input:     map[string]interface{}{"warning": NO_DATA},
 					Output:    map[string]interface{}{"warning": NO_DATA},