Merge branch 'main' into crib-626/solana-custom-docker

Author: scheibinger

.githooks/detect-ethereum-keys

@@ -1,23 +1,2 @@
 #!/bin/bash
-
-# Find all 'go.mod' files, get their directories, and run 'go mod tidy'
-find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
-    directory=$(dirname "$file")
-    cd "$directory" || exit 1
-
-    # Run linter and capture exit status
-    set +e
-    golangci-lint run -v
-    linting_result=$?
-    set -e
-
-    # Check linting result
-    if [[ $linting_result -ne 0 ]]; then
-        echo -e "Executing linters in $directory... \e[31mNOK!\e[0m\n"
-        echo -e "Run \`cd $directory && golangci-lint run --fix -v\` and fix the issues\n"
-        exit 1
-    else
-        echo -e "Executing linters in $directory... \e[32mOK!\e[0m\n"
-    fi
-    cd - || exit 1
-done
+devbox run -- just lint-all

.githooks/detect-rpc-urls

@@ -10,6 +10,7 @@ find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
     go mod tidy
     cd - || exit 1
 done
+
 # pre-commit stashes changes before running the hooks so we can use git to check for changes here
 # Run git diff and capture output
 output=$(git diff --stat)

.githooks/go-lint

@@ -2,11 +2,37 @@
 
 set -e
 
-# Find all 'go.mod' files, get their directories, and run an empty 'go test' in them to compile the tests.
-find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
+echo "Compiling tests in all packages (excluding seth)"
+
+# Use a temporary file to track failures since variables in pipe loops don't persist
+FAILED_FILE=$(mktemp)
+trap 'rm -f "$FAILED_FILE"' EXIT
+
+# Find all 'go.mod' files, excluding the 'seth' directory
+find "./" -name "go.mod" ! -path ".*seth*" -print0 | while IFS= read -r -d $'\0' file; do
     dir=$(dirname "$file")
-    echo "Executing cd \"$dir\" && go test -run=^# ./..."
-    cd "$dir"
-    go test -run=^# ./...
-    cd -
+    echo "=== Compiling tests in $dir ==="
+
+    # Run in a subshell to avoid cd issues
+    (
+        cd "$dir"
+        # Check if there are any test files before running go test
+        if [ -n "$(find . -name '*_test.go' -print -quit)" ]; then
+            if ! go test -run=^# ./...; then
+                echo "Error: Failed to compile tests in $dir" >&2
+                exit 1  # This exits the subshell
+            fi
+        else
+            echo "No test files found in $dir"
+        fi
+    ) || echo "1" >> "$FAILED_FILE"  # Record failure
 done
+
+# Check if we had any failures
+if [ -s "$FAILED_FILE" ]; then
+    echo "Error: Some packages failed to compile" >&2
+    exit 1
+fi
+
+echo "Test compilation complete"
+exit 0

.githooks/go-mod-local-replace

@@ -0,0 +1,2 @@
+#!/bin/bash
+devbox run -- just goimports-all

.githooks/go-mod-tidy

@@ -0,0 +1,21 @@
+name: Dependency Review
+
+on:
+  pull_request:
+
+permissions: {}
+
+jobs:
+  dependency-review:
+    permissions:
+      contents: read
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+          persist-credentials: false
+      - name: Vulnerability Check
+        uses: smartcontractkit/.github/actions/dependency-review@0cc355785130a83a540187b609c5521094baed92 # [email protected]
+        with:
+          config-preset: default-vulnerability-check-high

.githooks/go-test-build

@@ -5,7 +5,7 @@ on:
   pull_request:
     types: [labeled]
     paths-ignore:
-      - 'tools/**'    
+      - 'tools/**'
 
 jobs:
   eth_env:
@@ -26,12 +26,11 @@ jobs:
       - name: Checkout the Repo
         uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
       - name: Install Go
-        uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/setup-go@d2f9642bcc24a73400568756f24b72c188ac7a9a # v2.3.31
+        uses: smartcontractkit/.github/actions/setup-golang@setup-golang/0.3.2
         with:
-          test_download_vendor_packages_command: cd lib && go mod download
-          go_mod_path: ./lib/go.mod
-          cache_key_id: ctf-go
-          cache_restore_only: 'false'
+          # test_download_vendor_packages_command: cd lib && go mod download
+          go-version-file: ./lib/go.mod
+          use-go-cache: "true"
       - name: Install gotestloghelper
         working-directory: lib
         run: make gotestloghelper_build