Skip to content

Commit 2f3bd87

Browse files
committed
review fixes
1 parent 3e20b58 commit 2f3bd87

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

book/src/framework/components/network_isolation.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
# Containers Network Isolation
22

3-
Some components can be isolated from internet. Since some of them doesn't have `iptables` and must be accessible from local host for debugging we isolate network on DNS level
3+
Some components can be isolated from internet. Since some of them doesn't have `iptables` and must be accessible from local host for debugging we isolate network on DNS level.
44

5-
```
6-
[jd]
7-
# JobDistributor is isolated by default, this flag MUST not be changed!
8-
no_dns = true
5+
JobDistributor is isolated from internet by default to prevent applying manifest changes when run in tests.
96

7+
NodeSet DNS isolation can be controlled with a flag
8+
```
109
[[nodesets]]
1110
# NodeSet DNS can be isolated if needed
1211
no_dns = true

book/src/framework/components/troubleshooting.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@ exit status 1
77
```
88

99
#### Solution
10+
Enable Docker to access your directory
11+
```
12+
Docker Desktop -> Settings -> Resources -> File Sharing
13+
```
1014

11-
Use another directory with write access or change the directory access
1215

1316
## Can't run `anvil`, issue with `Rosetta`
1417
```

framework/components/jd/jd.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ type Input struct {
2929
DockerFilePath string `toml:"docker_file"`
3030
DockerContext string `toml:"docker_ctx"`
3131
DBInput *postgres.Input `toml:"db"`
32-
NoDNS bool `toml:"no_dns"`
3332
Out *Output `toml:"out"`
3433
}
3534

@@ -94,7 +93,7 @@ func NewJD(in *Input) (*Output, error) {
9493
},
9594
ExposedPorts: []string{bindPort},
9695
HostConfigModifier: func(h *container.HostConfig) {
97-
// JobDistributor service must be isolated from internet by default!
96+
// JobDistributor service is isolated from internet by default!
9897
framework.NoDNS(true, h)
9998
h.PortBindings = framework.MapTheSamePort(bindPort)
10099
},

0 commit comments

Comments
 (0)