Skip to content

Commit 318d620

Browse files
authored
Merge branch 'main' into sui-cli
2 parents 8e6f68e + 426cdc9 commit 318d620

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

framework/.changeset/v0.10.28.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Unify local obs stack metrics for otel Prom between local and production, remove suffixes

framework/components/dockercompose/billing_platform_service/docker-compose.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ services:
4747
- "2112:2112"
4848
- "2222:2222"
4949
- "2223:2223"
50+
extra_hosts:
51+
- "host.docker.internal:host-gateway"
5052
healthcheck:
5153
test: ["CMD", "grpc_health_probe", "-addr=localhost:2222"]
5254
interval: 200ms

framework/observability.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,10 @@ func ObservabilityUpFull() error {
173173

174174
func ObservabilityDown() error {
175175
L.Info().Msg("Removing local observability stack")
176-
err := RunCommand("bash", "-c", fmt.Sprintf(`
176+
_ = RunCommand("bash", "-c", fmt.Sprintf(`
177177
cd %s && \
178178
docker compose down -v && docker rm -f promtail
179179
`, "compose"))
180-
if err != nil {
181-
return err
182-
}
183-
return RunCommand("bash", "-c", "rm -rf compose/")
180+
_ = RunCommand("bash", "-c", "rm -rf compose/")
181+
return nil
184182
}

framework/observability/compose/otel.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,15 @@ exporters:
1515
endpoint: "http://loki:3100/otlp"
1616
tls:
1717
insecure: true
18-
otlp:
19-
endpoint: "http://tempo:4317"
18+
otlp/traces:
19+
endpoint: "tempo:4317"
2020
tls:
2121
insecure: true
2222
prometheus:
2323
endpoint: "0.0.0.0:8889"
24+
resource_to_telemetry_conversion:
25+
enabled: true
26+
add_metric_suffixes: false
2427

2528
processors:
2629
transform:
@@ -33,7 +36,7 @@ service:
3336
pipelines:
3437
traces:
3538
receivers: [otlp]
36-
exporters: [debug, otlp]
39+
exporters: [debug, otlp/traces]
3740
logs:
3841
receivers: [otlp]
3942
processors: [transform]

0 commit comments

Comments
 (0)