by default, use lowest postgres version CL node is compatible with (#1376)

Tofel · web-flow · commit 38d21b41718f · 2024-11-26T09:47:41.000+01:00
diff --git a/book/src/framework/components/chainlink/node.md b/book/src/framework/components/chainlink/node.md
@@ -13,7 +13,7 @@ Here we provide full configuration reference, if you want to copy and run it, pl
 
   [cl_node.db]
     # PostgreSQL image version and tag
-    image = "postgres:15.6"
+    image = "postgres:12.0"
     # Pulls the image every time if set to 'true', used like that in CI. Can be set to 'false' to speed up local runs
     pull_image = false
 
diff --git a/book/src/framework/components/chainlink/nodeset.md b/book/src/framework/components/chainlink/nodeset.md
@@ -55,7 +55,7 @@ Then configure NodeSet
   
   [nodeset.db]
     # PostgreSQL image version and tag
-    image = "postgres:15.6"
+    image = "postgres:12.0"
     # Pulls the image every time if set to 'true', used like that in CI. Can be set to 'false' to speed up local runs
     pull_image = false
     # PostgreSQL volume name
diff --git a/book/src/framework/components/state.md b/book/src/framework/components/state.md
@@ -47,7 +47,7 @@ You can also define a custom set of ports for any node
   override_mode = "each"
   
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/book/src/framework/connecting_chainlink_node.md b/book/src/framework/connecting_chainlink_node.md
@@ -15,7 +15,7 @@ Create your configuration in `smoke.toml`
 [cl_node]
 
   [cl_node.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [cl_node.node]
     image = "public.ecr.aws/chainlink/chainlink:v2.17.0"
diff --git a/book/src/framework/nodeset_capabilities.md b/book/src/framework/nodeset_capabilities.md
@@ -28,7 +28,7 @@ Create a configuration file `smoke.toml`
   override_mode = "all"
   
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/book/src/framework/nodeset_compatibility.md b/book/src/framework/nodeset_compatibility.md
@@ -16,7 +16,7 @@ Create a configuration file `smoke.toml`
   override_mode = "each"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/book/src/framework/nodeset_docker_rebuild.md b/book/src/framework/nodeset_docker_rebuild.md
@@ -16,7 +16,7 @@ Create a configuration file `smoke.toml`
   override_mode = "all"
   
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/book/src/framework/nodeset_environment.md b/book/src/framework/nodeset_environment.md
@@ -17,7 +17,7 @@ Create a configuration file `smoke.toml`
   override_mode = "all"
   
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/cmd/interactive.go b/framework/cmd/interactive.go
@@ -62,7 +62,7 @@ func createComponentsFromForm(form *nodeSetForm) error {
 				Nodes:        5,
 				OverrideMode: "all",
 				DbInput: &postgres.Input{
-					Image: "postgres:15.6",
+					Image: "postgres:12.0",
 				},
 				NodeSpecs: nspecs,
 			}, bc)
diff --git a/framework/components/clnode/clnode_test.go b/framework/components/clnode/clnode_test.go
@@ -32,7 +32,7 @@ func TestComponentDockerNodeWithSharedDB(t *testing.T) {
 			name: "basic use case",
 			input: &clnode.Input{
 				DbInput: &postgres.Input{
-					Image:      "postgres:15.6",
+					Image:      "postgres:12.0",
 					Port:       16000,
 					VolumeName: "a",
 				},
@@ -67,7 +67,7 @@ func TestComponentDockerNodeWithDB(t *testing.T) {
 			name: "basic use case",
 			input: &clnode.Input{
 				DbInput: &postgres.Input{
-					Image:      "postgres:15.6",
+					Image:      "postgres:12.0",
 					Port:       15000,
 					VolumeName: "b",
 				},
diff --git a/framework/components/simple_node_set/nodeset_test.go b/framework/components/simple_node_set/nodeset_test.go
@@ -50,7 +50,7 @@ func TestComponentDockerNodeSetSharedDB(t *testing.T) {
 				Nodes:        2,
 				OverrideMode: "all",
 				DbInput: &postgres.Input{
-					Image: "postgres:15.6",
+					Image: "postgres:12.0",
 				},
 				NodeSpecs: []*clnode.Input{
 					{
@@ -79,7 +79,7 @@ func TestComponentDockerNodeSetSharedDB(t *testing.T) {
 				HTTPPortRangeStart: 20000,
 				P2PPortRangeStart:  22000,
 				DbInput: &postgres.Input{
-					Image: "postgres:15.6",
+					Image: "postgres:12.0",
 					Port:  14000,
 				},
 				NodeSpecs: []*clnode.Input{
diff --git a/framework/examples/myproject/chaos.toml b/framework/examples/myproject/chaos.toml
@@ -14,7 +14,7 @@
   override_mode = "all"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/examples/myproject/fake.toml b/framework/examples/myproject/fake.toml
@@ -13,7 +13,7 @@
   override_mode = "all"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/examples/myproject/fork_plus_offchain.toml b/framework/examples/myproject/fork_plus_offchain.toml
@@ -22,7 +22,7 @@
   override_mode = "all"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/examples/myproject/performance_baseline.toml b/framework/examples/myproject/performance_baseline.toml
@@ -13,7 +13,7 @@
   override_mode = "all"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/examples/myproject/scalability.toml b/framework/examples/myproject/scalability.toml
@@ -14,7 +14,7 @@
   override_mode = "all"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/examples/myproject/smoke.toml b/framework/examples/myproject/smoke.toml
@@ -14,7 +14,7 @@
   override_mode = "all"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/framework/examples/myproject/upgrade.toml b/framework/examples/myproject/upgrade.toml
@@ -14,7 +14,7 @@
   override_mode = "each"
 
   [nodeset.db]
-    image = "postgres:15.6"
+    image = "postgres:12.0"
 
   [[nodeset.node_specs]]
 
diff --git a/lib/charts/chainlink/values.yaml b/lib/charts/chainlink/values.yaml
@@ -14,7 +14,7 @@ chainlink:
 db:
   image:
     image: postgres
-    version: 12.18
+    version: 12.0
   stateful: true
   capacity: 1Gi
   resources:
diff --git a/lib/docker/test_env/postgres.go b/lib/docker/test_env/postgres.go
@@ -26,7 +26,7 @@ import (
 	"github.com/smartcontractkit/chainlink-testing-framework/lib/utils/testcontext"
 )
 
-const defaultPostgresImage = "postgres:15.6"
+const defaultPostgresImage = "postgres:12.0"
 
 type PostgresDb struct {
 	EnvComponent
diff --git a/lib/docker/test_env/postgres_test.go b/lib/docker/test_env/postgres_test.go
@@ -24,7 +24,7 @@ func TestPostgresCustomImageVersionNotInMirror(t *testing.T) {
 	require.NoError(t, err)
 }
 
-func TestPostgresWithMirror(t *testing.T) {
+func TestPostgresLowestCompatibleVersion(t *testing.T) {
 	// requires internal docker repo to be set
 	if os.Getenv(config.EnvVarInternalDockerRepo) == "" {
 		t.Skipf("Skipping test because %s is not set", config.EnvVarInternalDockerRepo)
@@ -38,3 +38,19 @@ func TestPostgresWithMirror(t *testing.T) {
 	err = pg.StartContainer()
 	require.NoError(t, err)
 }
+
+func TestPostgresModernVersion(t *testing.T) {
+	// requires internal docker repo to be set
+	if os.Getenv(config.EnvVarInternalDockerRepo) == "" {
+		t.Skipf("Skipping test because %s is not set", config.EnvVarInternalDockerRepo)
+	}
+	l := logging.GetTestLogger(t)
+	network, err := docker.CreateNetwork(l)
+	require.NoError(t, err)
+
+	pgOpt := WithPostgresImageVersion("15.6")
+	pg, err := NewPostgresDb([]string{network.Name}, pgOpt)
+	require.NoError(t, err)
+	err = pg.StartContainer()
+	require.NoError(t, err)
+}
diff --git a/lib/k8s/examples/simple_toml/env_toml_config.go b/lib/k8s/examples/simple_toml/env_toml_config.go
@@ -14,8 +14,8 @@ func main() {
 	// in actual implementation here you should read the config from TOML file instead of creating structs manually
 	chainlinkConfig := ctf_config.ChainlinkImageConfig{
 		Image:           ptr.Ptr("public.ecr.aws/chainlink/chainlink"),
-		Version:         ptr.Ptr("v2.8.0"),
-		PostgresVersion: ptr.Ptr("15.6"),
+		Version:         ptr.Ptr("2.18.0"),
+		PostgresVersion: ptr.Ptr("12.0"),
 	}
 
 	pyroscope := ctf_config.PyroscopeConfig{
diff --git a/lib/k8s/pkg/helm/chainlink/chainlink.go b/lib/k8s/pkg/helm/chainlink/chainlink.go
@@ -150,7 +150,7 @@ func defaultProps() map[string]any {
 		"db": map[string]any{
 			"image": map[string]any{
 				"image":   postgresImage,
-				"version": "12.18",
+				"version": "12.0",
 			},
 			"stateful":                         false,
 			"enablePrometheusPostgresExporter": false,
