try custom ports exposed

Author: skudasov

framework/components/clnode/clnode.go

@@ -51,6 +51,7 @@ type NodeInput struct {
 	UserSecretsOverrides    string   `toml:"user_secrets_overrides"`
 	HTTPPort                int      `toml:"port"`
 	P2PPort                 int      `toml:"p2p_port"`
+	CustomPorts             []int    `toml:"custom_ports"`
 }
 
 // Output represents Chainlink node output, nodes and databases connection URLs
@@ -152,6 +153,35 @@ func newNode(in *Input, pgOut *postgres.Output) (*NodeOut, error) {
 	} else {
 		containerName = framework.DefaultTCName("node")
 	}
+	customPorts := make([]string, 0)
+	for _, p := range in.Node.CustomPorts {
+		customPorts = append(customPorts, fmt.Sprintf("%d/tcp", p))
+	}
+	exposedPorts := []string{httpPort, p2pPort}
+	exposedPorts = append(exposedPorts, customPorts...)
+
+	portBindings := nat.PortMap{
+		nat.Port(httpPort): []nat.PortBinding{
+			{
+				HostIP:   "0.0.0.0",
+				HostPort: fmt.Sprintf("%d/tcp", in.Node.HTTPPort),
+			},
+		},
+		nat.Port(p2pPort): []nat.PortBinding{
+			{
+				HostIP:   "0.0.0.0",
+				HostPort: fmt.Sprintf("%d/udp", in.Node.P2PPort),
+			},
+		},
+	}
+	for _, p := range customPorts {
+		portBindings[nat.Port(p)] = []nat.PortBinding{
+			{
+				HostIP:   "0.0.0.0",
+				HostPort: p,
+			},
+		}
+	}
 
 	req := tc.ContainerRequest{
 		AlwaysPullImage: in.Node.PullImage,
@@ -162,7 +192,7 @@ func newNode(in *Input, pgOut *postgres.Output) (*NodeOut, error) {
 		NetworkAliases: map[string][]string{
 			framework.DefaultNetworkName: {containerName},
 		},
-		ExposedPorts: []string{httpPort, p2pPort},
+		ExposedPorts: exposedPorts,
 		Entrypoint: []string{
 			"/bin/sh", "-c",
 			"chainlink -c /config/config -c /config/overrides -c /config/user-overrides -s /config/secrets -s /config/secrets-overrides -s /config/user-secrets-overrides node start -d -p /config/node_password -a /config/apicredentials",
@@ -171,20 +201,7 @@ func newNode(in *Input, pgOut *postgres.Output) (*NodeOut, error) {
 	}
 	if in.Node.HTTPPort != 0 && in.Node.P2PPort != 0 {
 		req.HostConfigModifier = func(h *container.HostConfig) {
-			h.PortBindings = nat.PortMap{
-				nat.Port(httpPort): []nat.PortBinding{
-					{
-						HostIP:   "0.0.0.0",
-						HostPort: fmt.Sprintf("%d/tcp", in.Node.HTTPPort),
-					},
-				},
-				nat.Port(p2pPort): []nat.PortBinding{
-					{
-						HostIP:   "0.0.0.0",
-						HostPort: fmt.Sprintf("%d/udp", in.Node.P2PPort),
-					},
-				},
-			}
+			h.PortBindings = portBindings
 		}
 	}
 	files := []tc.ContainerFile{

framework/examples/myproject/README.md

@@ -6,14 +6,25 @@
 [![Resiliency](https://img.shields.io/badge/Level_4-Resiliency-blue?branch=maturity-model&job=TestSmoke)](https://github.com/smartcontractkit/chainlink-testing-framework/actions/workflows/framework-golden-tests.yml)
 [![Scalability](https://img.shields.io/badge/Level_5-Scalability-blue?branch=maturity-model&job=TestSmoke)](https://github.com/smartcontractkit/chainlink-testing-framework/actions/workflows/framework-golden-tests.yml)
 
+## Level 0
+
+The team creates and maintains a high-level test plan outlining the components involved and test cases in any format.
+
+If the team decides on minimal or no manual testing and the project is trivial, they can consolidate all test cases into `go test` cases, outline the required implementations and commit templates up front.
+
+The team identifies potential integration points with third-party software, blockchain, and external services and document any testing limitations.
+
+If new components are required, the team implements them following this guide: [Developing Components](https://smartcontractkit.github.io/chainlink-testing-framework/developing/developing_components.html).
+
+
 ## Level 1
 The team maintains a system-level smoke test where all components are deployed using `docker`.
 
 All on-chain changes are done through [chainlink-deployments](https://github.com/smartcontractkit/chainlink-deployments).
 
-The test is readable, and the README clearly explains its purpose.
+The test is readable, and the README clearly explains what is tested.
 
-The test is reliable and stable when run with a `-count 30`.
+The test is stable when run with a `-count 10`.
 
 If your project includes multiple use cases and functionality suitable for end-to-end testing, you can add additional tests at this level.
 
@@ -22,7 +33,7 @@ The team has an "upgrade" test to verify product compatibility with older versio
 
 While the number of compatible versions is team-determined, identifying incompatibilities at the system level early is a valuable, mature practice.
 
-This test deploys specific platform and plugin versions, performs an end-to-end smoke test, and then upgrades (or migrates) the plugin(s) or platform on the same database to ensure that users remain unaffected by the upgrade.
+This test deploys specific platform and plugin versions, performs an end-to-end smoke test, and then upgrades (or migrates) the plugin(s) or platform on the same database to ensure that users remain unaffected by the upgrade or, in case of breaking changes, migration process is tested.
 
 ## Level 3
 The team has a baseline performance testing suite.
@@ -43,6 +54,10 @@ The team has complete ownership of their persistent staging environment.
 
 They can perform upgrades, data migrations, and run advanced load tests to validate the scalability of their applications.
 
+## Explanation
+
+It's essential not to skip levels, as they help us manage complexity gradually and keep the focus on our product.
+
 ## Developing
 Run the tests locally
 ```

framework/examples/myproject/upgrade.toml

@@ -19,6 +19,7 @@
       pull_image = true
 
     [nodeset.node_specs.node]
+      custom_ports = [14000, 14001]
       image = "public.ecr.aws/chainlink/chainlink:v2.16.0"
       pull_image = false
 

framework/examples/myproject/upgrade_test.go

@@ -1,15 +1,13 @@
 package examples
 
 import (
-	"fmt"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/clclient"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/fake"
 	ns "github.com/smartcontractkit/chainlink-testing-framework/framework/components/simple_node_set"
 	"github.com/stretchr/testify/require"
 	"testing"
-	"time"
 )
 
 const (
@@ -55,23 +53,23 @@ func TestUpgrade(t *testing.T) {
 	_, _, err = c[0].CreateJobRaw(testJob)
 	require.NoError(t, err)
 
-	in.NodeSet.NodeSpecs[0].Node.Image = "public.ecr.aws/chainlink/chainlink:v2.17.0"
-	in.NodeSet.NodeSpecs[0].Node.UserConfigOverrides = `
-										[Log]
-										level = 'info'
-`
-	in.NodeSet.NodeSpecs[4].Node.Image = "public.ecr.aws/chainlink/chainlink:v2.17.0"
-	in.NodeSet.NodeSpecs[4].Node.UserConfigOverrides = `
-										[Log]
-										level = 'info'
-`
-
-	out, err = ns.UpgradeNodeSet(in.NodeSet, bc, dp.BaseURLDocker, 3*time.Second)
-	require.NoError(t, err)
-
-	jobs, _, err := c[0].ReadJobs()
-	require.NoError(t, err)
-	fmt.Println(jobs)
+	//	in.NodeSet.NodeSpecs[0].Node.Image = "public.ecr.aws/chainlink/chainlink:v2.17.0"
+	//	in.NodeSet.NodeSpecs[0].Node.UserConfigOverrides = `
+	//										[Log]
+	//										level = 'info'
+	//`
+	//	in.NodeSet.NodeSpecs[4].Node.Image = "public.ecr.aws/chainlink/chainlink:v2.17.0"
+	//	in.NodeSet.NodeSpecs[4].Node.UserConfigOverrides = `
+	//										[Log]
+	//										level = 'info'
+	//`
+	//
+	//	out, err = ns.UpgradeNodeSet(in.NodeSet, bc, dp.BaseURLDocker, 3*time.Second)
+	//	require.NoError(t, err)
+	//
+	//	jobs, _, err := c[0].ReadJobs()
+	//	require.NoError(t, err)
+	//	fmt.Println(jobs)
 
 	t.Run("test something", func(t *testing.T) {
 		for _, n := range out.CLNodes {