Skip to content

Commit 56ce2a4

Browse files
committed
finalize, switch runner back
1 parent caa994f commit 56ce2a4

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

wasp/wasp.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ func NewGenerator(cfg *Config) (*Generator, error) {
320320
dataCancel: dataCancel,
321321
gun: cfg.Gun,
322322
vu: cfg.VU,
323-
executionLoopStart: make(chan struct{}),
323+
executionLoopStart: make(chan struct{}, 1),
324324
Responses: NewResponses(rch),
325325
ResponsesChan: rch,
326326
labels: ls,
@@ -359,9 +359,9 @@ func (g *Generator) runRPSLoop() {
359359
case RPS:
360360
g.ResponsesWaitGroup.Add(1)
361361
// we run pacedCall controlled by stats.CurrentRPS
362+
// start when first segment is loaded, see runScheduleLoop
363+
<-g.executionLoopStart
362364
go func() {
363-
// start when first segment is loaded, see
364-
<-g.executionLoopStart
365365
for {
366366
select {
367367
case <-g.ResponsesCtx.Done():
@@ -481,9 +481,9 @@ func (g *Generator) processSegment() bool {
481481
}
482482
g.currentSegmentMu.Lock()
483483
g.currentSegment = g.scheduleSegments[g.stats.CurrentSegment.Load()]
484-
g.currentSegment.StartTime = time.Now()
485484
g.currentSegmentMu.Unlock()
486485
g.stats.CurrentSegment.Add(1)
486+
g.currentSegment.StartTime = time.Now()
487487
switch g.Cfg.LoadType {
488488
case RPS:
489489
newRateLimit := ratelimit.New(int(g.currentSegment.From), ratelimit.Per(g.Cfg.RateLimitUnitDuration), ratelimit.WithoutSlack)

wasp/wasp_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,13 +449,13 @@ func TestSmokeStaticRPSSchedulePrecision(t *testing.T) {
449449
require.NoError(t, err)
450450
_, failed := gen.Run(true)
451451
require.Equal(t, false, failed)
452-
require.GreaterOrEqual(t, gen.Stats().Success.Load(), int64(980))
452+
require.GreaterOrEqual(t, gen.Stats().Success.Load(), int64(970))
453453
require.LessOrEqual(t, gen.Stats().Success.Load(), int64(1010))
454454
require.Equal(t, gen.Stats().Failed.Load(), int64(0))
455455
require.Equal(t, gen.Stats().CallTimeout.Load(), int64(0))
456456

457457
okData, _, failResponses := convertResponsesData(gen)
458-
require.GreaterOrEqual(t, len(okData), 980)
458+
require.GreaterOrEqual(t, len(okData), 970)
459459
require.LessOrEqual(t, len(okData), 1010)
460460
require.Empty(t, failResponses)
461461
require.Empty(t, gen.Errors())
@@ -501,13 +501,13 @@ func TestSmokeStaticRPSScheduleIsNotBlocking(t *testing.T) {
501501
require.NoError(t, err)
502502
_, failed := gen.Run(true)
503503
require.Equal(t, false, failed)
504-
require.GreaterOrEqual(t, gen.Stats().Success.Load(), int64(980))
504+
require.GreaterOrEqual(t, gen.Stats().Success.Load(), int64(970))
505505
require.LessOrEqual(t, gen.Stats().Success.Load(), int64(1010))
506506
require.Equal(t, gen.Stats().Failed.Load(), int64(0))
507507
require.Equal(t, gen.Stats().CallTimeout.Load(), int64(0))
508508

509509
okData, _, failResponses := convertResponsesData(gen)
510-
require.GreaterOrEqual(t, len(okData), 980)
510+
require.GreaterOrEqual(t, len(okData), 970)
511511
require.LessOrEqual(t, len(okData), 1010)
512512
require.Empty(t, failResponses)
513513
require.Empty(t, gen.Errors())

0 commit comments

Comments
 (0)