Skip to content

Commit 58872ef

Browse files
committed
revert environment.go
1 parent ad1fd22 commit 58872ef

File tree

1 file changed

+2
-22
lines changed

1 file changed

+2
-22
lines changed

lib/k8s/environment/environment.go

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -246,30 +246,17 @@ var requiredChainLinkWorkloadAndPodLabels = append([]string{}, append(requiredCh
246246
// validateRequiredChainLinkLabels validates whether the namespace, workloads ands pods have the required chain.link labels
247247
// and returns an error with a list of missing labels if any
248248
func (m *Environment) validateRequiredChainLinkLabels() error {
249-
if m.root == nil {
250-
return fmt.Errorf("m.root is nil, cannot validate namespace labels")
251-
}
252-
253249
if m.root.Labels() == nil {
254-
return fmt.Errorf("namespace labels are nil, but it should contain at least '%s' labels. Please add them to your environment config under 'Labels' key",
255-
strings.Join(requiredChainLinkNsLabels, ", "))
250+
return fmt.Errorf("namespace labels are nil, but it should contain at least '%s' labels. Please add them to your environment config under 'Labels' key", strings.Join(requiredChainLinkNsLabels, ", "))
256251
}
257252

258253
var missingNsLabels []string
259-
// Safely access the map
260254
for _, l := range requiredChainLinkNsLabels {
261-
labels := m.root.Labels()
262-
if _, ok := (*labels)[l]; !ok {
255+
if _, ok := (*m.root.Labels())[l]; !ok {
263256
missingNsLabels = append(missingNsLabels, l)
264257
}
265258
}
266259

267-
// Report missing labels if any
268-
if len(missingNsLabels) > 0 {
269-
return fmt.Errorf("missing required namespace labels: %s",
270-
strings.Join(missingNsLabels, ", "))
271-
}
272-
273260
children := m.root.Node().Children()
274261
// map[workflow name][missing labels]
275262
missingWorkloadLabels := make(map[string][]string)
@@ -423,8 +410,6 @@ func (m *Environment) initApp() error {
423410
return err
424411
}
425412

426-
log.Info().Interface("Labels", nsLabels).Msg("Converted Namespace labels")
427-
428413
m.root = cdk8s.NewChart(m.App, ptr.Ptr(fmt.Sprintf("root-chart-%s", m.Cfg.Namespace)), &cdk8s.ChartProps{
429414
Labels: nsLabels,
430415
Namespace: ptr.Ptr(m.Cfg.Namespace),
@@ -535,8 +520,6 @@ func (m *Environment) ReplaceHelm(name string, chart ConnectedChart) (*Environme
535520
m.err = err
536521
}
537522

538-
log.Info().Str("WorkloadLabels", fmt.Sprintf("%v", workloadLabels)).Msg("WorkloadLabels")
539-
540523
addRequiredChainLinkLabelsToWorkloads(h, workloadLabels)
541524
addDefaultPodAnnotationsAndLabels(h, markNotSafeToEvict(m.Cfg.PreventPodEviction, nil), podLabels)
542525
m.Charts = append(m.Charts, chart)
@@ -697,9 +680,6 @@ func (m *Environment) AddHelm(chart ConnectedChart) *Environment {
697680
if err != nil {
698681
m.err = err
699682
}
700-
701-
log.Info().Str("WorkloadLabels", fmt.Sprintf("%v", workloadLabels)).Msg("WorkloadLabels")
702-
703683
addRequiredChainLinkLabelsToWorkloads(h, workloadLabels)
704684
addDefaultPodAnnotationsAndLabels(h, markNotSafeToEvict(m.Cfg.PreventPodEviction, nil), podLabels)
705685
m.Charts = append(m.Charts, chart)

0 commit comments

Comments
 (0)