Skip to content

Commit 5d27c0f

Browse files
committed
review fixes
1 parent 03b2126 commit 5d27c0f

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

lib/k8s/Dockerfile.base

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# base test for all k8s test runs
2-
FROM golang:bullseye
2+
FROM golang:1.25.3-bookworm
33

44
ARG BASE_URL
55
ARG HELM_VERSION

lib/k8s/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ build:
44

55
.PHONY: push
66
push:
7+
@if [ -z "$(registry)" ]; then echo "Error: registry variable is not set. Please provide it with 'make push registry=...'. See README.md explaining where to get it."; exit 1; fi
78
aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin $(registry).dkr.ecr.us-west-2.amazonaws.com
89
docker tag test-base-image:latest $(registry).dkr.ecr.us-west-2.amazonaws.com/test-base-image:latest
910
docker push $(registry).dkr.ecr.us-west-2.amazonaws.com/test-base-image:latest

lib/k8s/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@
77
We were using this `K8s` framework specifically in `sdlc` cluster but after migration to `main.stage` we use it only on-demand for some legacy tests.
88

99
### Building Base Image for K8s Tests
10-
Is rarely required but sometimes we need infrequent updates.
10+
This is rarely required, but sometimes infrequent updates are needed.
1111

12-
Go to SSO [home](https://sso.smartcontract.com/app/UserHome) and find AWS tile, use creds for `secure-sdlc` account in your terminal, then build and push the image.
13-
14-
You can find `sdlc` registry id in AWS UI.
12+
Go to SSO [home](https://sso.smartcontract.com/app/UserHome) and find `AWS -> secure-sdlc`, copy the registry ID
13+
```
14+
<sdlc_registry_id> | [email protected]
15+
```
16+
use creds for this account in your terminal, paste the <sdlc_registry_id> then build and push the image.
1517

1618
```bash
1719
make build

0 commit comments

Comments
 (0)