Seth more gas conservative tip (#1668)

Author: Tofel

seth/.changeset/v1.51.1.md

@@ -0,0 +1 @@
+- Use more conservative gas tip estimation, i.e. call `FeeHistory` endpoint with tip percentile corresponding to given priory and then select median value

seth/gas_adjuster.go

@@ -504,38 +504,58 @@ func classifyCongestion(congestionMetric float64) string {
 }
 
 func (m *Client) HistoricalFeeData(priority string) (baseFee float64, historicalGasTipCap float64, err error) {
+	var percentileTip float64
+
+	// based on priority decide, which percentile to use to get historical tip values, when calling FeeHistory
+	switch priority {
+	case Priority_Degen:
+		percentileTip = 100
+	case Priority_Fast:
+		percentileTip = 99
+	case Priority_Standard:
+		percentileTip = 50
+	case Priority_Slow:
+		percentileTip = 25
+	default:
+		err = fmt.Errorf("unknown priority: %s", priority)
+		L.Debug().
+			Str("Priority", priority).
+			Msgf("Unknown priority: %s", err.Error())
+
+		return
+	}
+
 	estimator := NewGasEstimator(m)
-	stats, err := estimator.Stats(m.Cfg.Network.GasPriceEstimationBlocks, 99)
+	stats, err := estimator.Stats(m.Cfg.Network.GasPriceEstimationBlocks, percentileTip)
 	if err != nil {
 		L.Debug().
 			Msgf("Failed to get fee history due to: %s", err.Error())
 
 		return
 	}
 
+	// base fee should still be based on priority, because FeeHistory returns whole base fee history, not just the requested percentile
 	switch priority {
 	case Priority_Degen:
 		baseFee = stats.GasPrice.Max
-		historicalGasTipCap = stats.TipCap.Max
 	case Priority_Fast:
 		baseFee = stats.GasPrice.Perc99
-		historicalGasTipCap = stats.TipCap.Perc99
 	case Priority_Standard:
 		baseFee = stats.GasPrice.Perc50
-		historicalGasTipCap = stats.TipCap.Perc50
 	case Priority_Slow:
 		baseFee = stats.GasPrice.Perc25
-		historicalGasTipCap = stats.TipCap.Perc25
 	default:
 		err = fmt.Errorf("unknown priority: %s", priority)
 		L.Debug().
 			Str("Priority", priority).
 			Msgf("Unknown priority: %s", err.Error())
 
 		return
-
 	}
 
+	// since we have already requested reward percentiles based on priority, let's now use the median, i.e. most common tip
+	historicalGasTipCap = stats.TipCap.Perc50
+
 	return
 }
 

seth/gas_test.go

@@ -13,7 +13,7 @@ func TestGasEstimator(t *testing.T) {
 	c := newClient(t)
 	bn, err := c.Client.BlockNumber(context.Background())
 	require.NoError(t, err, "BlockNumber should not error")
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		_, err := c.DeployContractFromContractStore(c.NewTXOpts(), "NetworkDebugSubContract")
 		require.NoError(t, err, "Deploying contract should not error")
 	}

seth/seth.toml

@@ -49,7 +49,7 @@ root_key_funds_buffer = 10 # 10 ether
 
 # feature-flagged expriments; first one sets funds return priority to 'slow' (core only!), second one
 # sets the tip/base fee to the higher value in case there's 3+ orders of magnitude difference between them
-experiments_enabled = ["slow_funds_return", "eip_1559_fee_equalizer"]
+# experiments_enabled = ["slow_funds_return", "eip_1559_fee_equalizer"]
 
 # when enabled when creating a new Seth client we will send 10k wei from root address to root address
 # to make sure transaction can be submitted and mined
@@ -81,6 +81,32 @@ key_sync_retries = 10
 [block_stats]
 rpc_requests_per_second_limit = 15
 
+[[networks]]
+name = "Ethereum_Mainnet"
+dial_timeout = "1m"
+transaction_timeout = "30s"
+eip_1559_dynamic_fees = true
+
+# automated gas estimation
+gas_price_estimation_enabled = true
+gas_price_estimation_blocks = 20
+gas_price_estimation_tx_priority = "standard"
+# how many times to try fetching & calculating gas price data in case of errors, defaults to 1 if empty
+gas_price_estimation_attempt_count = 2
+# urls_secret = ["xxx"]
+
+# gas limits
+transfer_gas_fee = 21_000
+# gas limit should be explicitly set only if you are connecting to a node that's incapable of estimating gas limit itself (should only happen for very old versions)
+# gas_limit = 14_000_000
+
+# manual settings, used when gas_price_estimation_enabled is false or when it fails
+# legacy transactions
+gas_price = 1_000_000_000
+# EIP-1559 transactions
+gas_fee_cap = 25_000_000_000
+gas_tip_cap = 5_000_000_000
+
 [[networks]]
 name = "Anvil"
 dial_timeout = "1m"