Skip to content

Commit 7f48f39

Browse files
committed
Don't fail on unattributable panic
1 parent 242e90a commit 7f48f39

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

tools/flakeguard/runner/runner.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,8 @@ func (r *Runner) parseTestResults(jsonOutputPaths []string, runPrefix string, ru
388388
}
389389
panicTest, timeout, err := attributePanicToTest(outputs)
390390
if err != nil {
391-
return nil, err
391+
log.Warn().Err(err).Msg("Unable to attribute panic to a test")
392+
panicTest = "UnableToAttributePanicTest"
392393
}
393394
panicTestKey := fmt.Sprintf("%s/%s", entryLine.Package, panicTest)
394395

tools/flakeguard/runner/runner_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ func TestAttributePanicToTest(t *testing.T) {
541541
"\t/opt/hostedtoolcache/go/1.24.0/x64/src/testing/testing.go:1851 +0x413",
542542
" logger.go:146: 03:14:04.485880684\tINFO\tDeployed KeystoneForwarder 1.0.0 chain selector 909606746561742123 addr 0x72B66019aCEdc35F7F6e58DF94De95f3cBCC5971\t{\"version\": \"(devel)@unset\"}",
543543
" logger.go:146: 03:14:04.486035865\tINFO\tdeploying forwarder\t{\"version\": \"(devel)@unset\", \"chainSelector\": 5548718428018410741}",
544-
" logger.go:146: 2025-03-08T03:14:04.490Z\tINFO\tchangeset/jd_register_nodes.go:91\tregistered node\t{\"version\": \"unset@unset\", \"name\": \"node1\", \"id\": \"node:{id:\\\"895776f5ba0cc11c570a47b5cc3dbb8771da9262cfb545cd5d48251796af7f1d\\\" public_key:\\\"895776f5ba0cc11c570a47b5cc3dbb8771da9262cfb545cd5d48251796af7f1d\\\" is_enabled:true is_connected:true labels:{key:\\\"product\\\" value:\\\"test-product\\\"} labels:{key:\\\"environment\\\" value:\\\"test-env\\\"} labels:{key:\\\"nodeType\\\" value:\\\"bootstrap\\\"} labels:{key:\\\"don-0-don1\\\"}\"}",
544+
" logger.go:146: 2025-03-08T03:14:04.490Z\tINFO\tchangeset/jd_register_nodes.go:91\tregistered node\t{\"version\": \"unset@unset\", \"name\": \"node1\", \"id\": \"node:{id:\\\"895776f5ba0cc11c570a47b5cc3dbb8771da9262cfb545cd5d48251796af7f\\\" public_key:\\\"895776f5ba0cc11c570a47b5cc3dbb8771da9262cfb545cd5d48251796af7f\\\" is_enabled:true is_connected:true labels:{key:\\\"product\\\" value:\\\"test-product\\\"} labels:{key:\\\"environment\\\" value:\\\"test-env\\\"} labels:{key:\\\"nodeType\\\" value:\\\"bootstrap\\\"} labels:{key:\\\"don-0-don1\\\"}\"}",
545545
},
546546
},
547547
{

0 commit comments

Comments
 (0)