Better name

Author: kalverra

tools/flakeguard/cmd/aggregate_results.go

@@ -48,7 +48,7 @@ var AggregateResultsCmd = &cobra.Command{
 			log.Fatalf("Error reading test reports: %v", err)
 		}
 
-		allReport, err := reports.AggregateTestReports(testReports...)
+		allReport, err := reports.Aggregate(testReports...)
 		if err != nil {
 			log.Fatalf("Error aggregating results: %v", err)
 		}

tools/flakeguard/reports/reports.go

@@ -91,8 +91,8 @@ func FilterSkippedTests(results []TestResult) []TestResult {
 	return skippedTests
 }
 
-// AggregateTestReports aggregates multiple test reports into a single report.
-func AggregateTestReports(reportsToAggregate ...*TestReport) (*TestReport, error) {
+// Aggregate aggregates multiple test reports into a single report.
+func Aggregate(reportsToAggregate ...*TestReport) (*TestReport, error) {
 	var (
 		// Map to hold unique tests based on their TestName and TestPackage
 		// Key: TestName|TestPackage, Value: TestResult

tools/flakeguard/reports/reports_test.go

@@ -2,9 +2,7 @@ package reports
 
 import (
 	"bytes"
-	"encoding/json"
 	"os"
-	"path/filepath"
 	"testing"
 	"time"
 
@@ -163,18 +161,6 @@ func TestPrintTests(t *testing.T) {
 
 }
 
-// Helper function to write a JSON file for testing
-func writeTempJSONFile(t *testing.T, dir string, filename string, data interface{}) string {
-	t.Helper()
-
-	filePath := filepath.Join(dir, filename)
-	fileData, err := json.Marshal(data)
-	require.NoError(t, err)
-	err = os.WriteFile(filePath, fileData, 0644) //nolint:gosec
-	require.NoError(t, err)
-	return filePath
-}
-
 func TestAggregateTestResults(t *testing.T) {
 	// Create a temporary directory for test JSON files
 	tempDir, err := os.MkdirTemp("", "aggregatetestresults")
@@ -370,7 +356,7 @@ func TestAggregateTestResults(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.description, func(t *testing.T) {
-			finalReport, err := AggregateTestReports(tc.inputReports...)
+			finalReport, err := Aggregate(tc.inputReports...)
 			if err != nil {
 				t.Fatalf("AggregateTestResults failed: %v", err)
 			}