Cleans up printing

Author: kalverra

tools/flakeguard/reports/reports.go

@@ -243,7 +243,7 @@ func PrintTests(
 		{"**Failures**", fmt.Sprint(fails)},
 		{"**Skips**", fmt.Sprint(skips)},
 	}
-	colWidths := make([]int, len(rows[0]))
+	colWidths := make([]int, len(summaryData[0]))
 
 	for _, row := range summaryData {
 		for i, cell := range row {
@@ -253,6 +253,11 @@ func PrintTests(
 		}
 	}
 
+	if len(rows) == 0 {
+		fmt.Fprintf(w, "No tests found under pass ratio of %.2f%%\n", maxPassRatio*100)
+		return
+	}
+
 	printRow := func(cells []string) {
 		fmt.Fprintf(w, "| %-*s | %-*s |\n", colWidths[0], cells[0], colWidths[1], cells[1])
 	}
@@ -295,12 +300,10 @@ func PrintTests(
 		fmt.Fprintln(w, "|"+buffer.String())
 	}
 
-	if len(rows) == 0 {
-		printRow(headers)
-		printSeparator()
-		for _, row := range rows {
-			printRow(row)
-		}
+	printRow(headers)
+	printSeparator()
+	for _, row := range rows {
+		printRow(row)
 	}
 	return
 }

tools/flakeguard/reports/reports_test.go

@@ -72,6 +72,7 @@ func TestPrintTests(t *testing.T) {
 	testcases := []struct {
 		name                   string
 		testResults            []TestResult
+		maxPassRatio           float64
 		expectedRuns           int
 		expectedPasses         int
 		expectedFails          int
@@ -88,11 +89,14 @@ func TestPrintTests(t *testing.T) {
 					TestName:    "Test1",
 					TestPackage: "package1",
 					PassRatio:   0.75,
+					Successes:   3,
+					Failures:    1,
 					Skipped:     false,
 					Runs:        4,
 					Durations:   []time.Duration{time.Millisecond * 1200, time.Millisecond * 900, time.Millisecond * 1100, time.Second},
 				},
 			},
+			maxPassRatio:           1.0,
 			expectedRuns:           4,
 			expectedPasses:         3,
 			expectedFails:          1,
@@ -102,6 +106,38 @@ func TestPrintTests(t *testing.T) {
 			expectedFlakyTests:     1,
 			expectedStringsContain: []string{"Test1", "package1", "75.00%", "false", "1.05s", "4", "0"},
 		},
+		{
+			name: "multiple passing tests",
+			testResults: []TestResult{
+				{
+					TestName:    "Test1",
+					TestPackage: "package1",
+					PassRatio:   1.0,
+					Skipped:     false,
+					Successes:   4,
+					Runs:        4,
+					Durations:   []time.Duration{time.Millisecond * 1200, time.Millisecond * 900, time.Millisecond * 1100, time.Second},
+				},
+				{
+					TestName:    "Test2",
+					TestPackage: "package1",
+					PassRatio:   1.0,
+					Skipped:     false,
+					Successes:   4,
+					Runs:        4,
+					Durations:   []time.Duration{time.Millisecond * 1200, time.Millisecond * 900, time.Millisecond * 1100, time.Second},
+				},
+			},
+			maxPassRatio:           1.0,
+			expectedRuns:           8,
+			expectedPasses:         8,
+			expectedFails:          0,
+			expectedSkippedTests:   0,
+			expectedPanickedTests:  0,
+			expectedRacedTests:     0,
+			expectedFlakyTests:     0,
+			expectedStringsContain: []string{},
+		},
 	}
 
 	for _, testCase := range testcases {
@@ -110,7 +146,7 @@ func TestPrintTests(t *testing.T) {
 			t.Parallel()
 			var buf bytes.Buffer
 
-			runs, passes, fails, skips, panickedTests, racedTests, flakyTests := PrintTests(&buf, tc.testResults, 1.0)
+			runs, passes, fails, skips, panickedTests, racedTests, flakyTests := PrintTests(&buf, tc.testResults, tc.maxPassRatio)
 			assert.Equal(t, tc.expectedRuns, runs, "wrong number of runs")
 			assert.Equal(t, tc.expectedPasses, passes, "wrong number of passes")
 			assert.Equal(t, tc.expectedFails, fails, "wrong number of failures")
@@ -121,8 +157,7 @@ func TestPrintTests(t *testing.T) {
 
 			// Get the output as a string
 			output := buf.String()
-			expectedContains := []string{"Test1", "package1", "75.00%", "false", "1.05s", "4", "0"}
-			for _, expected := range expectedContains {
+			for _, expected := range tc.expectedStringsContain {
 				assert.Contains(t, output, expected, "output does not contain expected string")
 			}
 		})