run TestConfig without -race

Author: Tofel

.github/workflows/seth-test.yml

@@ -12,41 +12,61 @@ jobs:
           - regex: TestSmoke
             network-type: Geth
             url: "ws://localhost:8546"
+            extra_flags: "-race"
           - regex: TestSmoke
             network-type: Anvil
             url: "http://localhost:8545"
+            extra_flags: "-race"
           - regex: TestAPI
             network-type: Geth
             url: "ws://localhost:8546"
+            extra_flags: "-race"
           - regex: TestAPI
             network-type: Anvil
             url: "http://localhost:8545"
+            extra_flags: "-race"
           - regex: TestTrace
             network-type: Geth
             url: "ws://localhost:8546"
+            extra_flags: "-race"
           - regex: TestTrace
             network-type: Anvil
             url: "http://localhost:8545"
+            extra_flags: "-race"
           - regex: TestCLI
             network-type: Geth
             url: "ws://localhost:8546"
+            extra_flags: "-race"
           - regex: TestCLI
             network-type: Anvil
             url: "http://localhost:8545"
+            extra_flags: "-race"
             # TODO: wasn't stable before, fix if possible
 #          - regex: TestGasBumping
 #            network-type: Geth
 #            url: "ws://localhost:8546"
 #          - regex: TestGasBumping
 #            network-type: Anvil
 #            url: "http://localhost:8545"
-          - regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract|TestConfig'"
+            # Some test config tests use Simualted Backend, which is not has data races...
+          - regex: "'TestConfig'"
             network-type: Geth
             url: "ws://localhost:8546"
+            extra_flags: "''"
             # TODO: still expects Geth WS URL for some reason
-#          - regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract|TestConfig'"
-#            network-type: Anvil
-#            url: "http://localhost:8545"
+          - regex: "'TestConfig'"
+            network-type: Anvil
+            url: "http://localhost:8545"
+            extra_flags: "''"
+          - regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract'"
+            network-type: Geth
+            url: "ws://localhost:8546"
+            extra_flags: "-race"
+            # TODO: still expects Geth WS URL for some reason
+          - regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract'"
+            network-type: Anvil
+            url: "http://localhost:8545"
+            extra_flags: "-race"
     defaults:
       run:
         working-directory: seth
@@ -86,4 +106,4 @@ jobs:
           just-version: '1.39.0'
       - name: Run tests
         run: |
-          devbox run -- just seth-test ${{ matrix.test.network-type }} ${{ matrix.test.url }} ${{ matrix.test.regex }}
+          devbox run -- just seth-test ${{ matrix.test.network-type }} ${{ matrix.test.url }} ${{ matrix.test.regex }} ${{ matrix.test.extra_flags}}

justfile

@@ -120,9 +120,9 @@ seth-Geth:
     geth --graphql --http --http.api admin,debug,web3,eth,txpool,personal,miner,net --http.corsdomain "*" --ws --ws.api admin,debug,web3,eth,txpool,personal,miner,net --ws.origins "*" --mine --miner.etherbase 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266 --unlock f39Fd6e51aad88F6F4ce6aB8827279cffFb92266 --allow-insecure-unlock --datadir ./geth_data --password geth_data/password.txt --nodiscover --vmdebug --networkid 1337 > /dev/null 2>&1 &
 
 # Seth: run Seth tests, example: just seth-test Anvil http://localhost:8545 "TestAPI"
-seth-test network url test_regex:
+seth-test network url test_regex extra_flags:
     @just seth-{{network}}
-    cd seth && SETH_URL={{url}} SETH_NETWORK={{network}} SETH_ROOT_PRIVATE_KEY=ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 go test -v -race `go list ./... | grep -v examples` -run "{{test_regex}}" || pkill -f {{network}}
+    cd seth && SETH_URL={{url}} SETH_NETWORK={{network}} SETH_ROOT_PRIVATE_KEY=ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 go test -v "{{extra_flags}}" `go list ./... | grep -v examples` -run "{{test_regex}}" || pkill -f {{network}}
 
 # Run pre-commit hooks, build, lint, tidy, check typos
 pre-commit:

seth/client_builder_test.go

@@ -4,6 +4,7 @@ import (
 	"crypto/ecdsa"
 	"math/big"
 	"os"
+	"strings"
 	"testing"
 	"time"
 
@@ -47,8 +48,9 @@ func getRpc() (string, error) {
 	if os.Getenv("SETH_NETWORK") == "" {
 		return "", errors.New("SETH_NETWORK is not set")
 	}
+
 	url := "ws://localhost:8546"
-	if os.Getenv("SETH_NETWORK") == "anvil" {
+	if strings.EqualFold(os.Getenv("SETH_NETWORK"), "anvil") {
 		url = "ws://localhost:8545"
 	}
 
@@ -131,6 +133,9 @@ func TestConfig_MaximalBuilder(t *testing.T) {
 }
 
 func TestConfig_ModifyExistingConfigWithBuilder(t *testing.T) {
+	if strings.EqualFold(os.Getenv("SETH_NETWORK"), "anvil") {
+		t.Skip("skipping test in anvil network")
+	}
 	configPath := os.Getenv(seth.CONFIG_FILE_ENV_VAR)
 	require.NotEmpty(t, configPath, "expected config file path to be set")
 
@@ -295,10 +300,13 @@ func TestConfig_NoPrivateKeys_RpcHealthEnabled(t *testing.T) {
 func TestConfig_NoPrivateKeys_PendingNonce(t *testing.T) {
 	builder := seth.NewClientBuilder()
 
-	_, err := builder.
+	url, err := getRpc()
+	require.NoError(t, err, "failed to get rpc url")
+
+	_, err = builder.
 		// network
 		WithNetworkName("my network").
-		WithRpcUrl("ws://localhost:8546").
+		WithRpcUrl(url).
 		// Gas price and estimations
 		WithEIP1559DynamicFees(true).
 		WithDynamicGasPrices(120_000_000_000, 44_000_000_000).
@@ -384,7 +392,7 @@ func TestConfig_NoPrivateKeys_Tracing(t *testing.T) {
 	require.NoError(t, err, "failed to the client")
 	require.Equal(t, 0, len(client.PrivateKeys), "expected 0 private keys")
 
-	ethClient, err := ethclient.Dial("ws://localhost:8546")
+	ethClient, err := ethclient.Dial(url)
 	require.NoError(t, err, "failed to dial eth client")
 
 	pk, err := crypto.HexToECDSA("ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80")