Skip to content

Commit 9eaee28

Browse files
committed
allow nil for *testing.T in Load[T]
1 parent ad7f1df commit 9eaee28

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

framework/config.go

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -149,19 +149,15 @@ func Load[X any](t *testing.T) (*X, error) {
149149
if err := validate(input); err != nil {
150150
return nil, err
151151
}
152-
t.Cleanup(func() {
153-
err := Store[X](input)
154-
require.NoError(t, err)
155-
})
156-
// TODO: not all the people have AWS access, sadly enough, uncomment when granted
157-
//if os.Getenv(EnvVarAWSSecretsManager) == "true" {
158-
// Secrets, err = NewAWSSecretsManager(1 * time.Minute)
159-
// if err != nil {
160-
// return nil, fmt.Errorf("failed to connect AWSSecretsManager: %w", err)
161-
// }
162-
//}
163-
err = DefaultNetwork(once)
164-
require.NoError(t, err)
152+
if t != nil {
153+
t.Cleanup(func() {
154+
err := Store[X](input)
155+
require.NoError(t, err)
156+
})
157+
}
158+
if err = DefaultNetwork(once); err != nil {
159+
L.Info().Err(err).Msg("docker network creation failed, either docker is not running or you are running in CRIB mode")
160+
}
165161
return input, nil
166162
}
167163

0 commit comments

Comments
 (0)