use docker cmd instead of testcontainers-go (#1412)

* use docker cmd instead of testcontainers-go

* update docs

* remove docker image name

* add cl image override

* update docs

* changeset

Author: skudasov

book/src/SUMMARY.md

@@ -10,6 +10,7 @@
     - [NodeSet with Capabilities](./framework/nodeset_capabilities.md)
     - [NodeSet (Local Docker builds)](./framework/nodeset_docker_rebuild.md)
     - [NodeSet Compat Environment](./framework/nodeset_compatibility.md)
+    - [Creating your own components](./developing/developing_components.md)
     - [Fork Testing](./framework/fork.md)
     - [Quick Contracts Deployment](./framework/quick_deployment.md)
     - [NodeSet with External Blockchain]()
@@ -82,8 +83,6 @@
 
 ---
 
-- [Developing](developing.md)
-  - [Components](developing/developing_components.md)
 - [Releasing modules](releasing_modules.md)
 
 ---

book/src/developing/developing_components.md

@@ -47,13 +47,13 @@ Each component can define inputs and outputs, following these rules:
 - If your component is used for side effects output can be omitted.
 - `input.Out.UseCache` should be added if you'd like to use caching, see more [here](caching)
 
-### Docker components good practices for [testcontainers-go](https://golang.testcontainers.org/):
+### Building Local Images
 
-An example [simple component](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/framework/components/blockchain/anvil.go)
+Use `framework.BuildImage` or `framework.BuildImageOnce` to build the docker image.
 
-An example of [complex component](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/framework/components/clnode/clnode.go)
+Do not use `testcontainers.NewDockerProvider()` methods, see issues: [#1](https://github.com/testcontainers/testcontainers-go/pull/2482), [#2](https://github.com/testcontainers/testcontainers-go/issues/1484)
 
-An example of [composite component](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/framework/components/simple_node_set/node_set.go)
+### Docker components good practices for [testcontainers-go](https://golang.testcontainers.org/):
 
 - Inputs should include at least `image`, `tag` and `pull_image` field
 ```golang
@@ -94,3 +94,10 @@ An example of [composite component](https://github.com/smartcontractkit/chainlin
 		HostURL:   fmt.Sprintf("http://%s:%s", host, mp.Port()),
 	}, nil
 ```
+
+An example [simple component](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/framework/components/blockchain/anvil.go)
+
+An example of [complex component](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/framework/components/clnode/clnode.go)
+
+An example of [composite component](https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/framework/components/simple_node_set/node_set.go)
+

book/src/framework/configuration.md

@@ -12,3 +12,4 @@
 |       LOKI_BASIC_AUTH        |                                                          Basic auth in format $user:$password                                                          |        `$user:$password` |                          -                          |    🚫     |
 |         RESTY_DEBUG          |                                                            Log all Resty client HTTP calls                                                             |          `true`, `false` |                       `false`                       |    🚫     |
 |   CTF_IGNORE_CRITICAL_LOGS   |                                      Ignore all logs that has CRIT,FATAL or PANIC levels (Chainlink nodes only!)                                       |          `true`, `false` |                       `false`                       |    🚫     |
+|       CHAINLINK_IMAGE        |                                           Flag to override Chainlink Docker image in format $repository:$tag                                           |         $repository:$tag |                          -                          |    🚫     |

book/src/framework/nodeset_docker_rebuild.md

@@ -25,5 +25,7 @@ Create a configuration file `smoke.toml`
 
 These paths will work for `e2e/capabilities` in our main [repository](https://github.com/smartcontractkit/chainlink/tree/ctf-v2-tests/e2e/capabilities)
 
+Also check how you can add rebuild to your [components](../developing/developing_components.md#building-local-images).
+
 Summary:
 - We learned how we can quickly re-build local docker image for CL node

framework/.changeset/v0.3.1.md

@@ -0,0 +1,2 @@
+- Use docker cmd instead of testcontainers
+- Add "CHAINLINK_IMAGE" flag to override NodeSet image

framework/components/clnode/clnode.go

@@ -41,7 +41,6 @@ type NodeInput struct {
 	Name                    string   `toml:"name"`
 	DockerFilePath          string   `toml:"docker_file"`
 	DockerContext           string   `toml:"docker_ctx"`
-	DockerImageName         string   `toml:"docker_image_name"`
 	PullImage               bool     `toml:"pull_image"`
 	CapabilitiesBinaryPaths []string `toml:"capabilities"`
 	CapabilityContainerDir  string   `toml:"capabilities_container_dir"`
@@ -259,7 +258,7 @@ func newNode(in *Input, pgOut *postgres.Output) (*NodeOut, error) {
 	}
 	if req.Image == "" {
 		req.Image = TmpImageName
-		if err := framework.BuildImageOnce(ctx, once, in.Node.DockerContext, in.Node.DockerFilePath, req.Image); err != nil {
+		if err := framework.BuildImageOnce(once, in.Node.DockerContext, in.Node.DockerFilePath, req.Image); err != nil {
 			return nil, err
 		}
 		req.KeepImage = false

framework/components/simple_node_set/node_set.go

@@ -7,6 +7,7 @@ import (
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/clnode"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/postgres"
 	"golang.org/x/sync/errgroup"
+	"os"
 	"slices"
 	"strings"
 	"sync"
@@ -79,6 +80,8 @@ func sharedDBSetup(in *Input, bcOut *blockchain.Output) (*Output, error) {
 	}
 	nodeOuts := make([]*clnode.Output, 0)
 
+	envImage := os.Getenv("CHAINLINK_IMAGE")
+
 	// to make it easier for chaos testing we use static ports
 	// there is no need to check them in advance since testcontainers-go returns a nice error
 	var (
@@ -131,7 +134,6 @@ func sharedDBSetup(in *Input, bcOut *blockchain.Output) (*Output, error) {
 					PullImage:               in.NodeSpecs[overrideIdx].Node.PullImage,
 					DockerFilePath:          in.NodeSpecs[overrideIdx].Node.DockerFilePath,
 					DockerContext:           in.NodeSpecs[overrideIdx].Node.DockerContext,
-					DockerImageName:         in.NodeSpecs[overrideIdx].Node.DockerImageName,
 					CapabilitiesBinaryPaths: in.NodeSpecs[overrideIdx].Node.CapabilitiesBinaryPaths,
 					CapabilityContainerDir:  in.NodeSpecs[overrideIdx].Node.CapabilityContainerDir,
 					TestConfigOverrides:     net,
@@ -141,6 +143,10 @@ func sharedDBSetup(in *Input, bcOut *blockchain.Output) (*Output, error) {
 				},
 			}
 
+			if envImage != "" {
+				nodeSpec.Node.Image = envImage
+			}
+
 			dbURLHost := strings.Replace(dbOut.Url, "/chainlink?sslmode=disable", fmt.Sprintf("/db_%d?sslmode=disable", i), -1)
 			dbURL := strings.Replace(dbOut.DockerInternalURL, "/chainlink?sslmode=disable", fmt.Sprintf("/db_%d?sslmode=disable", i), -1)
 			dbSpec := &postgres.Output{

framework/docker.go

@@ -5,7 +5,6 @@ import (
 	"bytes"
 	"context"
 	"encoding/binary"
-	"errors"
 	"fmt"
 	"github.com/docker/docker/api/types/container"
 	"github.com/docker/docker/client"
@@ -15,6 +14,7 @@ import (
 	"golang.org/x/sync/errgroup"
 	"io"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"strings"
 	"sync"
@@ -69,6 +69,14 @@ func DefaultTCName(name string) string {
 	return fmt.Sprintf("%s-%s", name, uuid.NewString()[0:5])
 }
 
+// runCommand executes a command and prints the output.
+func runCommand(name string, args ...string) error {
+	cmd := exec.Command(name, args...)
+	cmd.Stdout = os.Stdout
+	cmd.Stderr = os.Stderr
+	return cmd.Run()
+}
+
 // DockerClient wraps a Docker API client and provides convenience methods
 type DockerClient struct {
 	cli *client.Client
@@ -242,29 +250,19 @@ func WriteAllContainersLogs() error {
 	return eg.Wait()
 }
 
-func BuildImageOnce(ctx context.Context, once *sync.Once, dctx, dfile, nameAndTag string) error {
-	var (
-		p         *tc.DockerProvider
-		dockerCtx string
-		err       error
-	)
+func BuildImageOnce(once *sync.Once, dctx, dfile, nameAndTag string) error {
+	var err error
 	once.Do(func() {
-		nt := strings.Split(nameAndTag, ":")
-		if len(nt) != 2 {
-			err = errors.New("BuildImageOnce, tag must be in 'repo:tag' format")
-			return
+		dfilePath := filepath.Join(dctx, dfile)
+		err = runCommand("docker", "build", "-t", nameAndTag, "-f", dfilePath, dctx)
+		if err != nil {
+			err = fmt.Errorf("failed to build Docker image: %w", err)
 		}
-		p, err = tc.NewDockerProvider()
-		dockerCtx, err = filepath.Abs(dctx)
-		_, err = p.BuildImage(ctx, &tc.ContainerRequest{
-			FromDockerfile: tc.FromDockerfile{
-				Repo:          nt[0],
-				Tag:           nt[1],
-				Context:       dockerCtx,
-				Dockerfile:    dfile,
-				PrintBuildLog: true,
-			},
-		})
 	})
 	return err
 }
+
+func BuildImage(dctx, dfile, nameAndTag string) error {
+	dfilePath := filepath.Join(dctx, dfile)
+	return runCommand("docker", "build", "-t", nameAndTag, "-f", dfilePath, dctx)
+}