fix tests, remove reports

Author: Tofel

wasp/benchspy/direct_test.go

@@ -237,13 +237,13 @@ func TestBenchSpy_DirectQueryExecutor_Execute(t *testing.T) {
 		// expected median latency: (150ms, 151ms>
 		resultsAsFloats, err := ResultsAs(0.0, executor, string(MedianLatency), string(Percentile95Latency), string(Percentile99Latency), string(ErrorRate))
 		assert.NoError(t, err)
-		require.Equal(t, 3, len(resultsAsFloats))
+		require.Equal(t, 4, len(resultsAsFloats))
 		require.InDelta(t, 151.0, resultsAsFloats[string(MedianLatency)], 1.0)
 
 		// since we have 2-3 responses with 200-201ms latency, the 95th percentile should be (200ms, 201ms>
 		require.InDelta(t, 201.0, resultsAsFloats[string(Percentile95Latency)], 1.0)
-		// since we have 2-3 responses with 200-201ms latency, the 99th percentile should be (200ms, 202ms>
-		require.InDelta(t, 202.0, resultsAsFloats[string(Percentile99Latency)], 1.0)
+		// since we have 2-3 responses with 200-201ms latency, the 99th percentile should be (199ms, 203ms>
+		require.InDelta(t, 201.0, resultsAsFloats[string(Percentile99Latency)], 2.0)
 
 		errorRate, exists := resultsAsFloats[string(ErrorRate)]
 		assert.True(t, exists)

wasp/benchspy/report.go

@@ -178,7 +178,7 @@ func CompareDirectWithThresholds(medianThreshold, p95Threshold, p99Threshold, ma
 		Str("Previous report", previousReport.CommitOrTag).
 		Float64("Median threshold", medianThreshold).
 		Float64("P95 threshold", p95Threshold).
-		Float64("P95 threshold", p99Threshold).
+		Float64("P99 threshold", p99Threshold).
 		Float64("Max threshold", maxThreshold).
 		Float64("Error rate threshold", errorRateThreshold).
 		Msg("Comparing Direct metrics with thresholds")

wasp/benchspy/report_test.go

@@ -1621,7 +1621,7 @@ func TestBenchSpy_CompareDirectWithThresholds(t *testing.T) {
 		assert.True(t, failed)
 		assert.NotNil(t, err)
 		assert.Contains(t, err.Error(), fmt.Sprintf("[test-gen] %s metric results were missing from previous report", string(Percentile95Latency)))
-		assert.Contains(t, err.Error(), fmt.Sprintf("[test-gen] %s metric results were missing from current report", string(Percentile99Latency)))
+		assert.Contains(t, err.Error(), fmt.Sprintf("[test-gen] %s metric results were missing from previous report", string(Percentile99Latency)))
 		assert.Contains(t, err.Error(), fmt.Sprintf("[test-gen] %s metric results were missing from previous report", string(MaxLatency)))
 		assert.Contains(t, err.Error(), fmt.Sprintf("[test-gen] %s metric results were missing from previous report", string(ErrorRate)))
 	})