Flakeguard: Resolve Full Paths for Run Command and Extract Test Parser Module (#1736)

* rename

* Move test parser to separate module

* fix

* Add full path resolution for project and results paths in run command

* Use TestGoProjectPath

* fix

* throw error when no tests were run

Author: lukaszcl

.tool-versions

@@ -0,0 +1 @@
+golang 1.24.0

tools/citool/cmd/types.go

@@ -12,7 +12,8 @@ type CITestConf struct {
 	Path                       string            `yaml:"path" json:"path"`
 	TestEnvType                string            `yaml:"test_env_type" json:"test_env_type"`
 	RunsOn                     string            `yaml:"runs_on" json:"runs_on"`
-	TestCmd                    string            `yaml:"test_cmd" json:"test_cmd"`
+	TestGoProjectPath          string            `yaml:"test_go_project_path" json:"test_go_project_path"` // Root path to the go project with the tests
+	TestCmd                    string            `yaml:"test_cmd" json:"test_cmd"`                         // Command to run the test in the TestGoProjectPath
 	TestConfigOverrideRequired bool              `yaml:"test_config_override_required" json:"test_config_override_required"`
 	TestConfigOverridePath     string            `yaml:"test_config_override_path" json:"test_config_override_path"`
 	TestSecretsRequired        bool              `yaml:"test_secrets_required" json:"test_secrets_required"`

tools/flakeguard/cmd/run.go

@@ -6,7 +6,9 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+	"time"
 
+	"github.com/briandowns/spinner"
 	"github.com/rs/zerolog/log"
 	"github.com/smartcontractkit/chainlink-testing-framework/tools/flakeguard/reports"
 	"github.com/smartcontractkit/chainlink-testing-framework/tools/flakeguard/runner"
@@ -64,6 +66,28 @@ var RunTestsCmd = &cobra.Command{
 			log.Warn().Err(err).Str("projectPath", goProject).Msg("Failed to get pretty project path")
 		}
 
+		projectPath, err = utils.ResolveFullPath(projectPath)
+		if err != nil {
+			log.Error().Err(err).Str("projectPath", projectPath).Msg("Failed to resolve full path for project path")
+			flushSummaryAndExit(ErrorExitCode)
+		}
+
+		if mainResultsPath != "" {
+			mainResultsPath, err = utils.ResolveFullPath(mainResultsPath)
+			if err != nil {
+				log.Error().Err(err).Str("mainResultsPath", mainResultsPath).Msg("Failed to resolve full path for main results path")
+				flushSummaryAndExit(ErrorExitCode)
+			}
+		}
+
+		if rerunResultsPath != "" {
+			rerunResultsPath, err = utils.ResolveFullPath(rerunResultsPath)
+			if err != nil {
+				log.Error().Err(err).Str("rerunResultsPath", rerunResultsPath).Msg("Failed to resolve full path for rerun results path")
+				flushSummaryAndExit(ErrorExitCode)
+			}
+		}
+
 		// Retrieve go-test-count flag as a pointer if explicitly provided.
 		var goTestCountFlag *int
 		if cmd.Flags().Changed("go-test-count") {
@@ -133,11 +157,15 @@ var RunTestsCmd = &cobra.Command{
 		// Run the tests
 		var mainResults []reports.TestResult
 		if len(testCmdStrings) > 0 {
+			s := spinner.New(spinner.CharSets[14], 100*time.Millisecond)
+			s.Suffix = " Running custom test command..."
+			s.Start()
 			mainResults, err = testRunner.RunTestCmd(testCmdStrings)
 			if err != nil {
 				log.Fatal().Err(err).Msg("Error running custom test command")
 				flushSummaryAndExit(ErrorExitCode)
 			}
+			s.Stop()
 		} else {
 			mainResults, err = testRunner.RunTestPackages(testPackages)
 			if err != nil {
@@ -147,8 +175,8 @@ var RunTestsCmd = &cobra.Command{
 		}
 
 		if len(mainResults) == 0 {
-			log.Warn().Msg("No tests were run for the specified packages")
-			flushSummaryAndExit(0)
+			log.Error().Msg("No tests were run.")
+			flushSummaryAndExit(ErrorExitCode)
 		}
 
 		// Save the main test results to file