Skip to content

Commit b5dbe8b

Browse files
committed
try adding network cleanup too
1 parent 9747218 commit b5dbe8b

File tree

5 files changed

+16
-14
lines changed

5 files changed

+16
-14
lines changed

framework/cmd/interactive.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func createComponentsFromForm(form *nodeSetForm) error {
3030
_ *simple_node_set.Output
3131
err error
3232
)
33-
if err := framework.DefaultNetwork(&sync.Once{}); err != nil {
33+
if err := framework.DefaultNetwork(t, &sync.Once{}); err != nil {
3434
return err
3535
}
3636
switch form.Network {

framework/components/clnode/clnode_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func TestComponentDockerNodeWithSharedDB(t *testing.T) {
4949
}
5050

5151
for _, tc := range testCases {
52-
err := framework.DefaultNetwork(&sync.Once{})
52+
err := framework.DefaultNetwork(t, &sync.Once{})
5353
require.NoError(t, err)
5454

5555
t.Run(tc.name, func(t *testing.T) {
@@ -84,7 +84,7 @@ func TestComponentDockerNodeWithDB(t *testing.T) {
8484
}
8585

8686
for _, tc := range testCases {
87-
err := framework.DefaultNetwork(&sync.Once{})
87+
err := framework.DefaultNetwork(t, &sync.Once{})
8888
require.NoError(t, err)
8989

9090
t.Run(tc.name, func(t *testing.T) {

framework/components/jd/jd_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
// since JD is private this env var should be set locally and in CI
1515
// TODO: add ComponentDocker prefix to turn this on when we'll have access to ECRs
1616
func TestJD(t *testing.T) {
17-
err := framework.DefaultNetwork(&sync.Once{})
17+
err := framework.DefaultNetwork(t, &sync.Once{})
1818
require.NoError(t, err)
1919
_, err = jd.NewJD(&jd.Input{
2020
Image: os.Getenv("CTF_JD_IMAGE"),

framework/components/simple_node_set/nodeset_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ level = 'info'
113113
}
114114

115115
for _, tc := range testCases {
116-
err := framework.DefaultNetwork(&sync.Once{})
116+
err := framework.DefaultNetwork(t, &sync.Once{})
117117
require.NoError(t, err)
118118

119119
t.Run(tc.name, func(t *testing.T) {

framework/config.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,21 @@ import (
66
"encoding/json"
77
"errors"
88
"fmt"
9-
"github.com/davecgh/go-spew/spew"
10-
"github.com/go-playground/validator/v10"
11-
"github.com/pelletier/go-toml/v2"
12-
"github.com/rs/zerolog"
13-
"github.com/stretchr/testify/require"
14-
"github.com/testcontainers/testcontainers-go"
15-
"github.com/testcontainers/testcontainers-go/network"
169
"os"
1710
"path/filepath"
1811
"strings"
1912
"sync"
2013
"testing"
2114
"text/template"
2215
"time"
16+
17+
"github.com/davecgh/go-spew/spew"
18+
"github.com/go-playground/validator/v10"
19+
"github.com/pelletier/go-toml/v2"
20+
"github.com/rs/zerolog"
21+
"github.com/stretchr/testify/require"
22+
"github.com/testcontainers/testcontainers-go"
23+
"github.com/testcontainers/testcontainers-go/network"
2324
)
2425

2526
const (
@@ -142,19 +143,20 @@ func Load[X any](t *testing.T) (*X, error) {
142143
// return nil, fmt.Errorf("failed to connect AWSSecretsManager: %w", err)
143144
// }
144145
//}
145-
err = DefaultNetwork(once)
146+
err = DefaultNetwork(t, once)
146147
require.NoError(t, err)
147148
return input, nil
148149
}
149150

150-
func DefaultNetwork(once *sync.Once) error {
151+
func DefaultNetwork(t *testing.T, once *sync.Once) error {
151152
var net *testcontainers.DockerNetwork
152153
var err error
153154
once.Do(func() {
154155
net, err = network.New(
155156
context.Background(),
156157
network.WithLabels(map[string]string{"framework": "ctf"}),
157158
)
159+
testcontainers.CleanupNetwork(t, net)
158160
DefaultNetworkName = net.Name
159161
})
160162
return err

0 commit comments

Comments
 (0)