Skip to content

Commit b7cc9ee

Browse files
committed
Rename command to generate-github-reports and update flag for flakeguard report path
1 parent 989ea05 commit b7cc9ee

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

tools/flakeguard/cmd/generate_report.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ import (
1414
)
1515

1616
var GenerateReportCmd = &cobra.Command{
17-
Use: "generate-report",
18-
Short: "Generate test reports from aggregated results that can be posted to GitHub",
17+
Use: "generate-github-reports",
18+
Short: "Generate Github reports from Flakeguard test report",
1919
Run: func(cmd *cobra.Command, args []string) {
2020
fs := reports.OSFileSystem{}
2121

2222
// Get flag values
23-
aggregatedResultsPath, _ := cmd.Flags().GetString("aggregated-results-path")
23+
flakeguardReportPath, _ := cmd.Flags().GetString("flakeguard-report")
2424
outputDir, _ := cmd.Flags().GetString("output-path")
2525
maxPassRatio, _ := cmd.Flags().GetFloat64("max-pass-ratio")
2626
generatePRComment, _ := cmd.Flags().GetBool("generate-pr-comment")
@@ -36,11 +36,11 @@ var GenerateReportCmd = &cobra.Command{
3636

3737
// Load the aggregated report
3838
s := spinner.New(spinner.CharSets[11], 100*time.Millisecond)
39-
s.Suffix = " Loading aggregated test report..."
39+
s.Suffix = " Loading flakeguard test report..."
4040
s.Start()
4141

42-
aggregatedReport := reports.TestReport{}
43-
reportFile, err := os.Open(aggregatedResultsPath)
42+
testReport := reports.TestReport{}
43+
reportFile, err := os.Open(flakeguardReportPath)
4444
if err != nil {
4545
s.Stop()
4646
fmt.Println()
@@ -49,7 +49,7 @@ var GenerateReportCmd = &cobra.Command{
4949
}
5050
defer reportFile.Close()
5151

52-
if err := json.NewDecoder(reportFile).Decode(aggregatedReport); err != nil {
52+
if err := json.NewDecoder(reportFile).Decode(testReport); err != nil {
5353
s.Stop()
5454
fmt.Println()
5555
log.Error().Err(err).Msg("Error decoding aggregated test report")
@@ -70,7 +70,7 @@ var GenerateReportCmd = &cobra.Command{
7070
s.Suffix = " Generating GitHub summary markdown..."
7171
s.Start()
7272

73-
err = generateGitHubSummaryMarkdown(aggregatedReport, filepath.Join(outputDir, "all-test"), failedLogsURL, failedLogsArtifactName)
73+
err = generateGitHubSummaryMarkdown(testReport, filepath.Join(outputDir, "all-test"), failedLogsURL, failedLogsArtifactName)
7474
if err != nil {
7575
s.Stop()
7676
fmt.Println()
@@ -114,7 +114,7 @@ var GenerateReportCmd = &cobra.Command{
114114
s.Start()
115115

116116
err = generatePRCommentMarkdown(
117-
aggregatedReport,
117+
testReport,
118118
filepath.Join(outputDir, "all-test"),
119119
baseBranch,
120120
currentBranch,
@@ -147,7 +147,7 @@ var GenerateReportCmd = &cobra.Command{
147147
}
148148

149149
func init() {
150-
GenerateReportCmd.Flags().StringP("aggregated-results-path", "i", "", "Path to the aggregated JSON report file (required)")
150+
GenerateReportCmd.Flags().StringP("flakeguard-report", "i", "", "Path to the flakeguard test report JSON file (required)")
151151
GenerateReportCmd.Flags().StringP("output-path", "o", "./report", "Path to output the generated report files")
152152
GenerateReportCmd.Flags().Float64P("max-pass-ratio", "", 1.0, "The maximum pass ratio threshold for a test to be considered flaky")
153153
GenerateReportCmd.Flags().Bool("generate-pr-comment", false, "Set to true to generate PR comment markdown")
@@ -160,7 +160,7 @@ func init() {
160160
GenerateReportCmd.Flags().Int64("github-run-id", 0, "The GitHub Actions run ID (required)")
161161
GenerateReportCmd.Flags().String("failed-logs-url", "", "Optional URL linking to additional logs for failed tests")
162162

163-
if err := GenerateReportCmd.MarkFlagRequired("aggregated-results-path"); err != nil {
163+
if err := GenerateReportCmd.MarkFlagRequired("flakeguard-report"); err != nil {
164164
log.Error().Err(err).Msg("Error marking flag as required")
165165
os.Exit(ErrorExitCode)
166166
}

0 commit comments

Comments
 (0)