Skip to content

Commit b7db965

Browse files
committed
copilot review fixes
1 parent 5c4212a commit b7db965

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

framework/.changeset/v0.12.0.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Codegeneration for Devenv

framework/tmpl_gen.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2196,7 +2196,7 @@ func Store[T any](cfg *T) error {
21962196
if err != nil {
21972197
return err
21982198
}
2199-
return os.WriteFile(filepath.Join(DefaultConfigDir, outCacheName), d, 0o600)
2199+
return os.WriteFile(filepath.Join(DefaultConfigDir, outCacheName), d, 0o644)
22002200
}
22012201
22022202
// LoadOutput loads config output file from path.

framework/tmpl_gen_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,9 @@ func TestSmokeGenerateDevEnv(t *testing.T) {
9292
clClients, err := clclient.New(cfg.NodeSets[0].Out.CLNodes)
9393
require.NoError(t, err)
9494

95+
pollEvery := 2 * time.Second
96+
timeout := 2 * time.Minute
97+
9598
// verify that all the services are healthy
9699
require.Eventually(t, func() bool {
97100
failedServices := false
@@ -107,7 +110,7 @@ func TestSmokeGenerateDevEnv(t *testing.T) {
107110
}
108111
}
109112
return !failedServices
110-
}, 2*time.Minute, 2*time.Second)
113+
}, timeout, pollEvery)
111114
})
112115
}
113116
}

0 commit comments

Comments
 (0)