code review changes

Author: Tofel

framework/tracking/dx.go

@@ -156,12 +156,12 @@ func NewDxTracker(APITokenVariableName string, product Product) (Tracker, error)
 	return t, nil
 }
 
-func (t *DxTracker) buildConfigWithGhCLI(APITokenVariableName, product string, existinConfig *config) (*config, error) {
+func (t *DxTracker) buildConfigWithGhCLI(APITokenVariableName, product string, existingConfig *config) (*config, error) {
 	var userNameErr error
 	var c *config
 
-	if existinConfig != nil {
-		c = existinConfig
+	if existingConfig != nil {
+		c = existingConfig
 	} else {
 		c = &config{}
 	}
@@ -280,7 +280,13 @@ func (t *DxTracker) sendEvent(name string, timestamp int64, metadata map[string]
 	}
 
 	if !dxResp.Ok {
-		return fmt.Errorf("failed to send event, error: %s", *dxResp.Error)
+		var errMsg string
+		if dxResp.Error != nil {
+			errMsg = *dxResp.Error
+		} else {
+			errMsg = "unknown error"
+		}
+		return fmt.Errorf("failed to send event, error: %s", errMsg)
 	}
 
 	return nil

framework/tracking/dx_test.go

@@ -27,7 +27,7 @@ func TestDXOverlyLongMetadataTruncation(t *testing.T) {
 	require.NotEqual(t, metadata["to_truncate"], truncated["to_truncate"], "to_truncate should be truncated")
 }
 
-func TestDXOnlyOneOveryLongMetadataTruncationNoPriority(t *testing.T) {
+func TestDXOnlyOneOverlyLongMetadataTruncationNoPriority(t *testing.T) {
 	metadata := map[string]any{
 		"to_truncate":     "abcde" + strings.Repeat("1234567890", 110), // overly long
 		"do_not_truncate": "abcde" + strings.Repeat("1234567890", 50),