Skip to content

Commit c7f5719

Browse files
committed
Update PR comment
1 parent d3a8549 commit c7f5719

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tools/flakeguard/reports/presentation.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func GenerateGitHubSummaryMarkdown(w io.Writer, testReport *TestReport, maxPassR
107107
func GeneratePRCommentMarkdown(w io.Writer, testReport *TestReport, maxPassRatio float64, baseBranch, currentBranch, currentCommitSHA, repoURL, actionRunID string) {
108108
fmt.Fprint(w, "# Flakeguard Summary\n\n")
109109

110-
// Construct additionalInfo inside the function
110+
// Construct additional info
111111
additionalInfo := fmt.Sprintf(
112112
"Ran new or updated tests between `%s` and %s (`%s`).",
113113
baseBranch,
@@ -133,14 +133,15 @@ func GeneratePRCommentMarkdown(w io.Writer, testReport *TestReport, maxPassRatio
133133
return
134134
}
135135

136-
summary := GenerateSummaryData(testReport.Results, maxPassRatio)
137-
if summary.AveragePassRatio < maxPassRatio {
136+
// Add the flaky tests section
137+
if GenerateSummaryData(testReport.Results, maxPassRatio).AveragePassRatio < maxPassRatio {
138138
fmt.Fprintln(w, "## Found Flaky Tests :x:")
139139
} else {
140140
fmt.Fprintln(w, "## No Flakes Found :white_check_mark:")
141141
}
142142

143-
RenderResults(w, testReport.Results, maxPassRatio, true)
143+
resultsTable := GenerateFlakyTestsTable(testReport.Results, maxPassRatio, true)
144+
renderTestResultsTable(w, resultsTable, true)
144145
}
145146

146147
func buildSettingsTable(testReport *TestReport, maxPassRatio float64) [][]string {

0 commit comments

Comments
 (0)