Skip to content

Commit d55cf99

Browse files
committed
run TestConfig without -race
1 parent acc4642 commit d55cf99

File tree

2 files changed

+25
-7
lines changed

2 files changed

+25
-7
lines changed

.github/workflows/seth-test.yml

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,41 +12,59 @@ jobs:
1212
- regex: TestSmoke
1313
network-type: Geth
1414
url: "ws://localhost:8546"
15+
extra_flags: "-race"
1516
- regex: TestSmoke
1617
network-type: Anvil
1718
url: "http://localhost:8545"
19+
extra_flags: "-race"
1820
- regex: TestAPI
1921
network-type: Geth
2022
url: "ws://localhost:8546"
23+
extra_flags: "-race"
2124
- regex: TestAPI
2225
network-type: Anvil
2326
url: "http://localhost:8545"
27+
extra_flags: "-race"
2428
- regex: TestTrace
2529
network-type: Geth
2630
url: "ws://localhost:8546"
31+
extra_flags: "-race"
2732
- regex: TestTrace
2833
network-type: Anvil
2934
url: "http://localhost:8545"
35+
extra_flags: "-race"
3036
- regex: TestCLI
3137
network-type: Geth
3238
url: "ws://localhost:8546"
39+
extra_flags: "-race"
3340
- regex: TestCLI
3441
network-type: Anvil
3542
url: "http://localhost:8545"
43+
extra_flags: "-race"
3644
# TODO: wasn't stable before, fix if possible
3745
# - regex: TestGasBumping
3846
# network-type: Geth
3947
# url: "ws://localhost:8546"
4048
# - regex: TestGasBumping
4149
# network-type: Anvil
4250
# url: "http://localhost:8545"
43-
- regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract|TestConfig'"
51+
# Some test config tests use Simualted Backend, which is not has data races...
52+
- regex: "'TestConfig'"
4453
network-type: Geth
4554
url: "ws://localhost:8546"
4655
# TODO: still expects Geth WS URL for some reason
47-
# - regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract|TestConfig'"
48-
# network-type: Anvil
49-
# url: "http://localhost:8545"
56+
- regex: "'TestConfig'"
57+
network-type: Anvil
58+
url: "http://localhost:8545"
59+
extra_flags: "-race"
60+
- regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract'"
61+
network-type: Geth
62+
url: "ws://localhost:8546"
63+
# TODO: still expects Geth WS URL for some reason
64+
- regex: "'TestContractMap|TestGasEstimator|TestRPCHealthCheck|TestUtil|TestContract'"
65+
network-type: Anvil
66+
url: "http://localhost:8545"
67+
extra_flags: "-race"
5068
defaults:
5169
run:
5270
working-directory: seth
@@ -86,4 +104,4 @@ jobs:
86104
just-version: '1.39.0'
87105
- name: Run tests
88106
run: |
89-
devbox run -- just seth-test ${{ matrix.test.network-type }} ${{ matrix.test.url }} ${{ matrix.test.regex }}
107+
devbox run -- just seth-test ${{ matrix.test.network-type }} ${{ matrix.test.url }} ${{ matrix.test.regex }} ${{ matrix.test.extra_flags}}

justfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,9 @@ seth-Geth:
120120
geth --graphql --http --http.api admin,debug,web3,eth,txpool,personal,miner,net --http.corsdomain "*" --ws --ws.api admin,debug,web3,eth,txpool,personal,miner,net --ws.origins "*" --mine --miner.etherbase 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266 --unlock f39Fd6e51aad88F6F4ce6aB8827279cffFb92266 --allow-insecure-unlock --datadir ./geth_data --password geth_data/password.txt --nodiscover --vmdebug --networkid 1337 > /dev/null 2>&1 &
121121

122122
# Seth: run Seth tests, example: just seth-test Anvil http://localhost:8545 "TestAPI"
123-
seth-test network url test_regex:
123+
seth-test network url test_regex extra_flags:
124124
@just seth-{{network}}
125-
cd seth && SETH_URL={{url}} SETH_NETWORK={{network}} SETH_ROOT_PRIVATE_KEY=ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 go test -v -race `go list ./... | grep -v examples` -run "{{test_regex}}" || pkill -f {{network}}
125+
cd seth && SETH_URL={{url}} SETH_NETWORK={{network}} SETH_ROOT_PRIVATE_KEY=ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 go test -v "{{extra_flags}}" `go list ./... | grep -v examples` -run "{{test_regex}}" || pkill -f {{network}}
126126

127127
# Run pre-commit hooks, build, lint, tidy, check typos
128128
pre-commit:

0 commit comments

Comments
 (0)