Skip to content

Commit d5a4c34

Browse files
committed
Remove separate flag for run all
1 parent fae9ddc commit d5a4c34

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

tools/flakeguard/cmd/run.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ var RunTestsCmd = &cobra.Command{
2020
projectPath, _ := cmd.Flags().GetString("project-path")
2121
testPackagesJson, _ := cmd.Flags().GetString("test-packages-json")
2222
testPackagesArg, _ := cmd.Flags().GetStringSlice("test-packages")
23-
runAllPackages, _ := cmd.Flags().GetBool("run-all-packages")
2423
runCount, _ := cmd.Flags().GetInt("run-count")
2524
useRace, _ := cmd.Flags().GetBool("race")
2625
outputPath, _ := cmd.Flags().GetString("output-json")
@@ -50,7 +49,6 @@ var RunTestsCmd = &cobra.Command{
5049
UseRace: useRace,
5150
FailFast: threshold == 1.0, // Fail test on first test run if threshold is 1.0
5251
SkipTests: skipTests,
53-
RunAllTestPackages: runAllPackages,
5452
SelectedTestPackages: testPackages,
5553
}
5654

tools/flakeguard/runner/runner.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,14 @@ type Runner struct {
2020
UseRace bool // Enable race detector.
2121
FailFast bool // Stop on first test failure.
2222
SkipTests []string // Test names to exclude.
23-
RunAllTestPackages bool // Run all test packages if true.
2423
SelectedTestPackages []string // Explicitly selected packages to run.
2524
}
2625

2726
// RunTests executes the tests for each provided package and aggregates all results.
2827
// It returns all test results and any error encountered during testing.
2928
func (r *Runner) RunTests() ([]reports.TestResult, error) {
3029
var jsonFilePaths []string
31-
packages := r.SelectedTestPackages
32-
if r.RunAllTestPackages {
33-
packages = []string{"./..."}
34-
}
35-
36-
for _, p := range packages {
30+
for _, p := range r.SelectedTestPackages {
3731
for i := 0; i < r.RunCount; i++ {
3832
jsonFilePath, passed, err := r.runTests(p)
3933
if err != nil {

0 commit comments

Comments
 (0)