various lint fixes

Author: skudasov

framework/cmd/blockscout.go

@@ -2,9 +2,10 @@ package main
 
 import (
 	"fmt"
-	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"os"
 	"path/filepath"
+
+	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 )
 
 func blockscoutUp(url string) error {
@@ -35,12 +36,11 @@ func blockscoutDown(url string) error {
 	if err != nil {
 		return err
 	}
-	err = runCommand("bash", "-c", fmt.Sprintf(`
+	return runCommand("bash", "-c", fmt.Sprintf(`
 		cd %s && \
 		rm -rf blockscout-db-data && \
 		rm -rf logs && \
 		rm -rf redis-data && \
 		rm -rf stats-db-data
 	`, filepath.Join("blockscout", "services")))
-	return nil
 }

framework/cmd/ci.go

@@ -178,15 +178,15 @@ func AnalyzeJobsSteps(ctx context.Context, client GitHubActionsClient, cfg *Anal
 						stats.Jobs[name].TotalDuration += dur
 					}
 					if j.RunAttempt != nil && *j.RunAttempt > 1 {
-						stats.Jobs[name].ReRuns += 1
+						stats.Jobs[name].ReRuns++
 					}
 					if j.Conclusion != nil && *j.Conclusion == "failure" {
-						stats.Jobs[name].Failures += 1
+						stats.Jobs[name].Failures++
 					} else {
-						stats.Jobs[name].Successes += 1
+						stats.Jobs[name].Successes++
 					}
 					if j.Conclusion != nil && *j.Conclusion == "cancelled" {
-						stats.Jobs[name].Cancels += 1
+						stats.Jobs[name].Cancels++
 					}
 					// analyze steps
 					for _, s := range j.Steps {
@@ -204,9 +204,9 @@ func AnalyzeJobsSteps(ctx context.Context, client GitHubActionsClient, cfg *Anal
 							stats.Steps[name].Durations = append(stats.Steps[name].Durations, dur)
 						}
 						if *s.Conclusion == "failure" {
-							stats.Steps[name].Failures += 1
+							stats.Steps[name].Failures++
 						} else {
-							stats.Steps[name].Successes += 1
+							stats.Steps[name].Successes++
 						}
 					}
 				}

framework/cmd/docker.go

@@ -2,10 +2,11 @@ package main
 
 import (
 	"fmt"
-	"github.com/rs/zerolog"
-	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"os"
 	"os/exec"
+
+	"github.com/rs/zerolog"
+	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 )
 
 func removeTestContainers() error {

framework/cmd/interactive.go

@@ -2,17 +2,18 @@ package main
 
 import (
 	"fmt"
+	"os"
+	"os/signal"
+	"sync"
+	"syscall"
+
 	"github.com/charmbracelet/huh"
 	"github.com/charmbracelet/huh/spinner"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/clnode"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/postgres"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/simple_node_set"
-	"os"
-	"os/signal"
-	"sync"
-	"syscall"
 )
 
 type nodeSetForm struct {
@@ -114,10 +115,8 @@ func cleanup(form *nodeSetForm) error {
 
 func runSetupForm() error {
 	if !framework.IsDockerRunning() {
-		return fmt.Errorf(`Docker daemon is not running!
-Please set up OrbStack (https://orbstack.dev/)
-or
-Docker Desktop (https://www.docker.com/products/docker-desktop/)
+		//nolint
+		return fmt.Errorf(`docker daemon is not running! Please set up OrbStack (https://orbstack.dev/) or Docker Desktop (https://www.docker.com/products/docker-desktop/)
 `)
 	}
 	f := &nodeSetForm{}

framework/cmd/logs.go

@@ -5,8 +5,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"github.com/pkg/errors"
-	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"io"
 	"net/http"
 	"os"
@@ -15,6 +13,9 @@ import (
 	"sync"
 	"time"
 
+	"github.com/pkg/errors"
+	"github.com/smartcontractkit/chainlink-testing-framework/framework"
+
 	"go.uber.org/ratelimit"
 )
 

framework/cmd/main.go

@@ -3,14 +3,15 @@ package main
 import (
 	"embed"
 	"fmt"
-	"github.com/pelletier/go-toml"
-	"github.com/smartcontractkit/chainlink-testing-framework/framework"
-	"github.com/urfave/cli/v2"
 	"io/fs"
 	"log"
 	"os"
 	"path/filepath"
 	"strings"
+
+	"github.com/pelletier/go-toml"
+	"github.com/smartcontractkit/chainlink-testing-framework/framework"
+	"github.com/urfave/cli/v2"
 )
 
 //go:embed observability/*
@@ -317,6 +318,7 @@ func extractAllFiles(embeddedDir string) error {
 		}
 
 		// Write the file content to the target path
+		//nolint
 		err = os.WriteFile(targetPath, content, 0777)
 		if err != nil {
 			return fmt.Errorf("failed to write file %s: %w", targetPath, err)
@@ -343,6 +345,7 @@ func PrettyPrintTOML(inputFile string, outputFile string) error {
 		return fmt.Errorf("error converting to TOML string: %v", err)
 	}
 
+	//nolint
 	err = os.WriteFile(outputFile, []byte(dumpData), 0644)
 	if err != nil {
 		return fmt.Errorf("error writing to output file: %v", err)

framework/cmd/observability.go

@@ -2,11 +2,12 @@ package main
 
 import (
 	"fmt"
+	"net/http"
+
 	"github.com/google/uuid"
 	"github.com/pkg/errors"
 	"github.com/smartcontractkit/chainlink-testing-framework/framework"
 	"go.uber.org/ratelimit"
-	"net/http"
 )
 
 func loadLogs(rawURL, dirPath string, rps, chunks int) error {
@@ -18,6 +19,7 @@ func loadLogs(rawURL, dirPath string, rps, chunks int) error {
 	limiter := ratelimit.New(rps)
 	if rawURL != "" {
 		L.Info().Msg("Downloading raw logs from URL")
+		//nolint:gosec
 		resp, err := http.Get(rawURL)
 		if err != nil {
 			return errors.Wrap(err, "error downloading raw logs")