Skip to content

Commit df5b037

Browse files
committed
Show "Failed Tests On The First Run" in console
1 parent 97dc520 commit df5b037

File tree

2 files changed

+27
-12
lines changed

2 files changed

+27
-12
lines changed

tools/flakeguard/cmd/run.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,10 @@ var RunTestsCmd = &cobra.Command{
184184
flushSummaryAndExit(0)
185185
}
186186

187+
fmt.Fprint(&summaryBuffer, "\nFailed Tests On The First Run:\n\n")
188+
reports.PrintTestResultsTable(&summaryBuffer, failedTests, false, false, true, false)
189+
fmt.Fprintln(&summaryBuffer)
190+
187191
rerunResults, rerunJsonOutputPaths, err := testRunner.RerunFailedTests(failedTests, rerunFailedCount)
188192
if err != nil {
189193
log.Fatal().Err(err).Msg("Error rerunning failed tests")
@@ -203,8 +207,8 @@ var RunTestsCmd = &cobra.Command{
203207
flushSummaryAndExit(ErrorExitCode)
204208
}
205209

206-
fmt.Fprint(&summaryBuffer, "\nFailed Tests That Were Rerun:\n\n")
207-
reports.PrintTestResultsTable(&summaryBuffer, rerunResults, false, false, true)
210+
fmt.Fprint(&summaryBuffer, "\nFailed Tests After Rerun:\n\n")
211+
reports.PrintTestResultsTable(&summaryBuffer, rerunResults, false, false, true, true)
208212
fmt.Fprintln(&summaryBuffer)
209213

210214
// Save the rerun test report to file

tools/flakeguard/reports/presentation.go

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,18 @@ func generateTestResultsTable(
7878
func generateShortTestResultsTable(
7979
results []TestResult,
8080
markdown bool,
81+
showEverPassed bool,
8182
filter func(TestResult) bool,
8283
) [][]string {
8384
p := message.NewPrinter(language.English)
8485

85-
headers := []string{"Name", "Ever Passed", "Runs", "Successes", "Code Owners", "Path"}
86+
// Build headers dynamically
87+
var headers []string
88+
headers = append(headers, "Name")
89+
if showEverPassed {
90+
headers = append(headers, "Ever Passed")
91+
}
92+
headers = append(headers, "Runs", "Successes", "Code Owners", "Path")
8693

8794
// Optionally format the headers for Markdown
8895
if markdown {
@@ -112,14 +119,17 @@ func generateShortTestResultsTable(
112119
owners = strings.Join(r.CodeOwners, ", ")
113120
}
114121

115-
row := []string{
116-
r.TestName, // "Name"
117-
passed, // "Passed"
118-
p.Sprintf("%d", r.Runs), // "Runs"
119-
p.Sprintf("%d", r.Successes), // "Passes"
120-
owners, // "Code Owners"
121-
r.TestPath, // "Path"
122+
// Build row dynamically
123+
row := []string{r.TestName}
124+
if showEverPassed {
125+
row = append(row, passed)
122126
}
127+
row = append(row,
128+
p.Sprintf("%d", r.Runs),
129+
p.Sprintf("%d", r.Successes),
130+
owners,
131+
r.TestPath,
132+
)
123133

124134
table = append(table, row)
125135
}
@@ -143,13 +153,14 @@ func PrintTestResultsTable(
143153
results []TestResult,
144154
markdown bool,
145155
collapsible bool,
146-
shortTable bool) {
156+
shortTable bool,
157+
showEverPassed bool) {
147158
filter := func(result TestResult) bool {
148159
return true // Include all tests
149160
}
150161
var table [][]string
151162
if shortTable {
152-
table = generateShortTestResultsTable(results, markdown, filter)
163+
table = generateShortTestResultsTable(results, markdown, showEverPassed, filter)
153164
} else {
154165
table = generateTestResultsTable(results, markdown, filter)
155166
}

0 commit comments

Comments
 (0)