Skip to content

Commit dfddee9

Browse files
committed
Merge branch 'TT-1802-FIx-e2e-k8s-tests-in-the-CTF' of https://github.com/smartcontractkit/chainlink-testing-framework into TT-1802-FIx-e2e-k8s-tests-in-the-CTF
2 parents 6115e48 + c48b448 commit dfddee9

File tree

4 files changed

+23
-10
lines changed

4 files changed

+23
-10
lines changed

lib/k8s/environment/environment.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -515,11 +515,13 @@ func (m *Environment) ReplaceHelm(name string, chart ConnectedChart) (*Environme
515515
workloadLabels, err := getComponentLabels(m.Cfg.WorkloadLabels, chart.GetLabels())
516516
if err != nil {
517517
m.err = err
518+
return nil, err
518519
}
519520

520521
podLabels, err := getComponentLabels(m.Cfg.PodLabels, chart.GetLabels())
521522
if err != nil {
522523
m.err = err
524+
return nil, err
523525
}
524526

525527
addRequiredChainLinkLabelsToWorkloads(h, workloadLabels)
@@ -620,7 +622,7 @@ func (m *Environment) UpdateHelm(name string, values map[string]any) (*Environme
620622
return m.ReplaceHelm(name, chart)
621623
}
622624

623-
// AddHelmCharts adds multiple helm charts to the testing environment
625+
// Charts adds multiple helm charts to the testing environment
624626
func (m *Environment) AddHelmCharts(charts []ConnectedChart) *Environment {
625627
if m.err != nil {
626628
return m
@@ -676,11 +678,13 @@ func (m *Environment) AddHelm(chart ConnectedChart) *Environment {
676678
workloadLabels, err := getComponentLabels(m.Cfg.WorkloadLabels, chart.GetLabels())
677679
if err != nil {
678680
m.err = err
681+
return m
679682
}
680683

681684
podLabels, err := getComponentLabels(m.Cfg.PodLabels, chart.GetLabels())
682685
if err != nil {
683686
m.err = err
687+
return m
684688
}
685689
addRequiredChainLinkLabelsToWorkloads(h, workloadLabels)
686690
addDefaultPodAnnotationsAndLabels(h, markNotSafeToEvict(m.Cfg.PreventPodEviction, nil), podLabels)

lib/k8s/pkg/cdk8s/blockscout/blockscout.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ func New(props *Props) func(root cdk8s.Chart) environment.ConnectedChart {
7979
}
8080
vars := vars{
8181
Labels: &map[string]*string{
82-
"app": ptr.Ptr(c.GetName()),
82+
"app": ptr.Ptr(c.GetName()),
83+
"chain.link/component": ptr.Ptr("blockscout"),
8384
},
8485
ConfigMapName: fmt.Sprintf("%s-cm", c.GetName()),
8586
BaseName: c.GetName(),
@@ -117,7 +118,8 @@ type vars struct {
117118
func service(chart cdk8s.Chart, vars vars) {
118119
k8s.NewKubeService(chart, ptr.Ptr(fmt.Sprintf("%s-service", vars.BaseName)), &k8s.KubeServiceProps{
119120
Metadata: &k8s.ObjectMeta{
120-
Name: ptr.Ptr(vars.BaseName),
121+
Name: ptr.Ptr(vars.BaseName),
122+
Labels: vars.Labels,
121123
},
122124
Spec: &k8s.ServiceSpec{
123125
Ports: &[]*k8s.ServicePort{
@@ -173,7 +175,8 @@ func deployment(chart cdk8s.Chart, vars vars) {
173175
ptr.Ptr(fmt.Sprintf("%s-deployment", vars.BaseName)),
174176
&k8s.KubeDeploymentProps{
175177
Metadata: &k8s.ObjectMeta{
176-
Name: ptr.Ptr(vars.BaseName),
178+
Name: ptr.Ptr(vars.BaseName),
179+
Labels: vars.Labels,
177180
},
178181
Spec: &k8s.DeploymentSpec{
179182
Selector: &k8s.LabelSelector{

lib/k8s/pkg/cdk8s/goc/goc.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ func New() func(root cdk8s.Chart) environment.ConnectedChart {
5454
c := &Chart{}
5555
vars := vars{
5656
Labels: &map[string]*string{
57-
"app": ptr.Ptr(c.GetName()),
57+
"app": ptr.Ptr(c.GetName()),
58+
"chain.link/component": ptr.Ptr("goc"),
5859
},
5960
ConfigMapName: fmt.Sprintf("%s-cm", c.GetName()),
6061
BaseName: c.GetName(),
@@ -82,7 +83,8 @@ type vars struct {
8283
func service(chart cdk8s.Chart, vars vars) {
8384
k8s.NewKubeService(chart, ptr.Ptr(fmt.Sprintf("%s-service", vars.BaseName)), &k8s.KubeServiceProps{
8485
Metadata: &k8s.ObjectMeta{
85-
Name: ptr.Ptr(vars.BaseName),
86+
Name: ptr.Ptr(vars.BaseName),
87+
Labels: vars.Labels,
8688
},
8789
Spec: &k8s.ServiceSpec{
8890
Ports: &[]*k8s.ServicePort{
@@ -103,7 +105,8 @@ func deployment(chart cdk8s.Chart, vars vars) {
103105
ptr.Ptr(fmt.Sprintf("%s-deployment", vars.BaseName)),
104106
&k8s.KubeDeploymentProps{
105107
Metadata: &k8s.ObjectMeta{
106-
Name: ptr.Ptr(vars.BaseName),
108+
Name: ptr.Ptr(vars.BaseName),
109+
Labels: vars.Labels,
107110
},
108111
Spec: &k8s.DeploymentSpec{
109112
Selector: &k8s.LabelSelector{

lib/k8s/pkg/cdk8s/http_dummy/dummy.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ func New() func(root cdk8s.Chart) environment.ConnectedChart {
6969
c := &Chart{}
7070
vars := vars{
7171
Labels: &map[string]*string{
72-
"app": ptr.Ptr(c.GetName()),
72+
"app": ptr.Ptr(c.GetName()),
73+
"chain.link/component": ptr.Ptr("http_dummy"),
7374
},
7475
ConfigMapName: fmt.Sprintf("%s-cm", c.GetName()),
7576
BaseName: c.GetName(),
@@ -97,7 +98,8 @@ type vars struct {
9798
func service(chart cdk8s.Chart, vars vars) {
9899
k8s.NewKubeService(chart, ptr.Ptr(fmt.Sprintf("%s-service", vars.BaseName)), &k8s.KubeServiceProps{
99100
Metadata: &k8s.ObjectMeta{
100-
Name: ptr.Ptr(vars.BaseName),
101+
Name: ptr.Ptr(vars.BaseName),
102+
Labels: vars.Labels,
101103
},
102104
Spec: &k8s.ServiceSpec{
103105
Ports: &[]*k8s.ServicePort{
@@ -118,7 +120,8 @@ func deployment(chart cdk8s.Chart, vars vars) {
118120
ptr.Ptr(fmt.Sprintf("%s-deployment", vars.BaseName)),
119121
&k8s.KubeDeploymentProps{
120122
Metadata: &k8s.ObjectMeta{
121-
Name: ptr.Ptr(vars.BaseName),
123+
Name: ptr.Ptr(vars.BaseName),
124+
Labels: vars.Labels,
122125
},
123126
Spec: &k8s.DeploymentSpec{
124127
Selector: &k8s.LabelSelector{

0 commit comments

Comments
 (0)