copilot review

Tofel · Tofel · commit ef27ef06f4f6 · 2025-10-28T17:20:58.000+01:00
diff --git a/framework/components/jd/grpc_wait_strategy.go b/framework/components/jd/grpc_wait_strategy.go
@@ -64,7 +64,7 @@ func (g *GRPCHealthStrategy) WaitUntilReady(ctx context.Context, target tcwait.S
 			}
 
 			// Get host and port
-			host, err := framework.GetHost(target.(tc.Container)) //nolint:contextcheck //don't want modify the signture of GetHost() yet
+			host, err := framework.GetHost(target.(tc.Container)) //nolint:contextcheck //don't want modify the signature of GetHost() yet
 			if err != nil {
 				continue
 			}
@@ -105,7 +105,7 @@ func (g *GRPCHealthStrategy) tryHealthCheck(ctx context.Context, address string,
 	if err != nil {
 		return err
 	}
-	defer conn.Close()
+	defer func() { _ = conn.Close() }()
 
 	// Create health check client
 	healthClient := grpc_health_v1.NewHealthClient(conn)

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func (g *GRPCHealthStrategy) WaitUntilReady(ctx context.Context, target tcwait.S`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`// Get host and port`
`67`		`- host, err := framework.GetHost(target.(tc.Container)) //nolint:contextcheck //don't want modify the signture of GetHost() yet`
	`67`	`+ host, err := framework.GetHost(target.(tc.Container)) //nolint:contextcheck //don't want modify the signature of GetHost() yet`
`68`	`68`	`if err != nil {`
`69`	`69`	`continue`
`70`	`70`	`}`
`@@ -105,7 +105,7 @@ func (g *GRPCHealthStrategy) tryHealthCheck(ctx context.Context, address string,`
`105`	`105`	`if err != nil {`
`106`	`106`	`return err`
`107`	`107`	`}`
`108`		`- defer conn.Close()`
	`108`	`+ defer func() { _ = conn.Close() }()`
`109`	`109`
`110`	`110`	`// Create health check client`
`111`	`111`	`healthClient := grpc_health_v1.NewHealthClient(conn)`