Skip to content

Conversation

@chainchad
Copy link

@chainchad chainchad commented Apr 2, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes streamline the connection configuration for simulated CRIB environments, removing deprecated headers and simplifying the process to connect through GAP or locally. It enhances maintainability and clarity in the codebase by removing unused or unnecessary elements.

What

  • lib/crib/config.go
    • Removed the import statement for net/http as it is no longer necessary.
    • Deleted the HostHeader constant, simplifying the configuration by removing unused headers.
    • In CoreDONConnectionConfig struct, removed fields related to headers (NodeHeaders, BlockchainNodeHeaders, MockserverHeaders) that are no longer needed for establishing connections.
    • Updated CoreDONSimulatedConnection function to:
      • Remove the creation and assignment of node and blockchains headers as these are no longer required.
      • Add conditional logic for connecting to CRIB using GAP based on an environment variable, making the GAP connection process more explicit and configurable.
      • Simplify the local connection setup by directly assigning URLs without unnecessary headers, improving the readability and maintainability of the connection setup process.

@chainchad
Copy link
Author

Looks like the CRIB connector is legacy/deprecated.

@chainchad chainchad closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant