Some offchain TODO cleanup (#330)

Author: ogtownsend

pkg/ccip/provider/provider.go

@@ -47,9 +47,6 @@ func NewCCIPProvider(
 	logPoller logpoller.Service,
 	cargs commontypes.CCIPProviderArgs,
 ) (*Provider, error) {
-	// TODO: clean up, too verbose
-	lggr.Info("Creating TON CCIPProvider", "chainSelector", chainSelector, "pluginType", cargs.PluginType, "offRampAddress", cargs.OffRampAddress)
-
 	// Validate offramp address
 	addressCodec := codec.NewAddressCodec()
 	var offRampAddrStr string
@@ -64,9 +61,8 @@ func NewCCIPProvider(
 			return nil, fmt.Errorf("failed to decode TON offRamp address: %w", err)
 		}
 	} else {
-		// TODO: clean up, too verbose
 		// EVM address provided - use zero address as placeholder
-		lggr.Warnw("EVM offramp address provided to TON provider, using zero address placeholder",
+		lggr.Debug("EVM offramp address provided to TON provider, using zero address placeholder",
 			"providedLength", len(cargs.OffRampAddress),
 			"expectedLength", tvm.AddressLength)
 		// Use a zero TON address as placeholder
@@ -103,6 +99,9 @@ func NewCCIPProvider(
 		return nil, fmt.Errorf("failed to create TON Accessor: %w", err)
 	}
 
+	lggr.Info("Returning TON CCIPProvider", "chainSelector", chainSelector, "pluginType", cargs.PluginType,
+		"cargs.offRampAddress", cargs.OffRampAddress, "offRampAddrStr", offRampAddrStr)
+
 	return &Provider{
 		lggr:  logger.Named(lggr, CCIPProviderName),
 		ct:    ct,

pkg/client/client.go

@@ -5,5 +5,4 @@ import "context"
 type Estimator interface {
 	Start(context.Context) error
 	Close() error
-	// TODO(NONEVM-1460): add remaining interface functions required for fee calculation
 }

pkg/client/multi_client.go

@@ -247,7 +247,6 @@ func (c *chain) ListNodeStatuses(ctx context.Context, pageSize int32, pageToken
 }
 
 func (c *chain) Transact(ctx context.Context, from, to string, amount *big.Int, balanceCheck bool) error {
-	// TODO(NONEVM-1460): implement
 	return errors.ErrUnsupported
 }
 

pkg/fees/estimator.go

@@ -93,7 +93,7 @@ func (s *TxStore) GetUnconfirmed() []*UnconfirmedTx {
 
 	unconfirmed := maps.Values(s.unconfirmedTxs)
 
-	// TODO: should this be sorted by LT instead?
+	// TODO: consider sorting by LT instead
 	sort.Slice(unconfirmed, func(i, j int) bool {
 		return unconfirmed[i].ExpirationMs < unconfirmed[j].ExpirationMs
 	})