[NONEVM-3352] [L4] Wrong or colliding error codes (#507)

* ref: facility name, id and error codes

* feat: normalize exit codes for ownable and merkle multi proof

* feat: normalize exit codes for ocr

* fix: remove redundant errors

* small fixes

* ref: align opcodes in Utils

Author: patricios-space

contracts/contracts/ccip/ccipsend_executor/contract.tolk

@@ -11,7 +11,6 @@ import "../fee_quoter/types"
 import "@stdlib/gas-payments"
 
 const CONTRACT_VERSION = "1.6.0";
-const FACILITY_NAME = "com.chainlink.ton.ccip.CCIPSendExecutor";
 
 fun onInternalMessage(in: InMessage) {
     val msg = lazy CCIPSendExecutor_InMessage.fromSlice(in.body);
@@ -153,11 +152,11 @@ fun CCIPSendExecutor<T>.exitWithError(self, error: uint256) {
 }
 
 get fun typeAndVersion(): (slice, slice) {
-    return ("com.chainlink.ton.ccip.CCIPSendExecutor", CONTRACT_VERSION);
+    return (CCIPSendExecutor_FACILITY_NAME, CONTRACT_VERSION);
 }
 
 get fun facilityId(): uint16  {
-    return getFacilityId(stringCrc32("com.chainlink.ton.ccip.CCIPSendExecutor"));
+    return CCIPSendExecutor_FACILITY_ID;
 }
 
 get fun errorCode(local: uint16): uint16 {

contracts/contracts/ccip/ccipsend_executor/errors.tolk

@@ -1,5 +1,7 @@
+import "types"
+
 enum CCIPSendExecutor_Error {
-    StateNotExpected = 43600 // Facility ID * 100
+    StateNotExpected = CCIPSendExecutor_FACILITY_ID * 100
     Unauthorized
     InsufficientFunds
     InsufficientFee

contracts/contracts/ccip/ccipsend_executor/types.tolk

@@ -1,6 +1,8 @@
 import "../onramp/messages.tolk";
-import "../../deployable/types"
-import "../../lib/deployable/namespace"
+
+const CCIPSendExecutor_FACILITY_NAME = "com.chainlink.ton.ccip.CCIPSendExecutor";
+// getFacilityId(stringCrc32(CCIPSendExecutor_FACILITY_NAME));
+const CCIPSendExecutor_FACILITY_ID = 436;
 
 type CCIPSendExecutor_ID = uint224
 

contracts/contracts/ccip/fee_quoter/contract.tolk

@@ -16,7 +16,6 @@ import "../../lib/funding/withdrawable"
 import "../../lib/versioning/upgradeable"
 
 const CONTRACT_VERSION = "1.6.0";
-const FACILITY_NAME = "com.chainlink.ton.ccip.FeeQuoter";
 const RESERVE = ton("1"); // TODO: set correct value
 
 fun onInternalMessage(in: InMessage) {
@@ -252,7 +251,7 @@ fun calculateValidatedFee(msg: Router_CCIPSend): Fee {
         8 => {
             throw FeeQuoter_Error.MsgDataTooLarge;
         }
-        ERROR_INVALID_DATA => {
+        Utils_Error.InvalidData as int => {
             throw FeeQuoter_Error.InvalidMsgData;
         }
         else => {
@@ -644,11 +643,11 @@ get fun pendingOwner(): address? {
 }
 
 get fun typeAndVersion(): (slice, slice) {
-    return ("com.chainlink.ton.ccip.FeeQuoter", CONTRACT_VERSION);
+    return (FeeQuoter_FACILITY_NAME, CONTRACT_VERSION);
 }
 
 get fun facilityId(): uint16  {
-    return getFacilityId(stringCrc32("com.chainlink.ton.ccip.FeeQuoter"));
+    return FeeQuoter_FACILITY_ID;
 }
 
 get fun errorCode(local: uint16): uint16 {

contracts/contracts/ccip/fee_quoter/errors.tolk

@@ -1,5 +1,7 @@
+import "types"
+
 enum FeeQuoter_Error {
-    UnsupportedChainFamilySelector = 24800 // Facility ID * 100
+    UnsupportedChainFamilySelector = FeeQuoter_FACILITY_ID * 100
     GasLimitTooHigh
     ExtraArgOutOfOrderExecutionMustBeTrue
     InvalidExtraArgsData

contracts/contracts/ccip/fee_quoter/types.tolk

@@ -1,5 +1,9 @@
 import "../../lib/utils"
 
+const FeeQuoter_FACILITY_NAME = "com.chainlink.ton.ccip.FeeQuoter";
+// getFacilityId(stringCrc32(FeeQuoter_FACILITY_NAME));
+const FeeQuoter_FACILITY_ID = 248;
+
 struct TimestampedPrice {
     value: uint224;
     timestamp: uint32;

contracts/contracts/ccip/merkle_root/contract.tolk

@@ -8,6 +8,7 @@ import "../../deployable/types.tolk"
 import "../receive_executor/storage"
 import "../router/storage"
 import "../../lib/funding/withdrawable"
+import "types"
 
 // MerkleRoot contract
 // Root is commited on Commit Reports and the existence of this contract is used to validate Execute Reports
@@ -108,11 +109,11 @@ fun onInitExecute(mutate st: MerkleRoot_Storage, msg: MerkleRoot_Validate) {
 }
 
 get fun typeAndVersion(): (slice, slice) {
-    return ("com.chainlink.ton.ccip.MerkleRoot", CONTRACT_VERSION);
+    return (MerkleRoot_FACILITY_NAME, CONTRACT_VERSION);
 }
 
 get fun facilityId(): uint16  {
-    return getFacilityId(stringCrc32("com.chainlink.ton.ccip.MerkleRoot"));
+    return MerkleRoot_FACILITY_ID;
 }
 
 get fun errorCode(local: uint16): uint16 {

contracts/contracts/ccip/merkle_root/errors.tolk

@@ -1,5 +1,7 @@
+import "types"
+
 enum MerkleRoot_Error {
-    AlreadyExecuted = 47900 // Facility ID * 100
+    AlreadyExecuted = MerkleRoot_FACILITY_ID * 100
     NotOwner
     ManualExecutionNotYetEnabled
     SkippedAlreadyExecutedMessage

contracts/contracts/ccip/merkle_root/types.tolk

@@ -0,0 +1,3 @@
+const MerkleRoot_FACILITY_NAME = "com.chainlink.ton.ccip.MerkleRoot";
+// getFacilityId(stringCrc32(MerkleRoot_FACILITY_NAME));
+const MerkleRoot_FACILITY_ID = 479;

contracts/contracts/ccip/offramp/contract.tolk

@@ -863,11 +863,11 @@ get fun pendingOwner(): address? {
 }
 
 get fun typeAndVersion(): (slice, slice) {
-    return ("com.chainlink.ton.ccip.OffRamp", CONTRACT_VERSION);
+    return (OffRamp_FACILITY_NAME, CONTRACT_VERSION);
 }
 
 get fun facilityId(): uint16  {
-    return getFacilityId(stringCrc32("com.chainlink.ton.ccip.OffRamp"));
+    return OffRamp_FACILITY_ID;
 }
 
 get fun errorCode(local: uint16): uint16 {