NONEVM-3305: logpoller BatchInsertSize default config (#468)

* fix: log BatchInsertSize default config

* fix: test

* chore: typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: jadepark-dev

pkg/logpoller/config.go

@@ -29,18 +29,13 @@ var DefaultConfigSet = Config{
 	LogPollerStartingLookback: config.MustNewDuration(24 * time.Hour),          // Look back 24 hours on startup
 	BlockTime:                 config.MustNewDuration(2500 * time.Millisecond), // TON block time is approximately 2.5 seconds
 
-	// fixed-sized fields in models.Log: ~342 bytes + Data field(BOC cell)
-	// ccip message conservative e.g. 1500 bytes -> ~1842 bytes per log
-	// SaveThreshold:   8000, // ~14.7MB
-
-	// fixed-sized fields in postgres models.Log: ~474 bytes + Data field(BOC cell)
-	// ccip message conservative e.g. 1500 bytes -> ~1974 bytes per log
-	// BatchInsertSize: 4000, // ~7.9MB
-
-	// database configuration,
-	BatchInsertSize: 4000, // PostgreSQL batch insert size
+	// memory estimation per log:
+	// - in-memory models.Log: ~342 bytes + Data field (BOC cell) ≈ 1842 bytes
+	// - postgres models.Log:  ~474 bytes + Data field (BOC cell) ≈ 1974 bytes
+	// SaveThreshold 7000 ≈ 12.9MB, BatchInsertSize 3500 ≈ 6.9MB
+	BatchInsertSize: 3500, // postgresql batch insert size
 	MinBatchSize:    500,  // Minimum batch size for timeout retry
-	SaveThreshold:   8000, // Memory buffer size before batch saving
+	SaveThreshold:   7000, // Memory buffer size before batch saving
 }
 
 func (c *Config) ApplyDefaults() {
@@ -74,6 +69,10 @@ func (c *Config) ValidateConfig() (err error) {
 	if c.BatchInsertSize == 0 {
 		return errors.New("batch_insert_size must be greater than 0")
 	}
+	// postgresql wire protocol limit: 65,535 params / 17 params per row ≈ 3,855 max rows
+	if c.BatchInsertSize > 3800 {
+		return fmt.Errorf("batch_insert_size (%d) exceeds postgresql parameter limit (max 3800 rows)", c.BatchInsertSize)
+	}
 	if c.MinBatchSize == 0 {
 		return errors.New("min_batch_size must be greater than 0")
 	}

pkg/logpoller/config_test.go

@@ -75,9 +75,9 @@ func TestConfig_ValidateConfig(t *testing.T) {
 	t.Run("valid config passes validation", func(t *testing.T) {
 		cfg := &Config{
 			PageSize:        100,
-			BatchInsertSize: 4000,
+			BatchInsertSize: 3500,
 			MinBatchSize:    500,
-			SaveThreshold:   8000,
+			SaveThreshold:   7000,
 		}
 		err := cfg.ValidateConfig()
 		require.NoError(t, err)
@@ -92,9 +92,9 @@ func TestConfig_ValidateConfig(t *testing.T) {
 	t.Run("fails when PageSize is zero", func(t *testing.T) {
 		cfg := &Config{
 			PageSize:        0,
-			BatchInsertSize: 4000,
+			BatchInsertSize: 3500,
 			MinBatchSize:    500,
-			SaveThreshold:   8000,
+			SaveThreshold:   7000,
 		}
 		err := cfg.ValidateConfig()
 		require.Error(t, err)
@@ -106,19 +106,30 @@ func TestConfig_ValidateConfig(t *testing.T) {
 			PageSize:        100,
 			BatchInsertSize: 0,
 			MinBatchSize:    500,
-			SaveThreshold:   8000,
+			SaveThreshold:   7000,
 		}
 		err := cfg.ValidateConfig()
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "batch_insert_size")
 	})
 
-	t.Run("fails when MinBatchSize is zero", func(t *testing.T) {
+	t.Run("fails when BatchInsertSize exceeds PostgreSQL parameter limit", func(t *testing.T) {
 		cfg := &Config{
 			PageSize:        100,
 			BatchInsertSize: 4000,
+			MinBatchSize:    500,
+			SaveThreshold:   7000,
+		}
+		err := cfg.ValidateConfig()
+		require.Error(t, err)
+	})
+
+	t.Run("fails when MinBatchSize is zero", func(t *testing.T) {
+		cfg := &Config{
+			PageSize:        100,
+			BatchInsertSize: 3500,
 			MinBatchSize:    0,
-			SaveThreshold:   8000,
+			SaveThreshold:   7000,
 		}
 		err := cfg.ValidateConfig()
 		require.Error(t, err)
@@ -128,7 +139,7 @@ func TestConfig_ValidateConfig(t *testing.T) {
 	t.Run("fails when SaveThreshold is zero", func(t *testing.T) {
 		cfg := &Config{
 			PageSize:        100,
-			BatchInsertSize: 4000,
+			BatchInsertSize: 3500,
 			MinBatchSize:    500,
 			SaveThreshold:   0,
 		}
@@ -142,7 +153,7 @@ func TestConfig_ValidateConfig(t *testing.T) {
 			PageSize:        100,
 			BatchInsertSize: 500,
 			MinBatchSize:    1000,
-			SaveThreshold:   8000,
+			SaveThreshold:   7000,
 		}
 		err := cfg.ValidateConfig()
 		require.Error(t, err)