remove dead code

Author: Tofel

system-tests/tests/regression/cre/v2_cron_beholder_regression_test.go

@@ -44,7 +44,6 @@ func CronBeholderFailsWithInvalidScheduleTest(t *testing.T, testEnv *ttypes.Test
 
 	testLogger.Warn().Msgf("Expecting Cron workflow to fail with invalid schedule: %s", invalidSchedule)
 	expectedBeholderLog := "beholder found engine initialization failure message!"
-
 	timeout := 75 * time.Second
 	expectedError := t_helpers.AssertBeholderMessage(listenerCtx, t, expectedBeholderLog, testLogger, messageChan, kafkaErrChan, timeout)
 	require.Error(t, expectedError, "Cron (Beholder) test failed. This test expects to fail with an error, but did not.")

system-tests/tests/test-helpers/chip_testsink_helpers.go

@@ -117,7 +117,7 @@ func collectChannels(args ...any) []reflect.Value {
 				}
 			}
 		default:
-			framework.L.Warn().Msgf("unsupported arg to ShutdownChipSinkWithDrainAndClose: %T", arg)
+			framework.L.Warn().Msgf("unsupported arg to ShutdownChipSinkWithDrain: %T", arg)
 		}
 	}
 	return channels
@@ -127,6 +127,7 @@ func collectChannels(args ...any) []reflect.Value {
 func startReflectChannelDrainers(channels []reflect.Value) func() {
 	ctx, cancel := context.WithCancel(context.Background())
 	var wg sync.WaitGroup
+	doneCh := reflect.ValueOf(ctx.Done())
 
 	for _, ch := range channels {
 		if !ch.IsValid() || ch.Kind() != reflect.Chan || ch.IsNil() {
@@ -136,15 +137,15 @@ func startReflectChannelDrainers(channels []reflect.Value) func() {
 		wg.Add(1)
 		go func(ch reflect.Value) {
 			defer wg.Done()
+			cases := []reflect.SelectCase{
+				{Dir: reflect.SelectRecv, Chan: ch},
+				{Dir: reflect.SelectRecv, Chan: doneCh},
+			}
 			for {
-				select {
-				case <-ctx.Done():
+				chosen, _, ok := reflect.Select(cases)
+				if chosen == 1 {
 					return
-				default:
 				}
-
-				// Recv blocks until an element is available or the channel closes.
-				_, ok := ch.Recv()
 				if !ok {
 					return
 				}