Skip to content

Commit 48a6ec3

Browse files
authored
Fix test compilation for por-address-list (#3814)
* Fix test compilation for por-address-list * ESNext
1 parent 6b11b60 commit 48a6ec3

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

.github/workflows/checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
- name: Compile tests
7474
env:
7575
CHANGED_PACKAGES: ${{ needs.install-packages.outputs.changed-packages }}
76-
FAILING_TESTS_PATTERN: '/composites/dydx-rewards/|/composites/glv-token/|/composites/gm-token/|/core/bootstrap/|/sources/bitgo-reserves-test/|/sources/bitgo-reserves/|/sources/coinpaprika/|/sources/cryptocompare/|/sources/icap/|/sources/ipfs/|/sources/layer2-sequencer-health/|/sources/por-address-list/|/sources/s3-csv-reader/|/sources/view-function-multi-chain/|sources/view-function/|/k6/|/observation/'
76+
FAILING_TESTS_PATTERN: '/composites/dydx-rewards/|/composites/glv-token/|/composites/gm-token/|/core/bootstrap/|/sources/bitgo-reserves-test/|/sources/bitgo-reserves/|/sources/coinpaprika/|/sources/cryptocompare/|/sources/icap/|/sources/ipfs/|/sources/layer2-sequencer-health/|/sources/s3-csv-reader/|/sources/view-function-multi-chain/|sources/view-function/|/k6/|/observation/'
7777
run: |
7878
echo "Tests that should compile:"
7979
for package in $(echo "$CHANGED_PACKAGES" | jq '.[].location + "/"' -r | grep -v -E "$FAILING_TESTS_PATTERN"); do

packages/sources/por-address-list/test/integration/fixtures-api.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
import nock from 'nock'
22

3+
type JsonRpcPayload = {
4+
id: number
5+
method: string
6+
params: Array<{ to: string; data: string }>
7+
}
8+
39
export const mockCoinbaseResponseSuccess = (): nock.Scope =>
410
nock('http://coinbase', {
511
encodedQueryParams: true,
@@ -199,7 +205,7 @@ export const mockBaseContractCallResponseSuccess = (): nock.Scope =>
199205
nock('http://localhost-base:8080')
200206
.persist()
201207
.post('/')
202-
.reply(200, (uri, request) => {
208+
.reply(200, (_uri, request: JsonRpcPayload) => {
203209
if (request.method === 'eth_chainId') {
204210
return {
205211
jsonrpc: '2.0',

packages/sources/por-address-list/tsconfig.test.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"extends": "../../tsconfig.base.json",
33
"include": ["src/**/*", "**/test", "src/**/*.json"],
44
"compilerOptions": {
5+
"target": "ESNext",
56
"noEmit": true
67
}
78
}

0 commit comments

Comments
 (0)