Fix message format bug in finage (#4396)

Co-authored-by: app-token-issuer-data-feeds[bot] <134377064+app-token-issuer-data-feeds[bot]@users.noreply.github.com>

Author: mxiao-cll

.changeset/real-tigers-hammer.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/finage-adapter': minor
+---
+
+Fix a message format bug

packages/sources/finage/src/transport/stock-quotes.ts

@@ -6,12 +6,12 @@ const logger = makeLogger('StockQuotes')
 
 export interface StockQuoteMessage {
   s: string // Symbol
-  a: string // ask_price
-  ap: string // ask_price fallback
-  as: string // ask_volume
-  b: string // bid_price
-  bp: string // bid_price fallback
-  bs: string // bid_volume
+  a: string | number // ask_price
+  ap: string | number // ask_price fallback
+  as: string | number // ask_volume
+  b: string | number // bid_price
+  bp: string | number // bid_price fallback
+  bs: string | number // bid_volume
   t: number // providerIndicatedTime
   status_code: number
   message: string
@@ -23,7 +23,7 @@ type WsTransportTypes = BaseEndpointTypes & {
   }
 }
 
-const isValidNumber = (field: string) => field && field.length > 0 && !isNaN(Number(field))
+const isValidNumber = (field: string | number) => field != null && !isNaN(Number(field))
 
 export const transport = new WebSocketTransport<WsTransportTypes>({
   url: (context) => {

packages/sources/finage/test/integration/__snapshots__/adapter-stock-quote.test.ts.snap

@@ -75,3 +75,22 @@ exports[`stock quotes websocket stock quotes endpoint should return success 1`]
   },
 }
 `;
+
+exports[`stock quotes websocket stock quotes endpoint should return success for number messages 1`] = `
+{
+  "data": {
+    "ask_price": 5,
+    "ask_volume": 6,
+    "bid_price": 7,
+    "bid_volume": 8,
+    "mid_price": 6,
+  },
+  "result": null,
+  "statusCode": 200,
+  "timestamps": {
+    "providerDataReceivedUnixMs": 1018,
+    "providerDataStreamEstablishedUnixMs": 1010,
+    "providerIndicatedTimeUnixMs": 9,
+  },
+}
+`;

packages/sources/finage/test/integration/adapter-stock-quote.test.ts

@@ -17,6 +17,10 @@ describe('stock quotes websocket', () => {
     endpoint: 'stock_quotes',
     base: 'AAPL',
   }
+  const dataNumber = {
+    endpoint: 'stock_quotes',
+    base: 'AAPL_NUMBER',
+  }
   const fallBackData = {
     endpoint: 'stock_quotes',
     base: 'FALLBACK',
@@ -40,8 +44,9 @@ describe('stock quotes websocket', () => {
 
     // Send initial request to start background execute and wait for cache to be filled with results
     await testAdapter.request(data)
+    await testAdapter.request(dataNumber)
     await testAdapter.request(fallBackData)
-    await testAdapter.waitForCache(4)
+    await testAdapter.waitForCache(5)
   })
 
   afterAll(async () => {
@@ -57,6 +62,11 @@ describe('stock quotes websocket', () => {
       expect(response.json()).toMatchSnapshot()
     })
 
+    it('should return success for number messages', async () => {
+      const response = await testAdapter.request(dataNumber)
+      expect(response.json()).toMatchSnapshot()
+    })
+
     it('missing a and b fields should fallback', async () => {
       const response = await testAdapter.request(fallBackData)
       expect(response.json()).toMatchSnapshot()

packages/sources/finage/test/integration/fixtures.ts

@@ -248,6 +248,14 @@ export const mockStockQuotesWebSocketServer = (URL: string): MockWebsocketServer
       bs: '8',
       t: 9,
     },
+    {
+      s: 'AAPL_NUMBER',
+      a: 5,
+      as: 6,
+      b: 7,
+      bs: 8,
+      t: 9,
+    },
     {
       s: 'FALLBACK',
       ap: '10',