Fix recently introduced test compilation issues (#3787)

Author: dskloetc

.github/workflows/checks.yml

@@ -73,7 +73,7 @@ jobs:
       - name: Compile tests
         env:
           CHANGED_PACKAGES: ${{ needs.install-packages.outputs.changed-packages }}
-          FAILING_TESTS_PATTERN: '/composites/dydx-rewards/|/composites/glv-token/|/composites/gm-token/|/core/bootstrap/|/sources/aleno/|/sources/bitgo-reserves-test/|/sources/bitgo-reserves/|/sources/coinpaprika/|/sources/cryptocompare/|/sources/dlc-btc-por/|/sources/eth-beacon/|/sources/icap/|/sources/ipfs/|/sources/layer2-sequencer-health/|/sources/por-address-list/|/sources/s3-csv-reader/|/sources/token-balance/|/sources/view-function-multi-chain/|sources/view-function/'
+          FAILING_TESTS_PATTERN: '/composites/dydx-rewards/|/composites/glv-token/|/composites/gm-token/|/core/bootstrap/|/sources/aleno/|/sources/bitgo-reserves-test/|/sources/bitgo-reserves/|/sources/coinpaprika/|/sources/cryptocompare/|/sources/icap/|/sources/ipfs/|/sources/layer2-sequencer-health/|/sources/por-address-list/|/sources/s3-csv-reader/|/sources/token-balance/|/sources/view-function-multi-chain/|sources/view-function/'
         run: |
           # Tests that should compile:
           yarn tsc -b --noEmit $(echo $CHANGED_PACKAGES | jq '.[].location + "/tsconfig.test.json"' -r | grep -v -E "$FAILING_TESTS_PATTERN")

packages/sources/dlc-btc-por/test/integration/fixtures.ts

@@ -8,8 +8,8 @@ type DeferredRequest = {
 }
 
 export const mockBitcoinRPCResponseSuccessForTxId = (txid: string): DeferredRequest => {
-  const [waitBeforeResolving, resolve] = deferredPromise()
-  const [hasHappenedPromise, resolveHasHappened] = deferredPromise()
+  const [waitBeforeResolving, resolve] = deferredPromise<void>()
+  const [hasHappenedPromise, resolveHasHappened] = deferredPromise<void>()
   const request = {
     hasHappened: false,
     hasHappenedPromise,

packages/sources/eth-beacon/test/integration/fixtures.ts

@@ -1,3 +1,4 @@
+import { deferredPromise } from '@chainlink/external-adapter-framework/util'
 import nock from 'nock'
 
 export const mockBalanceSuccess = (): nock.Scope =>
@@ -200,22 +201,21 @@ export const mockBalanceLimboValidator = (): void => {
     .persist()
 }
 
+type DeferredRequest = {
+  hasHappened: boolean
+  resolve: () => void
+}
+
 // Mocks responses for the given addresses, batched into batches of 3.
 // Returns an array of request objects which can be used to check if the
 // request has happened and to resolve the request.
-export const mockBalanceBatchedAddresses = (addresses: string[]): void => {
+export const mockBalanceBatchedAddresses = (addresses: string[]): DeferredRequest[] => {
   const batchSize = 3
-  const requests: {
-    hasHappened: boolean
-    resolve: () => void
-  }[] = []
+  const requests: DeferredRequest[] = []
 
-  const mockAddresses = (startIndex, endIndex) => {
+  const mockAddresses = (startIndex: number, endIndex: number) => {
     const addressesToMock = addresses.slice(startIndex, endIndex)
-    let resolve
-    const waitBeforeResolving = new Promise((r) => {
-      resolve = r
-    })
+    const [waitBeforeResolving, resolve] = deferredPromise<void>()
     const request = {
       hasHappened: false,
       resolve,

packages/sources/por-address-list/test/unit/utils.test.ts

@@ -165,7 +165,7 @@ describe('address endpoint', () => {
         new ethers.providers.JsonRpcProvider(),
       )
 
-      const resolvers = []
+      const resolvers: (() => void)[] = []
       const getAddressesDelayed = (startIdx: ethers.BigNumber, endIdx: ethers.BigNumber) => {
         const answer = getAddresses(startIdx, endIdx)
         return new Promise((resolve) => {