removed the listener memory leak (#4324)

Author: guandali

.changeset/gentle-fishes-crash.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/blocksize-capital-state-adapter': patch
+---
+
+update tbe remove listener logic

.pnp.cjs

@@ -36,7 +36,7 @@
     "typescript": "5.8.3"
   },
   "dependencies": {
-    "@chainlink/external-adapter-framework": "2.8.0",
+    "@chainlink/external-adapter-framework": "2.11.1",
     "tslib": "2.4.1"
   }
 }

packages/sources/blocksize-capital-state/package.json

@@ -79,20 +79,24 @@ function authMessageHandler(
   reject: (error: Error) => void,
   timeoutId: NodeJS.Timeout,
   connection: WebSocket,
+  messageHandler: (event: MessageEvent) => void,
 ) {
   try {
     const parsed = JSON.parse(event.data.toString())
+
+    // Successful authentication
     if (parsed.result?.user_id && !parsed.error) {
       logger.debug('Got logged in response, connection is ready')
       clearTimeout(timeoutId)
-      connection.removeEventListener('message', authMessageHandler)
+      connection.removeEventListener('message', messageHandler)
       resolve()
       return
     }
 
+    // Authentication error
     if (parsed.error) {
       clearTimeout(timeoutId)
-      connection.removeEventListener('message', authMessageHandler)
+      connection.removeEventListener('message', messageHandler)
 
       if (parsed.error.code === 4001) {
         // Invalid API key
@@ -107,14 +111,18 @@ function authMessageHandler(
           2. Contact Blocksize Capital billing support
           3. Verify your payment method is up to date`)
       } else {
-        logger.warn(`Authentication error: ${parsed.error.message}`)
+        logger.warn(`Authentication error: ${parsed.error.message} (code: ${parsed.error.code})`)
       }
 
       reject(new Error(`Failed to make WS connection: ${JSON.stringify(parsed)}`))
+      return
     }
+
+    // If we reach here, the message was not an auth response (could be a different message type)
+    // We continue waiting for the actual auth response
   } catch (error) {
     clearTimeout(timeoutId)
-    connection.removeEventListener('message', authMessageHandler)
+    connection.removeEventListener('message', messageHandler)
     const errorMessage = error instanceof Error ? error.message : String(error)
     reject(new Error(`Failed to parse authentication response: ${errorMessage}`))
   }
@@ -131,7 +139,7 @@ export const blocksizeStateWebsocketOpenHandler = (
     }, 10000)
 
     const messageHandler = (event: MessageEvent) => {
-      authMessageHandler(event, resolve, reject, timeoutId, connection)
+      authMessageHandler(event, resolve, reject, timeoutId, connection, messageHandler)
     }
 
     connection.addEventListener('message', messageHandler)

packages/sources/blocksize-capital-state/src/transport/utils.ts

@@ -2869,7 +2869,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@chainlink/blocksize-capital-state-adapter@workspace:packages/sources/blocksize-capital-state"
   dependencies:
-    "@chainlink/external-adapter-framework": "npm:2.8.0"
+    "@chainlink/external-adapter-framework": "npm:2.11.1"
     "@sinonjs/fake-timers": "npm:9.1.2"
     "@types/jest": "npm:^29.5.14"
     "@types/node": "npm:22.14.1"