Lesson 10: mockOffchain.js returning UpKeep not needed

[rpranayr]

Hi all,
I am stuck when I am trying to get a winner using the mockOffChain script. Things I have already done before running yarn run scripts/mockOffChain.js --network localhost :

• Started a hardhat node in separate terminal.
• Added localhost in config file.
• Entered into the raffle by using 2 different accounts from hardhat node accounts list using the frontend

Attaching my mockOffChain script below:

const { providers } = require("ethers")
const { ethers, network } = require("hardhat")

async function mockKeepers() {
  const raffle = await ethers.getContract("Raffle")
  const checkData = ethers.utils.keccak256(ethers.utils.toUtf8Bytes(""))
  const { upkeepNeeded } = await raffle.callStatic.checkUpkeep(checkData)

  const raffleState = await raffle.getRaffleState()
  console.log(raffleState)
  // isopen

  const numPlayers = await raffle.getNumberofPlayers()
  console.log(`No. of players: ${numPlayers.toString()}`)
  // has players

  const balance = await ethers.provider.getBalance(raffle.address)
  console.log(`Contract Balance : ${ethers.utils.formatEther(balance.toString())} ETH`)
  // has contract balance

//   const timestamp = await raffle.getLatestTimeStamp()
//   console.log(timestamp.toString())

//   const interval = await raffle.getInterval()
//   console.log(interval.toString())

    console.log(network.config.chainId)

  if (upkeepNeeded) {
    const tx = await raffle.performUpkeep(checkData)
    const txReceipt = await tx.wait(1)
    const requestId = txReceipt.events[1].args.requestId
    console.log(`Performed upkeep with RequestId: ${requestId}`)

    if (network.config.chainId == 31337) {
      await mockVrf(requestId, raffle)
    }
  } else {
    console.log("No upkeep needed!")
  }
}

async function mockVrf(requestId, raffle) {
  console.log("We on a local network? Ok let's pretend...")
  const vrfCoordinatorV2Mock = await ethers.getContract("VRFCoordinatorV2Mock")
  await vrfCoordinatorV2Mock.fulfillRandomWords(requestId, raffle.address)
  console.log("Responded!")
  const recentWinner = await raffle.getRecentWinner()
  console.log(`The winner is: ${recentWinner}`)
}

mockKeepers()
  .then(() => process.exit(0))
  .catch((error) => {
    console.error(error)
    process.exit(1)
  })

Doing the checks I see that raffle is in open state, has players and has balance as well but when I print the upKeepNeeded value instead of false it is saying undefined. I have attached the github repo links in a comment if needed. Can someone please help me on how to fix this? Thanks in advance 🙏

[krakxn]

Push to GitHub; I will look into it.

[mmuaaz]

I am also facing this error, I think he made some changes of what he thinks might be the problem, but I have seen Patrick doing no change to the code and still able to return winner,
even if there were changes to be made then a "getSigners" should have been imported and "for "loop should be used with which like multiple accounts should have called enterRaffle function

[rpranayr]

Hi @krakxn , Here is the link to the mockOffChain script from the hardhat lottery lesson and here is the link to the Lottery Entrance Component from nextjs lottery lesson.

[rpranayr]

I am also facing this error, I think he made some changes of what he thinks might be the problem, but I have seen Patrick doing no change to the code and still able to return winner, even if there were changes to be made then a "getSigners" should have been imported and "for "loop should be used with which like multiple accounts should have called enterRaffle function

Hi, I actually entered the raffle using the front-end via 3 seperate accounts. There was no issue in the enter raffle phase at all.

[rpranayr]

Hi all, a update on this. Using the getLatestTimeStamp() function from the contract I compared the timeStamp values from before entering the raffle and then the timestamp after entering a raffle from front-end and they are exactly the same. I think because the timestamp isn't increasing even though a block is getting mined is the reason why timePassed flag is not turning true. Do I have to add in an evm_increaseTime / evm_mine like we did in the tests?

[mmuaaz]

in another thread, I dont remember the reference, but the similar error was posted, a dude ABossOfMyself answered him by saying run

enter.js
first and then we will be able to enter, I tried that as well, but then I am encountering another error of low balance or something.

[RoboCrypter]

@mmuaaz : Yes! I did, But in this case, He is already entering the lottery through frontend!

[mmuaaz]

ok so I did enter through front-end as well, dont know why I am getting this error, could you please take a look I am attaching the link to my repo; https://github.com/mmuaaz/NextJS-frontend-Lottery.sol-SolidityCourse

I had moved ahead in the course despite getting that error so the code is updated, but the "recentWinner" didnt work for me

[rpranayr]

@PatrickAlphaC Hi Patrick. So sorry to tag you here but I am stuck here. I have tried troubleshooting and trying the diff solutions for the same issue but none of them are working. If you have some free time could you please have a look? Thank you in advance 😇

[rpranayr]

Yeah it always console logs no upkeep needed. When I tried console logging upkeepneeded variable itself before the if else it says it's undefined

[UnionPAC]

so it's not even grabbing the variable from checkUpkeep ... maybe your spelling is off? How do you spell upKeepNeeded in your contract? I spell it upKeepNeeded and use that same var name when pulling it out of checkUpkeep

[UnionPAC]

const { upkeepNeeded } = await raffle.callStatic.checkUpkeep(checkData)

That is what you have, so check that this matched your contract name for upKeepNeeded

[rpranayr]

Thank you so much!! It worked. I forgot that when extracting variables like this the should be of the same name. 🥇

[UnionPAC]

no problem 🙂 glad you got it all figured out! 👍