feat: refactor usages of chain selectors API to use remote API (#614)

This PR upgrades usages of the chain selectors lib to use the new Remote
API smartcontractkit/chain-selectors#182
Notes:
* The SUI and Aptos chain selectors remote APIs are not implemented yet.
So we are keeping the local ones. Those chains don't have many updates
so it's not as important to support that in the remote API + remote
support is only available on EVM in the meantime.
* A lot of the file changes are just standardising on the import name to
`chainsel`
* There's a couple of `context.Background` that I had to hardcode in the
evm sdk. This is because we still need to provide a `ctx` variable at
the interface level, which would mean a breaking change is introduced
and all chain families sdk would need to be updated. I'd prefer to leave
that for a separate PR to handle communications and keep things isolated
in case of reverts, etc.

---------

Signed-off-by: Pablo <pablo.estrada@smartcontract.com>

Author: ecPablo

.changeset/gold-toes-lose.md

@@ -0,0 +1,5 @@
+---
+"@smartcontractkit/mcms": minor
+---
+
+feat: add remote chain selectors API

docs/docs/usage/building-proposals.md

@@ -20,9 +20,9 @@ object.
 package main
 
 import (
+  "io"
   "log"
   "os"
-  "io"
 
   "github.com/smartcontractkit/mcms"
 )
@@ -49,17 +49,17 @@ For the JSON structure of the proposal please check the [MCMS Proposal Format Do
 
 ### Build Proposal Given Staged but Non-Executed Predecessor Proposals
 
-In scenarios where a proposal is generated with the assumption that multiple proposals are executed beforehand, 
+In scenarios where a proposal is generated with the assumption that multiple proposals are executed beforehand,
 you can enable proposals to be signed in parallel with a pre-determined execution order. This can be achieved
 by passing a list of files using the `WithPredecessors` functional option, as shown below:
 
 ```go
 package main
 
 import (
+  "io"
   "log"
   "os"
-  "io"
 
   "github.com/smartcontractkit/mcms"
 )
@@ -102,7 +102,7 @@ package main
 import (
   "log"
 
-  chain_selectors "github.com/smartcontractkit/chain-selectors"
+  chainsel "github.com/smartcontractkit/chain-selectors"
 
   "github.com/smartcontractkit/mcms"
   "github.com/smartcontractkit/mcms/types"
@@ -111,7 +111,7 @@ import (
 func main() {
   // Step 1: Initialize the ProposalBuilder
   timelockBuilder := mcms.NewProposalBuilder()
-  selector := types.ChainSelector(chain_selectors.ETHEREUM_TESTNET_SEPOLIA.Selector)
+  selector := types.ChainSelector(chainsel.ETHEREUM_TESTNET_SEPOLIA.Selector)
 
   // Step 2: Set Proposal Details
   timelockBuilder.
@@ -198,7 +198,7 @@ package main
 import (
   "log"
 
-  chain_selectors "github.com/smartcontractkit/chain-selectors"
+  chainsel "github.com/smartcontractkit/chain-selectors"
 
   "github.com/smartcontractkit/mcms"
   "github.com/smartcontractkit/mcms/types"
@@ -207,7 +207,7 @@ import (
 func main() {
   // Step 1: Initialize the ProposalBuilder
   builder := mcms.NewTimelockProposalBuilder()
-  selector := types.ChainSelector(chain_selectors.ETHEREUM_TESTNET_SEPOLIA.Selector)
+  selector := types.ChainSelector(chainsel.ETHEREUM_TESTNET_SEPOLIA.Selector)
 
   delay, err := types.ParseDuration("1h")
   if err != nil {
@@ -334,15 +334,15 @@ accounts := []*solana.AccountMeta{
     PublicKey:  solana.MustPublicKeyFromBase58("account pub key"),
     IsSigner:   false,
     IsWritable: true,
-  }
+  },
 }
 
 tx := solana.NewTransaction(
   "programIDGoesHere",
   []byte("data bytes of the instruction"),
   accounts,
   "MySolanaContractType",
-  []string{"tag1", "tag2"}
+  []string{"tag1", "tag2"},
 )
 
 builder.AddOperation(types.Operation{ChainSelector: selector, Transaction: tx})
@@ -367,7 +367,7 @@ tx, err := aptossdk.NewTransaction(
   toAddress,
   []byte("calldata"),
   "MyAptosContractType",
-  []string("tag1", "tag2")
+  []string{"tag1", "tag2"},
 )
 if err != nil {
   panic(err)

docs/docs/usage/executing-proposals.md

@@ -13,7 +13,7 @@ import (
   "github.com/ethereum/go-ethereum/accounts/abi/bind/backends"
   "github.com/gagliardetto/solana-go"
   "github.com/gagliardetto/solana-go/rpc"
-  chain_selectors "github.com/smartcontractkit/chain-selectors"
+  chainsel "github.com/smartcontractkit/chain-selectors"
 
   "github.com/smartcontractkit/mcms"
   "github.com/smartcontractkit/mcms/sdk"
@@ -38,8 +38,8 @@ func main() {
   }
 
   // Step 2: Initialize the Chain Family Executors
-  evmSelector := chain_selectors.ETHEREUM_TESTNET_SEPOLIA.Selector
-  solanaSelector := chain_selectors.SOLANA_DEVNET.Selector
+  evmSelector := chainsel.ETHEREUM_TESTNET_SEPOLIA.Selector
+  solanaSelector := chainsel.SOLANA_DEVNET.Selector
 
   // EVM executor
   backend := backends.SimulatedBackend{}

docs/docs/usage/set-config.md

@@ -14,7 +14,7 @@ import (
   "github.com/ethereum/go-ethereum/common"
   "github.com/gagliardetto/solana-go"
   rpc2 "github.com/gagliardetto/solana-go/rpc"
-  chain_selectors "github.com/smartcontractkit/chain-selectors"
+  chainsel "github.com/smartcontractkit/chain-selectors"
 
   "github.com/smartcontractkit/mcms/sdk/evm"
   mcmsSolana "github.com/smartcontractkit/mcms/sdk/solana"
@@ -45,7 +45,7 @@ func main() {
   ctx := context.Background()
 
   // On EVM
-  solanaSelector := chain_selectors.SOLANA_DEVNET.Selector
+  solanaSelector := chainsel.SOLANA_DEVNET.Selector
   mcmsContractAddr := "0x123"
   backend := backends.SimulatedBackend{}
   auth := &bind.TransactOpts{}

docs/docs/usage/signing-proposals.md

@@ -13,7 +13,7 @@ import (
 
   "github.com/ethereum/go-ethereum/accounts/abi/bind/backends"
   "github.com/gagliardetto/solana-go/rpc"
-  chain_selectors "github.com/smartcontractkit/chain-selectors"
+  chainsel "github.com/smartcontractkit/chain-selectors"
 
   "github.com/smartcontractkit/mcms"
   "github.com/smartcontractkit/mcms/sdk"
@@ -36,7 +36,7 @@ func main() {
   }
 
   // 2. Create the signable type from the proposal
-  selector := chain_selectors.ETHEREUM_TESTNET_SEPOLIA.Selector
+  selector := chainsel.ETHEREUM_TESTNET_SEPOLIA.Selector
 
   // if evm required: Add EVM Inspector
   backend := backends.SimulatedBackend{}
@@ -45,7 +45,7 @@ func main() {
 
   // if solana required: Add Solana Inspector
   client := rpc.New("https://api.devnet.solana.com")
-  inspectorsMap[types.ChainSelector(chain_selectors.SOLANA_DEVNET.Selector)] = solana.NewInspector(client)
+  inspectorsMap[types.ChainSelector(chainsel.SOLANA_DEVNET.Selector)] = solana.NewInspector(client)
 
   // Create Signable
   signable, err := mcms.NewSignable(proposal, inspectorsMap)

docs/docs/usage/timelock-proposal-flow.md

@@ -27,7 +27,7 @@ import (
 
   "github.com/ethereum/go-ethereum/accounts/abi/bind/backends"
   rpc2 "github.com/gagliardetto/solana-go/rpc"
-  chain_selectors "github.com/smartcontractkit/chain-selectors"
+  chainsel "github.com/smartcontractkit/chain-selectors"
 
   "github.com/smartcontractkit/mcms"
   "github.com/smartcontractkit/mcms/sdk"
@@ -52,8 +52,8 @@ func main() {
   }
 
   // 1.1 Convert to MCMS proposal
-  selectorEVM := types.ChainSelector(chain_selectors.ETHEREUM_TESTNET_SEPOLIA.Selector)
-  selectorSolana := types.ChainSelector(chain_selectors.SOLANA_DEVNET.Selector)
+  selectorEVM := types.ChainSelector(chainsel.ETHEREUM_TESTNET_SEPOLIA.Selector)
+  selectorSolana := types.ChainSelector(chainsel.SOLANA_DEVNET.Selector)
 
   convertersMap := make(map[types.ChainSelector]sdk.TimelockConverter)
   convertersMap[selectorEVM] = &evm.TimelockConverter{}

e2e/config.evm.toml

@@ -15,7 +15,7 @@ type = "anvil"
 family = "evm"
 
 [evm_config_b]
-chain_id = "2337"
+chain_id = "11155111"
 image = "f4hrenh9it/foundry:latest"
 port = "8546"
 type = "anvil"

e2e/ledger/ledger_test.go

@@ -11,7 +11,7 @@ import (
 
 	"github.com/stretchr/testify/suite"
 
-	cselectors "github.com/smartcontractkit/chain-selectors"
+	chainsel "github.com/smartcontractkit/chain-selectors"
 
 	"github.com/smartcontractkit/mcms"
 	e2e "github.com/smartcontractkit/mcms/e2e/tests"
@@ -108,7 +108,8 @@ func (s *ManualLedgerSigningTestSuite) setRootEVM(
 	s.Require().NoError(err, "Failed to mine set config transaction")
 
 	// set root
-	executable, err := mcms.NewExecutable(proposal, executorsMap)
+
+	executable, err := mcms.NewExecutable(proposal, executorsMap) //nolint:contextcheck //OPT-400
 	s.Require().NoError(err)
 	tx, err = executable.SetRoot(ctx, s.chainSelectorEVM)
 	s.Require().NoError(err)
@@ -134,7 +135,8 @@ func (s *ManualLedgerSigningTestSuite) setRootSolana(
 	s.Require().NoError(err)
 
 	// set root
-	executable, err := mcms.NewExecutable(proposal, executorsMap)
+
+	executable, err := mcms.NewExecutable(proposal, executorsMap) //nolint:contextcheck //OPT-400
 	s.Require().NoError(err)
 	tx, err := executable.SetRoot(ctx, s.chainSelectorSolana)
 	s.Require().NoError(err)
@@ -151,9 +153,9 @@ func (s *ManualLedgerSigningTestSuite) TestManualLedgerSigning() {
 	ctx := context.Background()
 	s.TestSetup = *e2e.InitializeSharedTestSetup(s.T())
 
-	chainDetailsEVM, err := cselectors.GetChainDetailsByChainIDAndFamily(s.BlockchainA.Out.ChainID, s.BlockchainA.Out.Family)
+	chainDetailsEVM, err := chainsel.GetChainDetailsByChainIDAndFamily(s.BlockchainA.Out.ChainID, s.BlockchainA.Out.Family)
 	s.Require().NoError(err)
-	chainDetailsSolana, err := cselectors.GetChainDetailsByChainIDAndFamily(s.SolanaChain.ChainID, s.SolanaChain.Out.Family)
+	chainDetailsSolana, err := chainsel.GetChainDetailsByChainIDAndFamily(s.SolanaChain.ChainID, s.SolanaChain.Out.Family)
 	s.Require().NoError(err)
 
 	s.chainSelectorEVM = types.ChainSelector(chainDetailsEVM.ChainSelector)

e2e/tests/aptos/common.go

@@ -7,7 +7,7 @@ import (
 
 	"github.com/stretchr/testify/suite"
 
-	cselectors "github.com/smartcontractkit/chain-selectors"
+	chainsel "github.com/smartcontractkit/chain-selectors"
 
 	"github.com/smartcontractkit/chainlink-testing-framework/framework/components/blockchain"
 
@@ -34,7 +34,7 @@ type TestSuite struct {
 
 func (a *TestSuite) SetupSuite() {
 	a.TestSetup = *e2e.InitializeSharedTestSetup(a.T())
-	details, err := cselectors.GetChainDetailsByChainIDAndFamily(a.AptosChain.ChainID, cselectors.FamilyAptos)
+	details, err := chainsel.GetChainDetailsByChainIDAndFamily(a.AptosChain.ChainID, chainsel.FamilyAptos)
 	a.Require().NoError(err)
 	a.ChainSelector = types.ChainSelector(details.ChainSelector)
 

e2e/tests/evm/executable.go

@@ -14,7 +14,7 @@ import (
 	"github.com/samber/lo"
 	"github.com/stretchr/testify/suite"
 
-	cselectors "github.com/smartcontractkit/chain-selectors"
+	chainsel "github.com/smartcontractkit/chain-selectors"
 
 	"github.com/smartcontractkit/mcms"
 	e2e "github.com/smartcontractkit/mcms/e2e/tests"
@@ -76,7 +76,7 @@ func (s *ExecutionTestSuite) SetupSuite() {
 	s.ChainA.auth, err = bind.NewKeyedTransactorWithChainID(privateKey, chainIDA)
 	s.Require().NoError(err, "Failed to create transactor for Chain A")
 
-	chainDetailsA, err := cselectors.GetChainDetailsByChainIDAndFamily(s.BlockchainA.Out.ChainID, s.BlockchainA.Out.Family)
+	chainDetailsA, err := chainsel.GetChainDetailsByChainIDAndFamily(s.BlockchainA.Out.ChainID, s.BlockchainA.Out.Family)
 	s.Require().NoError(err)
 	s.ChainA.chainSelector = mcmtypes.ChainSelector(chainDetailsA.ChainSelector)
 
@@ -87,7 +87,7 @@ func (s *ExecutionTestSuite) SetupSuite() {
 	s.ChainB.auth, err = bind.NewKeyedTransactorWithChainID(privateKey, chainIDB)
 	s.Require().NoError(err, "Failed to create transactor for Chain B")
 
-	chainDetailsB, err := cselectors.GetChainDetailsByChainIDAndFamily(s.BlockchainB.Out.ChainID, s.BlockchainB.Out.Family)
+	chainDetailsB, err := chainsel.GetChainDetailsByChainIDAndFamily(s.BlockchainB.Out.ChainID, s.BlockchainB.Out.Family)
 	s.Require().NoError(err)
 	s.ChainB.chainSelector = mcmtypes.ChainSelector(chainDetailsB.ChainSelector)