Increase AT timeout to 10s in AT_CellularSMS::get_sms

davidalo · davidalo · commit d676084600bb · 2024-04-05T16:46:05.000+02:00
When SMS list is big and baudrate is not fast enough, with default timeout we can suffer from timeout error while getting a sms because method is parsing the full list and this takes long.
diff --git a/connectivity/cellular/source/framework/AT/AT_CellularSMS.cpp b/connectivity/cellular/source/framework/AT/AT_CellularSMS.cpp
@@ -703,6 +703,7 @@ nsapi_size_or_error_t AT_CellularSMS::get_sms(char *buf, uint16_t len, char *pho
     }
 
     _at.lock();
+    _at.set_at_timeout(10s);
 
     nsapi_size_or_error_t err = list_messages();
     if (err == NSAPI_ERROR_OK) {
@@ -716,6 +717,7 @@ nsapi_size_or_error_t AT_CellularSMS::get_sms(char *buf, uint16_t len, char *pho
                     *buf_size = info->msg_size;
                 }
                 free_linked_list();
+                _at.restore_at_timeout();
                 _at.unlock();
                 return NSAPI_ERROR_PARAMETER;
             }
@@ -740,6 +742,7 @@ nsapi_size_or_error_t AT_CellularSMS::get_sms(char *buf, uint16_t len, char *pho
 
     free_linked_list();
 
+    _at.restore_at_timeout();
     _at.unlock();
 
     // update error only when there really was an error, otherwise we return the length

Original file line number	Diff line number	Diff line change
`@@ -703,6 +703,7 @@ nsapi_size_or_error_t AT_CellularSMS::get_sms(char buf, uint16_t len, char pho`
`703`	`703`	`}`
`704`	`704`
`705`	`705`	`_at.lock();`
	`706`	`+ _at.set_at_timeout(10s);`
`706`	`707`
`707`	`708`	`nsapi_size_or_error_t err = list_messages();`
`708`	`709`	`if (err == NSAPI_ERROR_OK) {`
`@@ -716,6 +717,7 @@ nsapi_size_or_error_t AT_CellularSMS::get_sms(char buf, uint16_t len, char pho`
`716`	`717`	`*buf_size = info->msg_size;`
`717`	`718`	`}`
`718`	`719`	`free_linked_list();`
	`720`	`+ _at.restore_at_timeout();`
`719`	`721`	`_at.unlock();`
`720`	`722`	`return NSAPI_ERROR_PARAMETER;`
`721`	`723`	`}`
`@@ -740,6 +742,7 @@ nsapi_size_or_error_t AT_CellularSMS::get_sms(char buf, uint16_t len, char pho`
`740`	`742`
`741`	`743`	`free_linked_list();`
`742`	`744`
	`745`	`+ _at.restore_at_timeout();`
`743`	`746`	`_at.unlock();`
`744`	`747`
`745`	`748`	`// update error only when there really was an error, otherwise we return the length`