Resolves #2146 multistore blog post issue

Author: mgesing

changelog.md

@@ -92,7 +92,8 @@ Merging the contents of different languages must be done manually (migration is
 * Google Analytics: Fixed script error in conjunction with CookieManager
 * #2085 RTL: searchbar button wasn't aligned correctly
 * #2068 RTL: Fixed Page Builder slider positioning, dropdown and other alignments
-* #2019 OffCancas compare: hide horizontal scrollbar 
+* #2019 OffCancas compare: hide horizontal scrollbar
+* #2146 LimitedToStores property was not set in a rare case.
 
 ## Smartstore 4.0.1
 ### New Features

src/Libraries/SmartStore.Services/Stores/StoreMappingService.cs

@@ -87,10 +87,15 @@ public virtual void SaveStoreMappings<T>(T entity, int[] selectedStoreIds) where
         {
             var existingStoreMappings = GetStoreMappings(entity);
             var allStores = _storeService.GetAllStores();
+            var selectedIds = selectedStoreIds ?? Array.Empty<int>();
+
+            entity.LimitedToStores = selectedIds.Length == 1 && selectedIds[0] == 0
+                ? false
+                : selectedIds.Any();
 
             foreach (var store in allStores)
             {
-                if (selectedStoreIds != null && selectedStoreIds.Contains(store.Id))
+                if (selectedIds.Contains(store.Id))
                 {
                     if (!existingStoreMappings.Any(x => x.StoreId == store.Id))
                         InsertStoreMapping(entity, store.Id);
@@ -102,6 +107,8 @@ public virtual void SaveStoreMappings<T>(T entity, int[] selectedStoreIds) where
                         DeleteStoreMapping(storeMappingToDelete);
                 }
             }
+
+            _storeMappingRepository.Context.SaveChanges();
         }
 
         public virtual void InsertStoreMapping(StoreMapping storeMapping)

src/Presentation/SmartStore.Web.Framework/Controllers/ManageController.cs

@@ -58,10 +58,6 @@ protected virtual void SaveStoreMappings<T>(T entity, int[] selectedStoreIds) wh
         {
             Guard.NotNull(entity, nameof(entity));
 
-            entity.LimitedToStores = (selectedStoreIds?.Length ?? 0) == 1 && selectedStoreIds[0] == 0
-                ? false
-                : selectedStoreIds?.Any() ?? false;
-
             Services.Resolve<IStoreMappingService>().SaveStoreMappings(entity, selectedStoreIds);
         }