fixes dist/ imports, adds prettier config, converts more test files to ts

Author: smartyandrewb

.prettierignore

@@ -0,0 +1,7 @@
+# Ignore artifacts:
+.vscode
+README.md
+package.json
+package-lock.json
+dist/
+.idea/

.prettierrc

@@ -0,0 +1,8 @@
+{
+	"trailingComma": "all",
+	"useTabs": true,
+	"semi": true,
+	"singleQuote": false,
+	"bracketSpacing": true,
+	"printWidth": 100
+}

index.mjs

@@ -2,11 +2,9 @@
  * this files is the entry point for rollup to bundle the library
  * it exports all the classes and functions as named exports
  */
-import AgentSender from "./src/AgentSender.js";
 import Batch from "./src/Batch.js";
 import ClientBuilder from "./src/ClientBuilder.js";
 import buildClient from "./src/util/buildClients.js";
-import Request from "./src/Request.js";
 import SharedCredentials from "./src/SharedCredentials.js";
 import StaticCredentials from "./src/StaticCredentials.js";
 import Errors from "./src/Errors.js";
@@ -35,11 +33,9 @@ import LookupUSEnrichment from "./src/us_enrichment/Lookup.js";
 import ResponseUSEnrichment from "./src/us_enrichment/Response.js";
 
 export const core = {
-	AgentSender,
 	Batch,
 	ClientBuilder,
 	buildClient,
-	Request,
 	SharedCredentials,
 	StaticCredentials,
 	Errors,

package-lock.json

@@ -59,6 +59,7 @@
   "@types/node": "^22.15.17",
   "chai": "^4.3.6",
   "mocha": "^11.2.2",
+  "prettier": "3.6.2",
   "rollup": "^4.40.2",
   "rollup-plugin-delete": "^3.0.1",
   "tsx": "^4.20.3",

package.json

@@ -1,20 +1,24 @@
 import { expect } from "chai";
-import * as SmartySDK from "../dist/esm/index.mjs";
+import AgentSender from "../src/AgentSender.js";
+import Request from "../src/Request.js";
+import Response from "../src/Response.js";
+import { Sender } from "../src/types.js";
 import packageJson from "../package.json" with { type: "json" };
 
 describe("An agent sender", function () {
 	it("attaches an 'agent' parameter to the request config.", function () {
-		class MockSender {
+		class MockSender implements Sender {
 			agentString = "";
 
-			send = (request: any) => {
-				this.agentString = request.parameters.agent;
+			send = (request: Request) => {
+				this.agentString = (request.parameters as Record<string, string>)["agent"];
+				return Promise.resolve(new Response(200, {}));
 			};
 		}
 
 		const mockSender = new MockSender();
-		const agentSender = new SmartySDK.core.AgentSender(mockSender);
-		const request = new SmartySDK.core.Request();
+		const agentSender = new AgentSender(mockSender);
+		const request = new Request();
 		const expectedAgentString = `smarty (sdk:javascript@${packageJson.version})`;
 
 		agentSender.send(request);

tests/test_AgentSender.ts

@@ -1,40 +1,51 @@
-const chai = require("chai");
-const expect = chai.expect;
-const RetrySender = require("../dist/cjs/RetrySender.cjs").default;
-const { MockSenderWithStatusCodesAndHeaders } = require("./fixtures/mock_senders");
-const Request = require("../src/Request.js");
-const MockSleeper = require("./fixtures/MockSleeper.js");
-
-async function sendWithRetry(retries, inner, sleeper) {
+import { expect } from "chai";
+import RetrySender from "../src/RetrySender.js";
+import { MockSenderWithStatusCodesAndHeaders } from "./fixtures/mock_senders.js";
+import Request from "../src/Request.js";
+import MockSleeper from "./fixtures/MockSleeper.js";
+
+async function sendWithRetry(retries: number, inner: any, sleeper: any) {
 	const request = new Request();
 	const sender = new RetrySender(retries, inner, sleeper);
 	return await sender.send(request);
 }
 
 describe("Retry Sender tests", function () {
 	it("test success does not retry", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["200"]);
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)(["200"]);
 		await sendWithRetry(5, inner, new MockSleeper());
 
 		expect(inner.currentStatusCodeIndex).to.equal(1);
 	});
 
 	it("test client error does not retry", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["422"]);
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)(["422"]);
 		await sendWithRetry(5, inner, new MockSleeper());
 
 		expect(inner.currentStatusCodeIndex).to.equal(1);
 	});
 
 	it("test will retry until success", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["500", "500", "500", "200", "500"]);
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)([
+			"500",
+			"500",
+			"500",
+			"200",
+			"500",
+		]);
 		await sendWithRetry(10, inner, new MockSleeper());
 
 		expect(inner.currentStatusCodeIndex).to.equal(4);
 	});
 
 	it("test return response if retry limit exceeded", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["500", "500", "500", "500", "500"]);
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)([
+			"500",
+			"500",
+			"500",
+			"500",
+			"500",
+		]);
 		const sleeper = new MockSleeper();
 		const response = await sendWithRetry(4, inner, sleeper);
 
@@ -45,7 +56,7 @@ describe("Retry Sender tests", function () {
 	});
 
 	it("test backoff does not exceed max", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders([
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)([
 			"500",
 			"500",
 			"500",
@@ -69,14 +80,14 @@ describe("Retry Sender tests", function () {
 	});
 
 	it("test empty status does not retry", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders([]);
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)([]);
 		await sendWithRetry(5, inner, new MockSleeper());
 
 		expect(inner.currentStatusCodeIndex).to.equal(1);
 	});
 
 	it("test sleep on rate limit", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["429", "200"]);
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)(["429", "200"]);
 		const sleeper = new MockSleeper();
 
 		await sendWithRetry(5, inner, sleeper);
@@ -85,7 +96,7 @@ describe("Retry Sender tests", function () {
 	});
 
 	it("test rate limit error return", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["429"], { "Retry-After": 7 });
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)(["429"], { "Retry-After": 7 });
 		const sleeper = new MockSleeper();
 
 		await sendWithRetry(10, inner, sleeper);
@@ -94,7 +105,7 @@ describe("Retry Sender tests", function () {
 	});
 
 	it("test retry after invalid value", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["429"], { "Retry-After": "a" });
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)(["429"], { "Retry-After": "a" });
 		const sleeper = new MockSleeper();
 
 		await sendWithRetry(10, inner, sleeper);
@@ -103,11 +114,11 @@ describe("Retry Sender tests", function () {
 	});
 
 	it("test retry error", async function () {
-		let inner = new MockSenderWithStatusCodesAndHeaders(["429"], undefined, "Big Bad");
+		let inner = new (MockSenderWithStatusCodesAndHeaders as any)(["429"], undefined, "Big Bad");
 		const sleeper = new MockSleeper();
 
 		const response = await sendWithRetry(10, inner, sleeper);
 
 		expect(response.error).to.equal("Big Bad");
 	});
-});
+});

tests/test_RetrySender.js renamed to tests/test_RetrySender.ts

@@ -1,40 +1,38 @@
 {
-  "compilerOptions": {
-    "emitDeclarationOnly": true,
-    "declaration": true,
-    "outDir": "dist/types",
-    "baseUrl": ".",
-    "paths": {
-      "@/*": ["./*"]
-    },
-    "allowJs": true,
-    "alwaysStrict": true,
-    "exactOptionalPropertyTypes": true,
-    "noPropertyAccessFromIndexSignature": true,
-    "noImplicitAny": true,
-    "noImplicitReturns": true,
-    "noImplicitOverride": true,
-    "noFallthroughCasesInSwitch": true,
-    "allowUnreachableCode": false,
-    "allowUnusedLabels": false,
-    "noImplicitThis": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "forceConsistentCasingInFileNames": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "noEmit": true,
-    "incremental": true,
-    "module": "esnext",
-    "esModuleInterop": true,
-    "moduleResolution": "node",
-    "resolveJsonModule": true,
-    "isolatedModules": true,
-    "jsx": "preserve",
-    "types": ["mocha", "chai", "node"]
-  },
-  "include": ["src/**/*", "tests/**/*.ts"],
-  "exclude": [
-    "node_modules"
-  ]
+	"compilerOptions": {
+		"emitDeclarationOnly": true,
+		"declaration": true,
+		"outDir": "dist/types",
+		"baseUrl": ".",
+		"paths": {
+			"@/*": ["./*"]
+		},
+		"allowJs": true,
+		"alwaysStrict": true,
+		"exactOptionalPropertyTypes": true,
+		"noPropertyAccessFromIndexSignature": true,
+		"noImplicitAny": true,
+		"noImplicitReturns": true,
+		"noImplicitOverride": true,
+		"noFallthroughCasesInSwitch": true,
+		"allowUnreachableCode": false,
+		"allowUnusedLabels": false,
+		"noImplicitThis": true,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
+		"forceConsistentCasingInFileNames": true,
+		"skipLibCheck": true,
+		"strict": true,
+		"noEmit": true,
+		"incremental": true,
+		"module": "esnext",
+		"esModuleInterop": true,
+		"moduleResolution": "node",
+		"resolveJsonModule": true,
+		"isolatedModules": true,
+		"jsx": "preserve",
+		"types": ["mocha", "chai", "node"]
+	},
+	"include": ["src/**/*", "tests/**/*"],
+	"exclude": ["node_modules"]
 }