Commit 8fa431c
[CIR][Bugfix] renames minor/major parameters of the OpenCLVersionAttr (llvm#845)
Looks like certain names should not be used - I even could not build CIR
on the Ubuntu with a relatively old glibc version.
In this case `minor` and `major` are macroses and can not be used in
this context.
You can take a look at the comments in the
[mlir/test/lib/Dialect/Test/TestDialect.h](https://github.com/llvm/clangir/blob/main/mlir/test/lib/Dialect/Test/TestDialect.h#L70)
reference as well1 parent f3e5669 commit 8fa431c
File tree
2 files changed
+4
-4
lines changed- clang
- include/clang/CIR/Dialect/IR
- lib/CIR/Lowering/DirectToLLVM
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
| 168 | + | |
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
0 commit comments