refactor: extract Class identifier logic.

Author: smeghead

src/DiagramElement/ClassIdentifier.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smeghead\PhpClassDiagram\DiagramElement;
+
+use Smeghead\PhpClassDiagram\Config\Options;
+
+final class ClassIdentifier {
+    public function __construct(private Options $options, private string $directory, private Entry $entry)
+    {
+    }
+
+    public function getIdentifier(): string {
+        $meta = $this->entry->getClass()->getClassType()->getMetaName();
+        $classSummary = ($this->options->classNameSummary()
+            ? $this->entry->getClass()->getDescription()
+            : '');
+        return sprintf(
+            '%s "%s" as %s%s',
+            $meta,
+            $this->entry->getClass()->getClassType()->getName() . (empty($classSummary) ? '' : sprintf("\\n<b>%s</b>", $classSummary)),
+            $this->entry->getClass()->getClassNameAlias(),
+            $this->getLinkExpression($meta)
+        );
+    }
+
+    private function getLinkExpression(string $meta): string
+    {
+        if (empty($this->options->svgTopurl())) {
+            return '';
+        }
+        $path = sprintf(
+            '/%s%s.php',
+            empty($this->directory) ? '' : sprintf('%s/', $this->directory),
+            $this->entry->getClass()->getClassType()->getName());
+        return sprintf(
+            ' [[%s %s %s]]',
+            $path,
+            $this->entry->getClass()->getClassType()->getName(),
+            ucfirst($meta)
+        );
+    }
+}

src/DiagramElement/Entry.php

@@ -48,17 +48,9 @@ public function dump(int $level = 0): array
     {
         $indent = str_repeat('  ', $level);
         $lines = [];
-        $meta = $this->class->getClassType()->getMetaName();
-        $classSummary = ($this->options->classNameSummary()
-            ? $this->class->getDescription()
-            : '');
-        $classIdentifier = sprintf(
-            '%s "%s" as %s%s',
-            $meta,
-            $this->class->getClassType()->getName() . (empty($classSummary) ? '' : sprintf("\\n<b>%s</b>", $classSummary)),
-            $this->class->getClassNameAlias(),
-            $this->getLinkExpression($meta)
-        );
+        $identifier = new ClassIdentifier($this->options, $this->directory, $this);
+        $classIdentifier = $identifier->getIdentifier();
+
         if ($this->options->classProperties() || $this->options->classMethods()) {
             $lines[] = sprintf('%s%s {', $indent, $classIdentifier);
             if ($this->options->classProperties()) {
@@ -192,21 +184,4 @@ public function getUsingArrows(): array
         }
         return $arrows;
     }
-
-    private function getLinkExpression(string $meta): string
-    {
-        if (empty($this->options->svgTopurl())) {
-            return '';
-        }
-        $path = sprintf(
-            '/%s%s.php',
-            empty($this->directory) ? '' : sprintf('%s/', $this->directory),
-            $this->class->getClassType()->getName());
-        return sprintf(
-            ' [[%s %s %s]]',
-            $path,
-            $this->class->getClassType()->getName(),
-            ucfirst($meta)
-        );
-    }
 }

test/DiagramElement/ClassIdentifierTest.php

@@ -0,0 +1,66 @@
+<?php
+
+declare(strict_types=1);
+
+use PHPUnit\Framework\TestCase;
+use Smeghead\PhpClassDiagram\Config\Options;
+use Smeghead\PhpClassDiagram\DiagramElement\ClassIdentifier;
+use Smeghead\PhpClassDiagram\DiagramElement\Entry;
+use Smeghead\PhpClassDiagram\Php\PhpReader;
+
+final class ClassIdentifierTest extends TestCase
+{
+    private string $fixtureDir;
+
+    public function setUp(): void
+    {
+        $this->fixtureDir = realpath(sprintf('%s/../fixtures', __DIR__));
+    }
+
+    public function testClass(): void
+    {
+        $directory = sprintf('%s/namespace', $this->fixtureDir);
+
+        $options = new Options([]);
+        $entry = $this->getTargetEntry('product/Product.php', $directory, $options);
+
+        $sut = new ClassIdentifier($options, 'product', $entry);
+
+        $this->assertSame('class "Product" as product_Product', $sut->getIdentifier());
+    }
+
+    public function testInterface(): void
+    {
+        $directory = sprintf('%s/interface', $this->fixtureDir);
+
+        $options = new Options([]);
+        $entry = $this->getTargetEntry('product/Interface_.php', $directory, $options);
+
+        $sut = new ClassIdentifier($options, 'product', $entry);
+
+        $this->assertSame('interface "Interface_" as product_Interface_', $sut->getIdentifier());
+    }
+
+    public function testEnum(): void
+    {
+        $directory = sprintf('%s/enum', $this->fixtureDir);
+
+        $options = new Options([]);
+        $entry = $this->getTargetEntry('TestEnum.php', $directory, $options);
+
+        $sut = new ClassIdentifier($options, '', $entry);
+
+        $this->assertSame('enum "Suit\n<b>スート</b>" as Suit', $sut->getIdentifier());
+    }
+
+    private function getTargetEntry(string $path, string $directory, Options $options): Entry
+    {
+        $filename = sprintf('%s/%s', $directory, $path);
+        $classes = PhpReader::parseFile($directory, $filename, $options);
+        if (count($classes) === 0) {
+            throw new \Exception('class not found.');
+        }
+        return new Entry(dirname($path), $classes[0]->getInfo(), $options); 
+    }
+
+}