Build fixes for Windows

Author: birdofpreyru

CMakeLists.txt

@@ -100,13 +100,17 @@ if(CMAKE_SYSTEM_NAME MATCHES "Android|Windows")
   set(BUILD_SHARED_LIBS 1)
 endif()
 
-# These enforce pkg_check_modules(), find_program(), etc. in Lighttpd CMake
-# config to look for local build of PCRE2 in the location it was installed to.
-set(CMAKE_PREFIX_PATH "${CMAKE_BINARY_DIR}/sysroot")
-
-# TODO: Not sure now, whether this is needed, or already covered by the variable
-# above.
-set(CMAKE_FIND_ROOT_PATH "${CMAKE_BINARY_DIR}/sysroot")
+# Above we have build & installed a local version of PCRE2 library, now we want
+# to enforce Lighttpd build to see and use it (rather than any system-wide
+# installation of another PCRE2 version). On Ubuntu / macOS it can be done
+# by setting
+#
+# set(CMAKE_PREFIX_PATH "${CMAKE_BINARY_DIR}/sysroot")
+#
+# however when building for Windows inside Msys2 / UCRT64 this just has
+# no effect for reasons beyond my understanding. Setting PKG_CONFIG_PATH
+# environment variable to the folder with PCRE2 .pc file works though.
+set(ENV{PKG_CONFIG_PATH} "${CMAKE_BINARY_DIR}/sysroot/lib/pkgconfig")
 
 add_subdirectory(lighttpd1.4)
 

windows/ReactNativeStaticServer/Server.cpp

@@ -35,6 +35,14 @@ void LoadLighttpdDll() {
         // an UWP app by this library, so failure to locate and load them is
         // a fatal crash, meaning there is something wrong with our library,
         // and we terminate the app in such case.
+        //
+        // NOTE: The next few lines retrieve the failure cause, but don't forward it anywhere,
+        // for now they can be seen in debugger.
+        DWORD errcode = GetLastError();
+        LPSTR errmsg = nullptr;
+        FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
+          NULL, errcode, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)& errmsg, 0, NULL);
+
         terminate();
     }
 }