fix(go): use shape from the symbol properties in getType utils function (#764)

Author: rishav-karanjit

codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/codegen/SymbolUtils.java

@@ -29,6 +29,7 @@ public final class SymbolUtils {
   public static final String GO_SLICE = "goSlice";
   public static final String GO_MAP = "goMap";
   public static final String GO_ELEMENT_TYPE = "goElementType";
+  public static final String SHAPE = "shape";
 
   // Used when a given shape must be represented differently on input.
   public static final String INPUT_VARIANT = "inputVariant";
@@ -66,7 +67,7 @@ public static Symbol.Builder createValueSymbolBuilder(
     Shape shape,
     String typeName
   ) {
-    return createValueSymbolBuilder(typeName).putProperty("shape", shape);
+    return createValueSymbolBuilder(typeName).putProperty(SHAPE, shape);
   }
 
   /**
@@ -80,7 +81,7 @@ public static Symbol.Builder createPointableSymbolBuilder(
     Shape shape,
     String typeName
   ) {
-    return createPointableSymbolBuilder(typeName).putProperty("shape", shape);
+    return createPointableSymbolBuilder(typeName).putProperty(SHAPE, shape);
   }
 
   /**

codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/codegen/ValidationGenerator.java

@@ -514,7 +514,6 @@ private void renderListShape(
         );
         final var inputType = GoCodegenUtils.getType(
           symbolProvider.toSymbol(currentShape),
-          currentShape,
           isExternalShape
         );
         if (isExternalShape) {
@@ -611,7 +610,6 @@ private void renderMapShape(
         );
         final var inputType = GoCodegenUtils.getType(
           symbolProvider.toSymbol(currentShape),
-          currentShape,
           isExternalShape
         );
         if (isExternalShape) {
@@ -684,7 +682,6 @@ private void renderUnionShape(
         !currShapeNamespace.startsWith("smithy");
       final var inputType = GoCodegenUtils.getType(
         symbolProvider.toSymbol(currentShape),
-        currentShape,
         isExternalShape
       );
       if (isExternalShape) {

codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/localservice/DafnyLocalServiceTypeConversionProtocol.java

@@ -484,7 +484,6 @@ public void generateOrphanShapeSerializer(
         inputType =
           GoCodegenUtils.getType(
             context.symbolProvider().toSymbol(resourceOrService),
-            resourceOrService,
             true
           );
       } else {
@@ -497,7 +496,7 @@ public void generateOrphanShapeSerializer(
             .concat(context.symbolProvider().toSymbol(serviceShape).getName());
       }
     } else {
-      inputType = GoCodegenUtils.getType(curSymbol, shape, true);
+      inputType = GoCodegenUtils.getType(curSymbol, true);
       outputType = DafnyNameResolver.getDafnyType(shape, curSymbol);
     }
     writerDelegator.useFileWriter(
@@ -992,11 +991,7 @@ public void generateOrphanShapeDeserializer(
       }
     } else {
       outputType =
-        GoCodegenUtils.getType(
-          context.symbolProvider().toSymbol(shape),
-          shape,
-          true
-        );
+        GoCodegenUtils.getType(context.symbolProvider().toSymbol(shape), true);
     }
     writerDelegator.useFileWriter(
       "%s/%s".formatted(
@@ -1858,7 +1853,6 @@ private void generateSerializerFunctions(
           inputType =
             GoCodegenUtils.getType(
               context.symbolProvider().toSymbol(visitingShape),
-              visitingShape,
               true
             );
           Boolean isPointable = context
@@ -1891,7 +1885,6 @@ private void generateSerializerFunctions(
                 inputType =
                   GoCodegenUtils.getType(
                     context.symbolProvider().toSymbol(resourceOrService),
-                    resourceOrService,
                     true
                   );
               } else {
@@ -1962,7 +1955,6 @@ private void generateDeserializerFunctions(
           alreadyVisited.add(visitingMemberShape.toShapeId());
           var outputType = GoCodegenUtils.getType(
             context.symbolProvider().toSymbol(visitingShape),
-            visitingShape,
             true
           );
           Boolean isPointable = context

codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/localservice/shapevisitor/DafnyToSmithyShapeVisitor.java

@@ -459,7 +459,7 @@ public String listShape(final ListShape shape) {
       	}
       	fieldValue = append(fieldValue, %s)}
       	""".formatted(
-          GoCodegenUtils.getType(symbol, shape, true),
+          GoCodegenUtils.getType(symbol, true),
           dataSource,
           ShapeVisitorHelper.toNativeShapeVisitorWriter(
             memberShape,

codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/smithygo/utils/GoCodegenUtils.java

@@ -54,19 +54,20 @@ public static String getType(
 
   public static String getType(
     final Symbol symbol,
-    final Shape shape,
     final Boolean includeNamespace
   ) {
     if (
       symbol.getProperty(SymbolUtils.GO_ELEMENT_TYPE, Symbol.class).isEmpty()
     ) {
       return includeNamespace
-        ? SmithyNameResolver.getSmithyType(shape, symbol)
+        ? SmithyNameResolver.getSmithyType(
+          symbol.expectProperty(SymbolUtils.SHAPE, Shape.class),
+          symbol
+        )
         : symbol.getName();
     }
     var type = getType(
       symbol.expectProperty(SymbolUtils.GO_ELEMENT_TYPE, Symbol.class),
-      shape,
       includeNamespace
     );
     if (symbol.getProperty(SymbolUtils.GO_MAP).isPresent()) {