Skip to content

Commit 16766fe

Browse files
committed
Add exit code and change name of Time metric
1 parent eeedd40 commit 16766fe

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

mcp/mcp-cli-api/src/main/java/software/amazon/smithy/java/mcp/cli/CliMetrics.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,14 @@ public void addTiming(String name, long time) {
3131
timings.put(name, time);
3232
}
3333

34+
public int exitCode(int exitCode) {
35+
telemetryData.exitCode(exitCode);
36+
return exitCode;
37+
}
38+
3439
@Override
3540
public void close() {
36-
timings.put("Time", System.nanoTime() - startTime);
41+
timings.put("ExecutionTime", System.nanoTime() - startTime);
3742
telemetryData
3843
.counters(counters)
3944
.timings(timings)

mcp/mcp-cli-api/src/main/java/software/amazon/smithy/java/mcp/cli/SmithyMcpCommand.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,17 @@ public final Integer call() {
4343
telemetry.command(commandName)
4444
.cliVersion(spec.version()[0]);
4545

46-
try (var metrics = new CliMetrics(TELEMETRY_PUBLISHER, telemetry)) {
46+
var metrics = new CliMetrics(TELEMETRY_PUBLISHER, telemetry);
47+
try (metrics) {
4748
var config = loadOrCreateConfig();
4849
execute(new ExecutionContext(config, RegistryUtils.getRegistry(registryToUse(config), config), metrics));
49-
return 0;
50+
return metrics.exitCode(0);
5051
} catch (IllegalArgumentException e) {
5152
System.out.println("Invalid input : [" + e.getMessage() + "]");
52-
return 2;
53+
return metrics.exitCode(2);
5354
} catch (Exception e) {
5455
e.printStackTrace(System.out);
55-
return 1;
56+
return metrics.exitCode(1);
5657
}
5758
}
5859

mcp/mcp-cli-api/src/main/resources/META-INF/smithy/mcp-cli-api.smithy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ structure TelemetryData {
4444
@default({})
4545
timings: Timings
4646

47+
@required
48+
exitCode: Integer
49+
4750
params: String
4851
}
4952

0 commit comments

Comments
 (0)