Convert Document.create* to Document.of

Now Documents are all created using Document.of, Document.ofNumber, and
Document.ofObject. These methods remove the old methods like
createString, createNumber, createStringMap, etc. ofNumber and ofObject
are separate to avoid boxed numbers and booleans from going through them
rather than of(boolean) for example.

Author: mtdowling

client-core/src/main/java/software/amazon/smithy/java/client/core/ClientTransportFactory.java

@@ -52,7 +52,7 @@ default byte priority() {
      * <p>Transports must be able to be instantiated without any arguments for use in dynamic clients.
      */
     default ClientTransport<RequestT, ResponseT> createTransport() {
-        return createTransport(Document.createStringMap(Collections.emptyMap()));
+        return createTransport(Document.of(Collections.emptyMap()));
     }
 
     /**

client-core/src/test/java/software/amazon/smithy/java/client/core/ClientPipelineTest.java

@@ -182,7 +182,7 @@ public Builder toBuilder() {
             })
             .build();
 
-        var response = client.call("GetSprocket", Document.createFromObject(Map.of("id", "1")));
+        var response = client.call("GetSprocket", Document.ofObject(Map.of("id", "1")));
 
         assertThat(mockQueue.remaining(), is(0));
         assertThat(response.getMember("id").asString(), equalTo("1"));

client-core/src/test/java/software/amazon/smithy/java/client/core/plugins/InjectIdempotencyTokenPluginTest.java

@@ -72,7 +72,7 @@ public class InjectIdempotencyTokenPluginTest {
 
     @Test
     public void injectsToken() {
-        var token = callAndGetToken("CreateSprocket", Document.createFromObject(Map.of("id", "1")));
+        var token = callAndGetToken("CreateSprocket", Document.ofObject(Map.of("id", "1")));
 
         assertThat(token, not(nullValue()));
         assertThat(token.length(), greaterThan(0));
@@ -101,28 +101,28 @@ private String callAndGetToken(String operation, Document input) {
             .addPlugin(mock)
             .build();
 
-        client.call(operation, Document.createFromObject(input));
+        client.call(operation, Document.of(input));
         assertThat(mock.getRequests(), not(empty()));
         return mock.getRequests().get(0).request().headers().firstValue("x-token");
     }
 
     @Test
     public void doesNotInjectToken() {
-        var token = callAndGetToken("CreateSprocketNoToken", Document.createFromObject(Map.of("id", "1")));
+        var token = callAndGetToken("CreateSprocketNoToken", Document.ofObject(Map.of("id", "1")));
 
         assertThat(token, nullValue());
     }
 
     @Test
     public void usesProvidedToken() {
-        var token = callAndGetToken("CreateSprocket", Document.createFromObject(Map.of("id", "1", "token", "xyz")));
+        var token = callAndGetToken("CreateSprocket", Document.ofObject(Map.of("id", "1", "token", "xyz")));
 
         assertThat(token, equalTo("xyz"));
     }
 
     @Test
     public void ignoresEmptyStringToken() {
-        var token = callAndGetToken("CreateSprocket", Document.createFromObject(Map.of("id", "1", "token", "")));
+        var token = callAndGetToken("CreateSprocket", Document.ofObject(Map.of("id", "1", "token", "")));
 
         assertThat(token, notNullValue());
         assertThat(token, not(equalTo("")));

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/DefaultsTest.java

@@ -40,12 +40,12 @@ void setsCorrectDefault() {
         defaults.streamingBlob()
             .asByteBuffer()
             .thenAccept(b -> assertEquals(b, ByteBuffer.wrap(Base64.getDecoder().decode("c3RyZWFtaW5n"))));
-        assertEquals(defaults.boolDoc(), Document.createBoolean(true));
-        assertEquals(defaults.stringDoc(), Document.createString("string"));
-        assertEquals(defaults.numberDoc(), Document.createInteger(1));
-        assertEquals(defaults.floatingPointnumberDoc(), Document.createDouble(1.2));
-        assertEquals(defaults.listDoc(), Document.createList(Collections.emptyList()));
-        assertEquals(defaults.mapDoc(), Document.createStringMap(Collections.emptyMap()));
+        assertEquals(defaults.boolDoc(), Document.of(true));
+        assertEquals(defaults.stringDoc(), Document.of("string"));
+        assertEquals(defaults.numberDoc(), Document.of(1));
+        assertEquals(defaults.floatingPointnumberDoc(), Document.of(1.2));
+        assertEquals(defaults.listDoc(), Document.of(Collections.emptyList()));
+        assertEquals(defaults.mapDoc(), Document.of(Collections.emptyMap()));
         assertEquals(defaults.list(), List.of());
         assertEquals(defaults.map(), Map.of());
         assertEquals(defaults.timestamp(), Instant.parse("1985-04-12T23:20:50.52Z"));

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/ListsTest.java

@@ -126,7 +126,7 @@ static Stream<SerializableShape> listTypes() {
                 .build(),
             ListAllTypesInput.builder()
                 .listOfDocuments(
-                    List.of(Document.createDouble(2.0), Document.createString("string"))
+                    List.of(Document.of(2.0), Document.of("string"))
                 )
                 .build()
         );
@@ -240,7 +240,7 @@ static Stream<SerializableShape> sparseLists() {
                 .build(),
             SparseListsInput.builder()
                 .listOfDocuments(
-                    ListUtils.of(Document.createDouble(2.0), null, Document.createString("string"))
+                    ListUtils.of(Document.of(2.0), null, Document.of("string"))
                 )
                 .build()
         );
@@ -264,8 +264,8 @@ void nullDistinctFromEmpty() {
         // Collections should return empty collections for access
         assertEquals(emptyInput.listOfBoolean(), Collections.emptyList());
         assertEquals(emptyInput.listOfBoolean(), nullInput.listOfBoolean());
-        var emptyDocument = Document.createTyped(emptyInput);
-        var nullDocument = Document.createTyped(nullInput);
+        var emptyDocument = Document.of(emptyInput);
+        var nullDocument = Document.of(nullInput);
         assertNotNull(emptyDocument.getMember("listOfBoolean"));
         assertNull(nullDocument.getMember("listOfBoolean"));
     }

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/MapsTest.java

@@ -288,8 +288,8 @@ void nullDistinctFromEmpty() {
         assertEquals(emptyInput.stringBooleanMap(), Collections.emptyMap());
         assertEquals(emptyInput.stringBooleanMap(), nullInput.stringBooleanMap());
 
-        var emptyDocument = Document.createTyped(emptyInput);
-        var nullDocument = Document.createTyped(nullInput);
+        var emptyDocument = Document.of(emptyInput);
+        var nullDocument = Document.of(nullInput);
         assertNotNull(emptyDocument.getMember("stringBooleanMap"));
         assertNull(nullDocument.getMember("stringBooleanMap"));
     }

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/RecursionTests.java

@@ -114,7 +114,7 @@ void multiplyRecursiveUnionWorks() {
                 )
             )
         );
-        var document = Document.createTyped(recursive);
+        var document = Document.of(recursive);
         var builder = AttributeValue.builder();
         document.deserializeInto(builder);
         var output = builder.build();

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/StructuresTest.java

@@ -45,7 +45,7 @@ public class StructuresTest {
     static Stream<SerializableShape> memberTypes() {
         return Stream.of(
             BooleanMembersInput.builder().requiredBoolean(true).build(),
-            DocumentMembersInput.builder().requiredDoc(Document.createString("str")).build(),
+            DocumentMembersInput.builder().requiredDoc(Document.of("str")).build(),
             ListMembersInput.builder().requiredList(List.of("a", "b", "c")).build(),
             MapMembersInput.builder().requiredMap(Map.of("a", "b")).build(),
             BigDecimalMembersInput.builder().requiredBigDecimal(BigDecimal.valueOf(1.0)).build(),

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/UnionTest.java

@@ -60,7 +60,7 @@ static Stream<SerializableShape> unionTypes() {
     @ParameterizedTest
     @MethodSource("unionTypes")
     void pojoToDocumentRoundTrip(UnionType pojo) {
-        var document = Document.createTyped(pojo);
+        var document = Document.of(pojo);
         var builder = UnionType.builder();
         document.deserializeInto(builder);
         var output = builder.build();
@@ -70,7 +70,7 @@ void pojoToDocumentRoundTrip(UnionType pojo) {
 
     record UnknownDocument() implements Document {
 
-        private static final Map<String, Document> members = Map.of("UNKNOWN!!!", Document.createDouble(3.2));
+        private static final Map<String, Document> members = Map.of("UNKNOWN!!!", Document.of(3.2));
 
         @Override
         public ShapeType type() {
@@ -112,6 +112,6 @@ void unknownUnionDeser() {
     @Test
     void unknownUnionSerFails() {
         var union = UnionType.builder().$unknownMember("foo").build();
-        assertThrows(SerializationException.class, () -> Document.createTyped(union));
+        assertThrows(SerializationException.class, () -> Document.of(union));
     }
 }

codegen/core/src/it/java/software/amazon/smithy/java/codegen/test/Utils.java

@@ -15,7 +15,7 @@ final class Utils {
     private Utils() {}
 
     static <T extends SerializableStruct> T pojoToDocumentRoundTrip(T pojo) {
-        var document = Document.createTyped(pojo);
+        var document = Document.of(pojo);
         ShapeBuilder<T> builder = getBuilder(pojo);
         document.deserializeInto(builder);
         return builder.build();